From: Sagi Grimberg <firstname.lastname@example.org> To: Ming Lei <email@example.com>, Stephen Rust <firstname.lastname@example.org> Cc: Rob Townley <email@example.com>, Christoph Hellwig <firstname.lastname@example.org>, Jens Axboe <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, Doug Ledford <email@example.com>, Jason Gunthorpe <firstname.lastname@example.org>, Max Gurtovoy <email@example.com> Subject: Re: Data corruption in kernel 5.1+ with iSER attached ramdisk Date: Thu, 5 Dec 2019 01:17:41 -0800 Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <20191204230225.GA26189@ming.t460p> >> Hi Ming, >> >> I have tried your latest "workaround" patch in brd including the fix >> for large offsets, and it does appear to work. I tried the same tests >> and the data was written correctly for all offsets I tried. Thanks! >> >> I include the updated additional bpftrace below. >> >>> So firstly, I'd suggest to investigate from RDMA driver side to see why >>> un-aligned buffer is passed to block layer. >>> >>> According to previous discussion, 512 aligned buffer should be provided >>> to block layer. >>> >>> So looks the driver needs to be fixed. >> >> If it does appear to be an RDMA driver issue, do you know who we >> should follow up with directly from the RDMA driver side of the world? >> >> Presumably non-brd devices, ie: real scsi devices work for these test >> cases because they accept un-aligned buffers? > > Right, not every driver supports such un-aligned buffer. > > I am not familiar with RDMA, but from the trace we have done so far, > it is highly related with iser driver. Hi guys, Just got this one (Thanks for CCing me Ming, been extremely busy lately). So it looks from the report that this is the immediate-data and unsolicited data-out flows, which indeed seem to violate the alignment assumption. The reason is that isert post recv a contig rx_desc which has both the headers and the data, and when it gets immediate_data it will set the data sg to rx_desc+offset (which are the headers). Stephen, As a work-around for now, you should turn off immediate-data in your LIO target. I'll work on a fix. Thanks for reporting!
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <CAAFE1bd9wuuobpe4VK7Ty175j7mWT+kRmHCNhVD+6R8MWEAqmw@mail.gmail.com> 2019-11-28 1:57 ` Ming Lei [not found] ` <CA+VdTb_-CGaPjKUQteKVFSGqDz-5o-tuRRkJYqt8B9iOQypiwQ@mail.gmail.com> 2019-11-28 2:58 ` Ming Lei [not found] ` <CAAFE1bfsXsKGyw7SU_z4NanT+wmtuJT=XejBYbHHMCDQwm73sw@mail.gmail.com> 2019-11-28 4:25 ` Stephen Rust 2019-11-28 5:51 ` Rob Townley 2019-11-28 9:12 ` Ming Lei 2019-12-02 18:42 ` Stephen Rust 2019-12-03 0:58 ` Ming Lei 2019-12-03 3:04 ` Stephen Rust 2019-12-03 3:14 ` Ming Lei 2019-12-03 3:26 ` Stephen Rust 2019-12-03 3:50 ` Stephen Rust 2019-12-03 12:45 ` Ming Lei 2019-12-03 19:56 ` Stephen Rust 2019-12-04 1:05 ` Ming Lei 2019-12-04 17:23 ` Stephen Rust 2019-12-04 23:02 ` Ming Lei 2019-12-05 0:16 ` Bart Van Assche 2019-12-05 14:44 ` Stephen Rust 2019-12-05 2:28 ` Stephen Rust 2019-12-05 3:05 ` Ming Lei 2019-12-05 9:17 ` Sagi Grimberg [this message] 2019-12-05 14:36 ` Stephen Rust 2019-12-04 2:39 ` Ming Lei 2019-12-03 4:15 ` Ming Lei
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-RDMA Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \ firstname.lastname@example.org public-inbox-index linux-rdma Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma AGPL code for this site: git clone https://public-inbox.org/public-inbox.git