Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lijun Ou <oulijun@huawei.com>,
	"Wei Hu(Xavier)" <xavier.huwei@huawei.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Hulk Robot <hulkci@huawei.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Shaobo Xu <xushaobo2@huawei.com>,
	Shamir Rabinovitch <shamir.rabinovitch@oracle.com>,
	Xi Wang <wangxi11@huawei.com>, Tao Tian <tiantao6@huawei.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-rdma <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] RDMA/hns: Fix build error again
Date: Tue, 22 Oct 2019 13:50:00 -0400
Message-ID: <edc0090d294d23451cc174835fedf9f0c4cd825a.camel@redhat.com> (raw)
In-Reply-To: <CAK8P3a071AHaN0Jb9dX5c3syQZZPgaR9bX3V3nseDTsPvgDWGg@mail.gmail.com>


[-- Attachment #1: Type: text/plain, Size: 963 bytes --]

On Mon, 2019-10-21 at 23:51 +0200, Arnd Bergmann wrote:
> On Mon, Oct 21, 2019 at 11:09 PM Doug Ledford <dledford@redhat.com>
> wrote:
> > This fix looks reasonable, but since I can't test this at all, and
> > I'm
> > personally tired of trying and failing to fix this issue, I need to
> > ask
> > if you've tried all the permutations for this just to confirm it
> > works
> > in all valid cases?
> 
> I'm fairly sure I would have found them all by now: Since I sent this
> patch I built 4680 randconfig kernels, 293 of which had some HNS
> driver enabled.
> 
> I also like to think that I spent more time to think it through in
> theory.

I reviewed it pretty closely, and I couldn't find any way in which I
thought it would fail, I'm just being picky because I want this to be
the last fix ;-)

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 21:18 Arnd Bergmann
2019-10-21 21:08 ` Doug Ledford
2019-10-21 21:51   ` Arnd Bergmann
2019-10-22 17:50     ` Doug Ledford [this message]
2019-10-29 19:17 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edc0090d294d23451cc174835fedf9f0c4cd825a.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=arnd@arndb.de \
    --cc=hulkci@huawei.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=oulijun@huawei.com \
    --cc=shamir.rabinovitch@oracle.com \
    --cc=tiantao6@huawei.com \
    --cc=wangxi11@huawei.com \
    --cc=xavier.huwei@huawei.com \
    --cc=xushaobo2@huawei.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git