From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F1B3C433EF for ; Mon, 27 Sep 2021 16:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 726BE60FC0 for ; Mon, 27 Sep 2021 16:07:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235383AbhI0QIt (ORCPT ); Mon, 27 Sep 2021 12:08:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235377AbhI0QIs (ORCPT ); Mon, 27 Sep 2021 12:08:48 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E36BC061604 for ; Mon, 27 Sep 2021 09:07:10 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id y186so6886165pgd.0 for ; Mon, 27 Sep 2021 09:07:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=XTLDjg6tKpXO0n3tGXRecJAHRamIK6iZPCPoGCwwYoA=; b=n+WFlH5sDsKJBIqbhXBL0q86YID/cm95Hb4Pn7OgXho2+PQI0nSIdRbWypwC1UKBDc DLGkfkLNRgU/4Jp5PtjVk8wlNcPXFV82TekHIAWzakfClYLV1up37fwMMsaFds99YrVu hNhlWvvXJ7s5t7jexJWYFgrPnilemlVeEY6QOZlKBD8momja0/KMxsagYQWYBX3Swb0R IBff6ti5Yo9g23SYXpecR6u2VLeocqeAEBuEh7d2TS0npVBk3zwvJ6xEwnVe9dM1BC3A QwKM/wGB/13xUZ8eKf1kP0LtQtr2a4f5cOQEzBeZGmRFBfWO/kxwb9qc8cB5gj0PVpiy 36Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=XTLDjg6tKpXO0n3tGXRecJAHRamIK6iZPCPoGCwwYoA=; b=y4zb0ln4VDH98+jwkoQYvTpMMuWICAes8RrKlRS823VCDJOZlcH6a5dKFDudKbdxeC tL53Xj86SZhlAscNQJnFtt8E+47hlL/ZcEol2sP/xGkkXxwzAIf7eHXlEEVFosQdMcIc nFxdH3JQ6mFwOsH4uKlUrNQ8+wbuvDNXDUPqHYebmkIjsuJ3j4WsFuiZbnLZl/ttbJ3F KhNJw2QK/meapjE1vXoKM6n7XEWb6ULIzSuXvCxXs1ygAIOp3rZrofSkebPH8HZSn4n7 zwd6tx/ODCEgFJ9YQs4CGlCUntutSrF8bYJtiQR/rdZ5BeWHrq+GwHcP6kGh+DUrPW7v y25g== X-Gm-Message-State: AOAM533Q3K03t9hkHLS9udVcBG3lJCQbKDy4Rnb4GWbyHrR7SAqreLFq 2QQgLRHAKOqfcBc/NUFHWq95qw== X-Google-Smtp-Source: ABdhPJwR7BDUtOf/PI25/vpcHZm+mNUz7FflOv5PSidwcLqI4zYdDEmizFXZbBjNUgQkz/U1dIeC3A== X-Received: by 2002:aa7:94aa:0:b0:43e:2cf:d326 with SMTP id a10-20020aa794aa000000b0043e02cfd326mr447025pfl.62.1632758829714; Mon, 27 Sep 2021 09:07:09 -0700 (PDT) Received: from Shannons-MacBook-Pro.local ([50.53.47.17]) by smtp.gmail.com with ESMTPSA id 77sm17358967pfu.219.2021.09.27.09.07.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 09:07:09 -0700 (PDT) Subject: Re: [PATCH net-next v1 14/21] ionic: Move devlink registration to be last devlink command To: Leon Romanovsky , "David S . Miller" , Jakub Kicinski Cc: Leon Romanovsky , Alexandre Belloni , Andrew Lunn , Ariel Elior , Bin Luo , Claudiu Manoil , Coiby Xu , Derek Chickles , drivers@pensando.io, Felix Manlunas , Florian Fainelli , Geetha sowjanya , Greg Kroah-Hartman , GR-everest-linux-l2@marvell.com, GR-Linux-NIC-Dev@marvell.com, hariprasad , Ido Schimmel , Intel Corporation , intel-wired-lan@lists.osuosl.org, Ioana Ciornei , Jerin Jacob , Jesse Brandeburg , Jiri Pirko , Jonathan Lemon , Linu Cherian , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-rdma@vger.kernel.org, linux-staging@lists.linux.dev, Loic Poulain , Manish Chopra , M Chetan Kumar , Michael Chan , Michael Guralnik , netdev@vger.kernel.org, oss-drivers@corigine.com, Richard Cochran , Saeed Mahameed , Satanand Burla , Sergey Ryazanov , Simon Horman , Subbaraya Sundeep , Sunil Goutham , Taras Chornyi , Tariq Toukan , Tony Nguyen , UNGLinuxDriver@microchip.com, Vadym Kochan , Vivien Didelot , Vladimir Oltean References: From: Shannon Nelson Message-ID: Date: Mon, 27 Sep 2021 09:07:03 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On 9/25/21 4:22 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > This change prevents from users to access device before devlink is > fully configured. > > Signed-off-by: Leon Romanovsky Thanks for the work, Acked-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic_devlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c > index 93282394d332..2267da95640b 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c > @@ -82,7 +82,6 @@ int ionic_devlink_register(struct ionic *ionic) > struct devlink_port_attrs attrs = {}; > int err; > > - devlink_register(dl); > attrs.flavour = DEVLINK_PORT_FLAVOUR_PHYSICAL; > devlink_port_attrs_set(&ionic->dl_port, &attrs); > err = devlink_port_register(dl, &ionic->dl_port, 0); > @@ -93,6 +92,7 @@ int ionic_devlink_register(struct ionic *ionic) > } > > devlink_port_type_eth_set(&ionic->dl_port, ionic->lif->netdev); > + devlink_register(dl); > return 0; > } > > @@ -100,6 +100,6 @@ void ionic_devlink_unregister(struct ionic *ionic) > { > struct devlink *dl = priv_to_devlink(ionic); > > - devlink_port_unregister(&ionic->dl_port); > devlink_unregister(dl); > + devlink_port_unregister(&ionic->dl_port); > }