* [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices
@ 2019-11-22 10:06 Arun Kumar Neelakantam
0 siblings, 0 replies; 4+ messages in thread
From: Arun Kumar Neelakantam @ 2019-11-22 10:06 UTC (permalink / raw)
To: ohad, bjorn.andersson, clew, sricharan
Cc: linux-remoteproc, linux-kernel, Arun Kumar Neelakantam
Glink transport support signals to exchange state notification between
local and remote side clients. Adding support to send/receive the signal
command and notify the clients through callback and POLL notification.
Changes since v3:
- Correct the TICOMGET case handling as per new rpmsg_get_signals prototype
- Update the rpmsg_get_signals function header
Changes since v2:
- Modify the rpmsg_get_signals function prototype
Changes since v1:
- Split the patches as per functional areas like core, char, glink
- Add set, clear mask for TIOCMSET
- Merge the char signal callback and POLLPRI patches
Arun Kumar Neelakantam (4):
rpmsg: core: Add signal API support
rpmsg: glink: Add support to handle signals command
rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
rpmsg: char: Add signal callback and POLLPRI support
drivers/rpmsg/qcom_glink_native.c | 126 ++++++++++++++++++++++++++++++++++++++
drivers/rpmsg/rpmsg_char.c | 74 +++++++++++++++++++++-
drivers/rpmsg/rpmsg_core.c | 41 +++++++++++++
drivers/rpmsg/rpmsg_internal.h | 5 ++
include/linux/rpmsg.h | 26 ++++++++
5 files changed, 269 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices
2020-05-13 5:11 Arun Kumar Neelakantam
@ 2020-05-19 22:49 ` Mathieu Poirier
0 siblings, 0 replies; 4+ messages in thread
From: Mathieu Poirier @ 2020-05-19 22:49 UTC (permalink / raw)
To: Arun Kumar Neelakantam
Cc: ohad, bjorn.andersson, clew, sricharan, linux-remoteproc, linux-kernel
On Wed, May 13, 2020 at 10:41:07AM +0530, Arun Kumar Neelakantam wrote:
> Glink transport support signals to exchange state notification between
> local and remote side clients. Adding support to send/receive the signal
> command and notify the clients through callback and POLL notification.
From a general point of view it is hard to have an understanding of what this
patchset does and if it is the right solution due to a lack of context.
The cover letter and changelogs are sparse to a point where a
reviewer not familiar with the QC/Glink implementation can't offer much more
than syntactic comments.
Thanks,
Mathieu
>
> Changes since v3:
> - Correct the TICOMGET case handling as per new rpmsg_get_signals prototype
> - Update the rpmsg_get_signals function header
>
> Changes since v2:
> - Modify the rpmsg_get_signals function prototype
>
> Changes since v1:
> - Split the patches as per functional areas like core, char, glink
> - Add set, clear mask for TIOCMSET
> - Merge the char signal callback and POLLPRI patches
>
> Arun Kumar Neelakantam (4):
> rpmsg: core: Add signal API support
> rpmsg: glink: Add support to handle signals command
> rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
> rpmsg: char: Add signal callback and POLLPRI support
>
> drivers/rpmsg/qcom_glink_native.c | 126 ++++++++++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_char.c | 75 ++++++++++++++++++++++-
> drivers/rpmsg/rpmsg_core.c | 41 +++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 5 ++
> include/linux/rpmsg.h | 26 ++++++++
> 5 files changed, 270 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices
@ 2020-05-13 5:11 Arun Kumar Neelakantam
2020-05-19 22:49 ` Mathieu Poirier
0 siblings, 1 reply; 4+ messages in thread
From: Arun Kumar Neelakantam @ 2020-05-13 5:11 UTC (permalink / raw)
To: ohad, bjorn.andersson, clew, sricharan
Cc: linux-remoteproc, linux-kernel, Arun Kumar Neelakantam
Glink transport support signals to exchange state notification between
local and remote side clients. Adding support to send/receive the signal
command and notify the clients through callback and POLL notification.
Changes since v3:
- Correct the TICOMGET case handling as per new rpmsg_get_signals prototype
- Update the rpmsg_get_signals function header
Changes since v2:
- Modify the rpmsg_get_signals function prototype
Changes since v1:
- Split the patches as per functional areas like core, char, glink
- Add set, clear mask for TIOCMSET
- Merge the char signal callback and POLLPRI patches
Arun Kumar Neelakantam (4):
rpmsg: core: Add signal API support
rpmsg: glink: Add support to handle signals command
rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
rpmsg: char: Add signal callback and POLLPRI support
drivers/rpmsg/qcom_glink_native.c | 126 ++++++++++++++++++++++++++++++++++++++
drivers/rpmsg/rpmsg_char.c | 75 ++++++++++++++++++++++-
drivers/rpmsg/rpmsg_core.c | 41 +++++++++++++
drivers/rpmsg/rpmsg_internal.h | 5 ++
include/linux/rpmsg.h | 26 ++++++++
5 files changed, 270 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices
@ 2019-11-22 10:06 Arun Kumar Neelakantam
0 siblings, 0 replies; 4+ messages in thread
From: Arun Kumar Neelakantam @ 2019-11-22 10:06 UTC (permalink / raw)
To: ohad, bjorn.andersson, clew, sricharan
Cc: linux-remoteproc, linux-kernel, Arun Kumar Neelakantam
Glink transport support signals to exchange state notification between
local and remote side clients. Adding support to send/receive the signal
command and notify the clients through callback and POLL notification.
Changes since v3:
- Correct the TICOMGET case handling as per new rpmsg_get_signals prototype
- Update the rpmsg_get_signals function header
Changes since v2:
- Modify the rpmsg_get_signals function prototype
Changes since v1:
- Split the patches as per functional areas like core, char, glink
- Add set, clear mask for TIOCMSET
- Merge the char signal callback and POLLPRI patches
Arun Kumar Neelakantam (4):
rpmsg: core: Add signal API support
rpmsg: glink: Add support to handle signals command
rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
rpmsg: char: Add signal callback and POLLPRI support
drivers/rpmsg/qcom_glink_native.c | 126 ++++++++++++++++++++++++++++++++++++++
drivers/rpmsg/rpmsg_char.c | 74 +++++++++++++++++++++-
drivers/rpmsg/rpmsg_core.c | 41 +++++++++++++
drivers/rpmsg/rpmsg_internal.h | 5 ++
include/linux/rpmsg.h | 26 ++++++++
5 files changed, 269 insertions(+), 3 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-19 22:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-22 10:06 [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices Arun Kumar Neelakantam
2019-11-22 10:06 Arun Kumar Neelakantam
2020-05-13 5:11 Arun Kumar Neelakantam
2020-05-19 22:49 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).