linux-remoteproc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] remoteproc: Add missing '\n' in log messages
@ 2020-04-11 16:07 Christophe JAILLET
  2020-04-11 16:07 ` Christophe JAILLET
  2020-04-23  6:40 ` patchwork-bot+linux-remoteproc
  0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2020-04-11 16:07 UTC (permalink / raw)
  To: ohad, bjorn.andersson, mathieu.poirier, NShubin
  Cc: linux-remoteproc, linux-kernel, kernel-janitors, Christophe JAILLET

Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.

Fixes: 791c13b709dd ("remoteproc: Fix NULL pointer dereference in rproc_virtio_notify")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/remoteproc/remoteproc_virtio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
index b48b78e00284..0d4cc0fc5858 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -337,8 +337,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
 
 	if (rproc->ops->kick == NULL) {
 		ret = -EINVAL;
-		dev_err(dev, ".kick method not defined for %s",
-				rproc->name);
+		dev_err(dev, ".kick method not defined for %s\n", rproc->name);
 		goto out;
 	}
 
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] remoteproc: Add missing '\n' in log messages
  2020-04-11 16:07 [PATCH] remoteproc: Add missing '\n' in log messages Christophe JAILLET
@ 2020-04-11 16:07 ` Christophe JAILLET
  2020-04-23  6:40 ` patchwork-bot+linux-remoteproc
  1 sibling, 0 replies; 3+ messages in thread
From: Christophe JAILLET @ 2020-04-11 16:07 UTC (permalink / raw)
  To: ohad, bjorn.andersson, mathieu.poirier, NShubin
  Cc: linux-remoteproc, linux-kernel, kernel-janitors, Christophe JAILLET

Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.

Fixes: 791c13b709dd ("remoteproc: Fix NULL pointer dereference in rproc_virtio_notify")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 drivers/remoteproc/remoteproc_virtio.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
index b48b78e00284..0d4cc0fc5858 100644
--- a/drivers/remoteproc/remoteproc_virtio.c
+++ b/drivers/remoteproc/remoteproc_virtio.c
@@ -337,8 +337,7 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
 
 	if (rproc->ops->kick == NULL) {
 		ret = -EINVAL;
-		dev_err(dev, ".kick method not defined for %s",
-				rproc->name);
+		dev_err(dev, ".kick method not defined for %s\n", rproc->name);
 		goto out;
 	}
 
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] remoteproc: Add missing '\n' in log messages
  2020-04-11 16:07 [PATCH] remoteproc: Add missing '\n' in log messages Christophe JAILLET
  2020-04-11 16:07 ` Christophe JAILLET
@ 2020-04-23  6:40 ` patchwork-bot+linux-remoteproc
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2020-04-23  6:40 UTC (permalink / raw)
  To: Christophe JAILLET; +Cc: linux-remoteproc

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next).

On Sat, 11 Apr 2020 18:07:50 +0200 you wrote:
> Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
> 
> Fixes: 791c13b709dd ("remoteproc: Fix NULL pointer dereference in rproc_virtio_notify")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/remoteproc/remoteproc_virtio.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)


Here is a summary with links:
  - remoteproc: Add missing '\n' in log messages
    https://git.kernel.org/andersson/remoteproc/c/2fb75ceaf71a4a198fc67b984aa95527c993fa1a

You are awesome, thank you!

-- 
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/pwbot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-04-23  6:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-11 16:07 [PATCH] remoteproc: Add missing '\n' in log messages Christophe JAILLET
2020-04-11 16:07 ` Christophe JAILLET
2020-04-23  6:40 ` patchwork-bot+linux-remoteproc

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).