From: Deepak Kumar Singh <deesin@codeaurora.org>
To: bjorn.andersson@linaro.org, clew@codeaurora.org,
mathieu.poirier@linaro.org
Cc: Deepak Kumar Singh <deesin@codeaurora.org>,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
Andy Gross <agross@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT),
linux-remoteproc@vger.kernel.org (open list:REMOTE PROCESSOR
MESSAGING (RPMSG) SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH V7 1/4] rpmsg: glink: Use complete_all for open states
Date: Wed, 24 Jun 2020 22:15:18 +0530 [thread overview]
Message-ID: <1593017121-7953-2-git-send-email-deesin@codeaurora.org> (raw)
In-Reply-To: <1593017121-7953-1-git-send-email-deesin@codeaurora.org>
From: Chris Lew <clew@codeaurora.org>
The open_req and open_ack completion variables are the state variables
to represet a remote channel as open. Use complete_all so there are no
races with waiters and using completion_done.
Signed-off-by: Chris Lew <clew@codeaurora.org>
Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
Signed-off-by: Arun Kumar Neelakantam <aneela@codeaurora.org>
---
drivers/rpmsg/qcom_glink_native.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c
index 1995f5b..d5114ab 100644
--- a/drivers/rpmsg/qcom_glink_native.c
+++ b/drivers/rpmsg/qcom_glink_native.c
@@ -970,7 +970,7 @@ static int qcom_glink_rx_open_ack(struct qcom_glink *glink, unsigned int lcid)
return -EINVAL;
}
- complete(&channel->open_ack);
+ complete_all(&channel->open_ack);
return 0;
}
@@ -1178,7 +1178,7 @@ static int qcom_glink_announce_create(struct rpmsg_device *rpdev)
__be32 *val = defaults;
int size;
- if (glink->intentless)
+ if (glink->intentless || !completion_done(&channel->open_ack))
return 0;
prop = of_find_property(np, "qcom,intents", NULL);
@@ -1413,7 +1413,7 @@ static int qcom_glink_rx_open(struct qcom_glink *glink, unsigned int rcid,
channel->rcid = ret;
spin_unlock_irqrestore(&glink->idr_lock, flags);
- complete(&channel->open_req);
+ complete_all(&channel->open_req);
if (create_device) {
rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next parent reply other threads:[~2020-06-24 16:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1593017121-7953-1-git-send-email-deesin@codeaurora.org>
2020-06-24 16:45 ` Deepak Kumar Singh [this message]
2020-09-15 5:00 ` [PATCH V7 1/4] rpmsg: glink: Use complete_all for open states patchwork-bot+linux-remoteproc
2020-06-24 16:45 ` [PATCH V7 2/4] rpmsg: Guard against null endpoint ops in destroy Deepak Kumar Singh
2020-08-07 7:59 ` Greg KH
2020-08-08 0:33 ` Chris Lew
2020-08-08 5:55 ` Greg KH
2020-06-24 16:45 ` [PATCH V7 3/4] rpmsg: glink: Add support for rpmsg glink chrdev Deepak Kumar Singh
2020-06-24 16:45 ` [PATCH V7 4/4] rpmsg: glink: Expose rpmsg name attr for glink Deepak Kumar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593017121-7953-2-git-send-email-deesin@codeaurora.org \
--to=deesin@codeaurora.org \
--cc=agross@kernel.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).