Linux-remoteproc Archive on
 help / color / Atom feed
* [PATCH] remoteproc: core: Add coredump ops to remoteproc
@ 2020-07-31 22:17 Siddharth Gupta
  0 siblings, 0 replies; only message in thread
From: Siddharth Gupta @ 2020-07-31 22:17 UTC (permalink / raw)
  To: bjorn.andersson, ohad; +Cc: Siddharth Gupta, linux-remoteproc, linux-kernel

Each remoteproc might have different requirements for coredumps and might
want to choose the type of dumps it wants to collect. This change allows
remoteproc drivers to specify their own custom dump function to be executed
in place of rproc_coredump. If the coredump op is not specified by the
remoteproc driver it will be set to rproc_coredump by default.

Signed-off-by: Siddharth Gupta <>
 drivers/remoteproc/remoteproc_core.c | 6 +++++-
 include/linux/remoteproc.h           | 2 ++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 277d3bf..8ea61b0 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1681,7 +1681,8 @@ int rproc_trigger_recovery(struct rproc *rproc)
 		goto unlock_mutex;
 	/* generate coredump */
-	rproc_coredump(rproc);
+	if (rproc->ops->coredump)
+		rproc->ops->coredump(rproc);
 	/* load firmware */
 	ret = request_firmware(&firmware_p, rproc->firmware, dev);
@@ -2098,6 +2099,9 @@ static int rproc_alloc_ops(struct rproc *rproc, const struct rproc_ops *ops)
 	if (!rproc->ops)
 		return -ENOMEM;
+	if (rproc->ops->coredump)
+		rproc->ops->coredump = rproc_coredump;
 	if (rproc->ops->load)
 		return 0;
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index 0e8d2ff..d22c33d 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -374,6 +374,7 @@ enum rsc_handling_status {
  * @get_boot_addr:	get boot address to entry point specified in firmware
  * @panic:	optional callback to react to system panic, core will delay
  *		panic at least the returned number of milliseconds
+ * @coredump:	do coredump for the specified remoteproc
 struct rproc_ops {
 	int (*prepare)(struct rproc *rproc);
@@ -392,6 +393,7 @@ struct rproc_ops {
 	int (*sanity_check)(struct rproc *rproc, const struct firmware *fw);
 	u64 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw);
 	unsigned long (*panic)(struct rproc *rproc);
+	void (*coredump)(struct rproc *rproc);
Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-31 22:17 [PATCH] remoteproc: core: Add coredump ops to remoteproc Siddharth Gupta

Linux-remoteproc Archive on

Archives are clonable:
	git clone --mirror linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ \
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone