Linux-remoteproc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio()
@ 2021-03-19  9:41 'w00385741
  2021-04-14  2:20 ` patchwork-bot+linux-remoteproc
  0 siblings, 1 reply; 2+ messages in thread
From: 'w00385741 @ 2021-03-19  9:41 UTC (permalink / raw)
  To: weiyongjun1, Andy Gross, Bjorn Andersson, Ohad Ben-Cohen,
	Mathieu Poirier, Philipp Zabel, Govind Singh
  Cc: linux-arm-msm, linux-remoteproc, kernel-janitors, Hulk Robot

From: Wei Yongjun <weiyongjun1@huawei.com>

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/remoteproc/qcom_q6v5_wcss.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
index 71ec1a451e35..6f7d940d4431 100644
--- a/drivers/remoteproc/qcom_q6v5_wcss.c
+++ b/drivers/remoteproc/qcom_q6v5_wcss.c
@@ -829,8 +829,8 @@ static int q6v5_wcss_init_mmio(struct q6v5_wcss *wcss,
 	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "qdsp6");
 	wcss->reg_base = devm_ioremap(&pdev->dev, res->start,
 				      resource_size(res));
-	if (IS_ERR(wcss->reg_base))
-		return PTR_ERR(wcss->reg_base);
+	if (!wcss->reg_base)
+		return -ENOMEM;
 
 	if (wcss->version == WCSS_IPQ8074) {
 		res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rmb");


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio()
  2021-03-19  9:41 [PATCH -next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio() 'w00385741
@ 2021-04-14  2:20 ` patchwork-bot+linux-remoteproc
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2021-04-14  2:20 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: linux-remoteproc

Hello:

This patch was applied to andersson/remoteproc.git (refs/heads/for-next):

On Fri, 19 Mar 2021 09:41:00 +0000 you wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> In case of error, the function devm_ioremap() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should
> be replaced with NULL test.
> 
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for QCS404")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> 
> [...]

Here is the summary with links:
  - [-next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio()
    https://git.kernel.org/andersson/remoteproc/c/859fd2418b4b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19  9:41 [PATCH -next] remoteproc: qcom: wcss: Fix return value check in q6v5_wcss_init_mmio() 'w00385741
2021-04-14  2:20 ` patchwork-bot+linux-remoteproc

Linux-remoteproc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \
		linux-remoteproc@vger.kernel.org
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git