* [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints
@ 2023-03-09 8:24 Krzysztof Kozlowski
2023-03-09 8:24 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: " Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-09 8:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
Bhupesh Sharma, Neil Armstrong, linux-arm-msm, linux-remoteproc,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Qualcomm PAS devices expect exactly one memory region, not many. Also,
the memory-region is now defined in device specific binding, not in
qcom,pas-common.yaml, thus also require it in the same place.
Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Following dtbs_check errors are expected (not related):
- qcom,halt-regs:0: [142] is too short
- clocks: [[24, 222], [24, 223], [24, 157], [16], [24, 229], [24, 224], [24, 225], [27, 2], [27, 8]] is too short
- 'px-supply' is a required property
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 1 +
.../devicetree/bindings/remoteproc/qcom,pas-common.yaml | 1 -
.../devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 3 ++-
10 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 828dfebaef6a..69ba955432bf 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -50,6 +50,7 @@ properties:
required:
- compatible
+ - memory-region
unevaluatedProperties: false
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
index 171ef85de193..63a82e7a8bf8 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml
@@ -82,7 +82,6 @@ required:
- clock-names
- interrupts
- interrupt-names
- - memory-region
- qcom,smem-states
- qcom,smem-state-names
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
index 5efa0e5c0439..eb868a7ff4cd 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml
@@ -42,7 +42,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -52,6 +52,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
index 5cefd2c58593..689d5d535331 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml
@@ -51,7 +51,7 @@ properties:
- const: mss
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
qcom,qmp:
@@ -67,6 +67,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml
index c1f8dd8d0e4c..4744a37b2b5d 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml
@@ -38,7 +38,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -48,6 +48,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
index f6fbc531dc28..96d53baf6e00 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
@@ -38,7 +38,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -48,6 +48,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
index c66e298462c7..5d463272165f 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml
@@ -46,7 +46,7 @@ properties:
- const: mss
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
qcom,qmp:
@@ -62,6 +62,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
index fee02fa800b5..f7e40fb166da 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml
@@ -36,7 +36,7 @@ properties:
description: Reference to the AOSS side-channel message RAM.
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
smd-edge: false
@@ -48,6 +48,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
index 2c085ac2c3fb..238c6e5e67c5 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
@@ -40,7 +40,7 @@ properties:
description: Reference to the AOSS side-channel message RAM.
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
smd-edge: false
@@ -52,6 +52,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
index af24f9a3cdf1..4394dfd2d8e6 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml
@@ -43,7 +43,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -53,6 +53,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: correct memory-region constraints
2023-03-09 8:24 [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Krzysztof Kozlowski
@ 2023-03-09 8:24 ` Krzysztof Kozlowski
2023-03-09 8:27 ` Krzysztof Kozlowski
2023-03-16 23:02 ` Rob Herring
2023-03-09 8:24 ` [PATCH 3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region Krzysztof Kozlowski
2023-03-16 23:01 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Rob Herring
2 siblings, 2 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-09 8:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
Bhupesh Sharma, Neil Armstrong, linux-arm-msm, linux-remoteproc,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Qualcomm PAS devices expect exactly one memory region, not many. Also,
the memory-region is now defined in device specific binding, not in
qcom,pas-common.yaml, thus also require it in the same place.
Fixes: 838c558bb8bc ("dt-bindings: remoteproc: qcom: Add sm6115 pas yaml file")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
index f5d1fa9f45f1..1ac5b99b2fad 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml
@@ -32,7 +32,7 @@ properties:
- const: xo
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
smd-edge: false
@@ -44,6 +44,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region
2023-03-09 8:24 [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Krzysztof Kozlowski
2023-03-09 8:24 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: " Krzysztof Kozlowski
@ 2023-03-09 8:24 ` Krzysztof Kozlowski
2023-03-16 23:02 ` Rob Herring
2023-03-16 23:01 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Rob Herring
2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-09 8:24 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Mathieu Poirier,
Rob Herring, Krzysztof Kozlowski, Manivannan Sadhasivam,
Bhupesh Sharma, Neil Armstrong, linux-arm-msm, linux-remoteproc,
devicetree, linux-kernel
Cc: Krzysztof Kozlowski
The memory-region is defined in device specific binding, not in
qcom,pas-common.yaml, thus also require it in the same place.
Fixes: 084258d60712 ("dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
index fe216aa531ed..58120829fb06 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
@@ -53,6 +53,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: correct memory-region constraints
2023-03-09 8:24 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: " Krzysztof Kozlowski
@ 2023-03-09 8:27 ` Krzysztof Kozlowski
2023-03-16 23:02 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-03-09 8:27 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: Andy Gross, Mathieu Poirier, linux-kernel, Konrad Dybcio,
Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Neil Armstrong, Manivannan Sadhasivam, linux-arm-msm,
linux-remoteproc, devicetree
On 09/03/2023 09:24, Krzysztof Kozlowski wrote:
> Qualcomm PAS devices expect exactly one memory region, not many. Also,
> the memory-region is now defined in device specific binding, not in
> qcom,pas-common.yaml, thus also require it in the same place.
>
> Fixes: 838c558bb8bc ("dt-bindings: remoteproc: qcom: Add sm6115 pas yaml file")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I think the sm6115 was not yet merged, thus maybe this patch is not
needed. If it wasn't merged, please squash it with original submission
and send new viersion.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints
2023-03-09 8:24 [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Krzysztof Kozlowski
2023-03-09 8:24 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: " Krzysztof Kozlowski
2023-03-09 8:24 ` [PATCH 3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region Krzysztof Kozlowski
@ 2023-03-16 23:01 ` Rob Herring
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-03-16 23:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Neil Armstrong, Konrad Dybcio, Krzysztof Kozlowski,
linux-arm-msm, Mathieu Poirier, linux-remoteproc,
Bjorn Andersson, devicetree, Andy Gross, Manivannan Sadhasivam,
Bhupesh Sharma, linux-kernel, Rob Herring
On Thu, 09 Mar 2023 09:24:44 +0100, Krzysztof Kozlowski wrote:
> Qualcomm PAS devices expect exactly one memory region, not many. Also,
> the memory-region is now defined in device specific binding, not in
> qcom,pas-common.yaml, thus also require it in the same place.
>
> Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> Following dtbs_check errors are expected (not related):
> - qcom,halt-regs:0: [142] is too short
> - clocks: [[24, 222], [24, 223], [24, 157], [16], [24, 229], [24, 224], [24, 225], [27, 2], [27, 8]] is too short
> - 'px-supply' is a required property
> ---
> Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 1 +
> .../devicetree/bindings/remoteproc/qcom,pas-common.yaml | 1 -
> .../devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml | 3 ++-
> .../devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 3 ++-
> 10 files changed, 17 insertions(+), 9 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: correct memory-region constraints
2023-03-09 8:24 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: " Krzysztof Kozlowski
2023-03-09 8:27 ` Krzysztof Kozlowski
@ 2023-03-16 23:02 ` Rob Herring
1 sibling, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-03-16 23:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Neil Armstrong, linux-remoteproc, devicetree,
Bjorn Andersson, Bhupesh Sharma, linux-arm-msm, Rob Herring,
Krzysztof Kozlowski, Manivannan Sadhasivam, Konrad Dybcio,
linux-kernel, Mathieu Poirier
On Thu, 09 Mar 2023 09:24:45 +0100, Krzysztof Kozlowski wrote:
> Qualcomm PAS devices expect exactly one memory region, not many. Also,
> the memory-region is now defined in device specific binding, not in
> qcom,pas-common.yaml, thus also require it in the same place.
>
> Fixes: 838c558bb8bc ("dt-bindings: remoteproc: qcom: Add sm6115 pas yaml file")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region
2023-03-09 8:24 ` [PATCH 3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region Krzysztof Kozlowski
@ 2023-03-16 23:02 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2023-03-16 23:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Konrad Dybcio, Mathieu Poirier, Rob Herring, devicetree,
Bjorn Andersson, Andy Gross, Krzysztof Kozlowski, Neil Armstrong,
linux-arm-msm, linux-kernel, Bhupesh Sharma, linux-remoteproc,
Manivannan Sadhasivam
On Thu, 09 Mar 2023 09:24:46 +0100, Krzysztof Kozlowski wrote:
> The memory-region is defined in device specific binding, not in
> qcom,pas-common.yaml, thus also require it in the same place.
>
> Fixes: 084258d60712 ("dt-bindings: remoteproc: qcom: adsp: document sm8550 adsp, cdsp & mpss compatible")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-03-16 23:02 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-09 8:24 [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Krzysztof Kozlowski
2023-03-09 8:24 ` [PATCH 2/3] dt-bindings: remoteproc: qcom,sm6115-pas: " Krzysztof Kozlowski
2023-03-09 8:27 ` Krzysztof Kozlowski
2023-03-16 23:02 ` Rob Herring
2023-03-09 8:24 ` [PATCH 3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region Krzysztof Kozlowski
2023-03-16 23:02 ` Rob Herring
2023-03-16 23:01 ` [PATCH 1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).