From: Sibi Sankar <sibis@codeaurora.org>
To: Rakesh Pillai <pillair@codeaurora.org>
Cc: agross@kernel.org, bjorn.andersson@linaro.org, ohad@wizery.com,
mathieu.poirier@linaro.org, robh+dt@kernel.org,
p.zabel@pengutronix.de, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support
Date: Mon, 15 Mar 2021 19:08:45 +0530 [thread overview]
Message-ID: <1cb4a183234f00c0077b5a95c475a4cc@codeaurora.org> (raw)
In-Reply-To: <1615361290-19238-2-git-send-email-pillair@codeaurora.org>
On 2021-03-10 12:58, Rakesh Pillai wrote:
> Add WPSS PIL loading support for SC7280 SoCs.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> .../bindings/remoteproc/qcom,hexagon-v56.txt | 35
> ++++++++++++----------
> 1 file changed, 20 insertions(+), 15 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.txt
> b/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.txt
> index 1337a3d..edad5e8 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,hexagon-v56.txt
> @@ -9,6 +9,7 @@ on the Qualcomm Technology Inc. Hexagon v56 core.
> Definition: must be one of:
> "qcom,qcs404-cdsp-pil",
> "qcom,sdm845-adsp-pil"
> + "qcom,sc7280-wpss-pil"
>
> - reg:
> Usage: required
> @@ -24,7 +25,13 @@ on the Qualcomm Technology Inc. Hexagon v56 core.
> - interrupt-names:
> Usage: required
> Value type: <stringlist>
> - Definition: must be "wdog", "fatal", "ready", "handover", "stop-ack"
> + Definition: The interrupts needed depends on the compatible string
> + qcom,sdm845-adsp-pil:
> + qcom,qcs404-cdsp-pil:
> + must be "wdog", "fatal", "ready", "handover", "stop-ack"
> + qcom,sc7280-wpss-pil:
> + must be "wdog", "fatal", "ready", "handover", "stop-ack"
> + "shutdown-ack"
>
> - clocks:
> Usage: required
> @@ -35,19 +42,17 @@ on the Qualcomm Technology Inc. Hexagon v56 core.
> - clock-names:
> Usage: required for SDM845 ADSP
> Value type: <stringlist>
> - Definition: List of clock input name strings sorted in the same
> - order as the clocks property. Definition must have
> - "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
> - "lpass_ahbm_aon_cbcr", "qdsp6ss_xo", "qdsp6ss_sleep"
> - and "qdsp6ss_core".
> -
> -- clock-names:
> - Usage: required for QCS404 CDSP
> - Value type: <stringlist>
> - Definition: List of clock input name strings sorted in the same
> - order as the clocks property. Definition must have
> - "xo", "sway", "tbu", "bimc", "ahb_aon", "q6ss_slave",
> - "q6ss_master", "q6_axim".
> + Definition: The clocks needed depends on the compatible string
> + qcom,sdm845-adsp-pil:
> + must be "xo", "sway_cbcr", "lpass_ahbs_aon_cbcr",
> + "lpass_ahbm_aon_cbcr", "qdsp6ss_xo", "qdsp6ss_sleep",
> + "qdsp6ss_core"
> + qcom,qcs404-cdsp-pil:
> + must be "xo", "sway", "tbu", "bimc", "ahb_aon", "q6ss_slave",
> + "q6ss_master", "q6_axim"
> + qcom,sc7280-wpss-pil:
> + must be "gcc_wpss_ahb_bdg_mst_clk", "gcc_wpss_ahb_clk",
> + "gcc_wpss_rscp_clk"
>
> - power-domains:
IIRC wpss requires both cx and mx. So you'll
need to add driver code to support multiple
power-domains.
> Usage: required
> @@ -65,7 +70,7 @@ on the Qualcomm Technology Inc. Hexagon v56 core.
> Definition: must be "pdc_sync" and "cc_lpass"
>
> - reset-names:
> - Usage: required for QCS404 CDSP
> + Usage: required for QCS404 CDSP, SC7280 WPSS
> Value type: <stringlist>
> Definition: must be "restart"
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-03-15 13:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 7:28 [PATCH 0/2] Add support for sc7280 WPSS PIL loading Rakesh Pillai
2021-03-10 7:28 ` [PATCH 1/2] dt-bindings: remoteproc: qcom: Add SC7280 WPSS support Rakesh Pillai
2021-03-10 16:47 ` Bjorn Andersson
2021-03-15 13:38 ` Sibi Sankar [this message]
2021-03-16 22:33 ` Rob Herring
2021-07-22 22:16 ` Stephen Boyd
2021-03-10 7:28 ` [PATCH 2/2] remoteproc: qcom: q6v5_wpss: Add support for sc7280 WPSS Rakesh Pillai
2021-03-10 16:44 ` Bjorn Andersson
2021-03-15 12:08 ` Rakesh Pillai
2021-10-04 15:29 ` Bjorn Andersson
2021-10-28 7:43 ` pillair
2021-03-15 13:49 ` Sibi Sankar
2021-07-22 22:12 ` [PATCH 0/2] Add support for sc7280 WPSS PIL loading Stephen Boyd
2021-08-10 18:04 ` Rakesh Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1cb4a183234f00c0077b5a95c475a4cc@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=p.zabel@pengutronix.de \
--cc=pillair@codeaurora.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).