From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Anup Patel <anup@brainfault.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig
Date: Wed, 4 Oct 2017 19:44:27 -0700 [thread overview]
Message-ID: <20171005024427.GU1165@minitux> (raw)
In-Reply-To: <1506917900-12289-1-git-send-email-anup@brainfault.org>
On Sun 01 Oct 21:18 PDT 2017, Anup Patel wrote:
> Currently, RPMSG_VIRTIO can only be enabled if some other kconfig
> option selects it. This does not allow it to be enabled for
> virtualized systems where Virtio RPMSG is available over Virtio
> MMIO or PCI transport.
>
> This patch updates RPMSG_VIRTIO kconfig option so that we can
> enable the VirtIO RPMSG driver via menuconfig or defconfig.
>
> Signed-off-by: Anup Patel <anup@brainfault.org>
> ---
This part looks good (and really I think this is the right thing to do).
But turning RPMSG_VIRTIO into a user selectable item makes it invalid to
"select RPMSG_VIRTIO" from drivers/remoteproc/Kconfig.
Can you please as part of this change remove those selects and as a
separate patch add CONFIG_RPMSG_VIRTIO=m to
arch/arm/configs/multi_v7_defconfig?
Thanks,
Bjorn
>
> Changes since v1:
> - Add depends on HAS_DMA to avoid build failures on
> archs (such as um) with NO_DMA=y. For most archs,
> HAS_DMA=y so having depends on HAS_DMA is fine.
>
> drivers/rpmsg/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/Kconfig b/drivers/rpmsg/Kconfig
> index 0fe6eac..65a9f6b 100644
> --- a/drivers/rpmsg/Kconfig
> +++ b/drivers/rpmsg/Kconfig
> @@ -47,7 +47,8 @@ config RPMSG_QCOM_SMD
> platforms.
>
> config RPMSG_VIRTIO
> - tristate
> + tristate "Virtio RPMSG bus driver"
> + depends on HAS_DMA
> select RPMSG
> select VIRTIO
>
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-10-05 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-02 4:18 [PATCH v2] rpmsg: Allow RPMSG_VIRTIO to be enabled via menuconfig or defconfig Anup Patel
2017-10-05 2:44 ` Bjorn Andersson [this message]
2017-10-05 4:00 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171005024427.GU1165@minitux \
--to=bjorn.andersson@linaro.org \
--cc=anup@brainfault.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).