From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Clement Leger <cleger@kalray.eu>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
linux-remoteproc <linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH] remoteproc: recopy parent dma_pfn_offset for vdev
Date: Sat, 29 Jun 2019 11:59:26 -0700 [thread overview]
Message-ID: <20190629185926.GD23094@builder> (raw)
In-Reply-To: <20190612095521.4703-1-cleger@kalray.eu>
On Wed 12 Jun 02:55 PDT 2019, Clement Leger wrote:
> When preparing the subdevice for the vdev, also copy dma_pfn_offset
> since this is used for sub device dma allocations. Without that, there
> is incoherency between the parent dma settings and the childs one,
> potentially leading to dma_alloc_coherent failure (due to phys_to_dma
> using dma_pfn_offset for translation).
Hi Clement,
This looks reasonable, but I can't merge it without your Signed-off-by.
Can you please resubmit the change, with the Fixes: and Loic's ack?
Regards,
Bjorn
> ---
> drivers/remoteproc/remoteproc_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 263e9c9614a8..3b56ca043231 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -520,6 +520,7 @@ static int rproc_handle_vdev(struct rproc *rproc, struct fw_rsc_vdev *rsc,
> /* Initialise vdev subdevice */
> snprintf(name, sizeof(name), "vdev%dbuffer", rvdev->index);
> rvdev->dev.parent = rproc->dev.parent;
> + rvdev->dev.dma_pfn_offset = rproc->dev.parent->dma_pfn_offset;
> rvdev->dev.release = rproc_rvdev_release;
> dev_set_name(&rvdev->dev, "%s#%s", dev_name(rvdev->dev.parent), name);
> dev_set_drvdata(&rvdev->dev, rvdev);
> --
> 2.15.0.276.g89ea799
>
next prev parent reply other threads:[~2019-06-29 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 9:55 [PATCH] remoteproc: recopy parent dma_pfn_offset for vdev Clement Leger
2019-06-17 10:10 ` Loic PALLARDY
2019-06-29 18:59 ` Bjorn Andersson [this message]
2019-07-01 7:02 ` [PATCH v2] remoteproc: copy " Clement Leger
2019-07-02 6:27 ` Bjorn Andersson
2019-07-02 13:22 ` Christoph Hellwig
2019-07-02 15:36 ` Loic PALLARDY
2019-07-08 18:45 ` Christoph Hellwig
2019-07-19 6:32 ` Christoph Hellwig
2019-07-22 8:41 ` Loic PALLARDY
2019-07-22 9:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629185926.GD23094@builder \
--to=bjorn.andersson@linaro.org \
--cc=cleger@kalray.eu \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).