* [PATCH v2 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs
2020-04-30 18:00 [PATCH v2 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Bjorn Andersson
@ 2020-04-30 18:00 ` Bjorn Andersson
2020-05-14 13:45 ` Vinod Koul
2020-05-12 15:37 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Rob Herring
2020-05-14 13:45 ` Vinod Koul
2 siblings, 1 reply; 5+ messages in thread
From: Bjorn Andersson @ 2020-04-30 18:00 UTC (permalink / raw)
To: Bjorn Andersson, Ohad Ben-Cohen, Rob Herring
Cc: linux-arm-msm, linux-remoteproc, devicetree, linux-kernel, Sibi Sankar
Add audio, compute and sensor DSP compatibles to the Qualcomm PAS
binding and driver.
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
Changes since v1:
- Renamed adsp power-domains lcd and lmx
drivers/remoteproc/qcom_q6v5_pas.c | 62 ++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index fc6658b523b6..efbc1777000a 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -508,6 +508,26 @@ static const struct adsp_data sm8150_adsp_resource = {
.ssctl_id = 0x14,
};
+static const struct adsp_data sm8250_adsp_resource = {
+ .crash_reason_smem = 423,
+ .firmware_name = "adsp.mdt",
+ .pas_id = 1,
+ .has_aggre2_clk = false,
+ .auto_boot = true,
+ .active_pd_names = (char*[]){
+ "load_state",
+ NULL
+ },
+ .proxy_pd_names = (char*[]){
+ "lcx",
+ "lmx",
+ NULL
+ },
+ .ssr_name = "lpass",
+ .sysmon_name = "adsp",
+ .ssctl_id = 0x14,
+};
+
static const struct adsp_data msm8998_adsp_resource = {
.crash_reason_smem = 423,
.firmware_name = "adsp.mdt",
@@ -553,6 +573,25 @@ static const struct adsp_data sm8150_cdsp_resource = {
.ssctl_id = 0x17,
};
+static const struct adsp_data sm8250_cdsp_resource = {
+ .crash_reason_smem = 601,
+ .firmware_name = "cdsp.mdt",
+ .pas_id = 18,
+ .has_aggre2_clk = false,
+ .auto_boot = true,
+ .active_pd_names = (char*[]){
+ "load_state",
+ NULL
+ },
+ .proxy_pd_names = (char*[]){
+ "cx",
+ NULL
+ },
+ .ssr_name = "cdsp",
+ .sysmon_name = "cdsp",
+ .ssctl_id = 0x17,
+};
+
static const struct adsp_data mpss_resource_init = {
.crash_reason_smem = 421,
.firmware_name = "modem.mdt",
@@ -604,6 +643,26 @@ static const struct adsp_data sm8150_slpi_resource = {
.ssctl_id = 0x16,
};
+static const struct adsp_data sm8250_slpi_resource = {
+ .crash_reason_smem = 424,
+ .firmware_name = "slpi.mdt",
+ .pas_id = 12,
+ .has_aggre2_clk = false,
+ .auto_boot = true,
+ .active_pd_names = (char*[]){
+ "load_state",
+ NULL
+ },
+ .proxy_pd_names = (char*[]){
+ "lcx",
+ "lmx",
+ NULL
+ },
+ .ssr_name = "dsps",
+ .sysmon_name = "slpi",
+ .ssctl_id = 0x16,
+};
+
static const struct adsp_data msm8998_slpi_resource = {
.crash_reason_smem = 424,
.firmware_name = "slpi.mdt",
@@ -644,6 +703,9 @@ static const struct of_device_id adsp_of_match[] = {
{ .compatible = "qcom,sm8150-cdsp-pas", .data = &sm8150_cdsp_resource},
{ .compatible = "qcom,sm8150-mpss-pas", .data = &mpss_resource_init},
{ .compatible = "qcom,sm8150-slpi-pas", .data = &sm8150_slpi_resource},
+ { .compatible = "qcom,sm8250-adsp-pas", .data = &sm8250_adsp_resource},
+ { .compatible = "qcom,sm8250-cdsp-pas", .data = &sm8250_cdsp_resource},
+ { .compatible = "qcom,sm8250-slpi-pas", .data = &sm8250_slpi_resource},
{ },
};
MODULE_DEVICE_TABLE(of, adsp_of_match);
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs
2020-04-30 18:00 [PATCH v2 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Bjorn Andersson
2020-04-30 18:00 ` [PATCH v2 2/2] remoteproc: qcom: pas: Add SM8250 PAS remoteprocs Bjorn Andersson
2020-05-12 15:37 ` [PATCH v2 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs Rob Herring
@ 2020-05-14 13:45 ` Vinod Koul
2 siblings, 0 replies; 5+ messages in thread
From: Vinod Koul @ 2020-05-14 13:45 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Ohad Ben-Cohen, Rob Herring, linux-arm-msm, linux-remoteproc,
devicetree, linux-kernel, Sibi Sankar
On 30-04-20, 11:00, Bjorn Andersson wrote:
> Add the SM8250 audio, compute and sensor remoteprocs to the PAS DT
> binding.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
>
> Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v1:
> - Changed adsp power-domains to lcx and added missing lmx
>
> .../devicetree/bindings/remoteproc/qcom,adsp.txt | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 9938918b2fea..c18c1b8d2869 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -21,6 +21,9 @@ on the Qualcomm ADSP Hexagon core.
> "qcom,sm8150-cdsp-pas"
> "qcom,sm8150-mpss-pas"
> "qcom,sm8150-slpi-pas"
> + "qcom,sm8250-adsp-pas"
> + "qcom,sm8250-cdsp-pas"
> + "qcom,sm8250-slpi-pas"
>
> - interrupts-extended:
> Usage: required
> @@ -44,6 +47,9 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> qcom,sm8150-slpi-pas:
> + qcom,sm8250-adsp-pas:
> + qcom,sm8250-cdsp-pas:
> + qcom,sm8250-slpi-pas:
> must be "wdog", "fatal", "ready", "handover", "stop-ack"
> qcom,qcs404-wcss-pas:
> qcom,sm8150-mpss-pas:
> @@ -105,10 +111,13 @@ on the Qualcomm ADSP Hexagon core.
> qcom,sdm845-cdsp-pas:
> qcom,sm8150-adsp-pas:
> qcom,sm8150-cdsp-pas:
> + qcom,sm8250-cdsp-pas:
> must be "cx", "load_state"
> qcom,sm8150-mpss-pas:
> must be "cx", "load_state", "mss"
> + qcom,sm8250-adsp-pas:
> qcom,sm8150-slpi-pas:
> + qcom,sm8250-slpi-pas:
> must be "lcx", "lmx", "load_state"
>
> - memory-region:
> --
> 2.24.0
--
~Vinod
^ permalink raw reply [flat|nested] 5+ messages in thread