From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9EFC433E0 for ; Thu, 14 May 2020 14:15:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B94520671 for ; Thu, 14 May 2020 14:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589465729; bh=M7KMNxwSSfTgmt0MkIbH3NUhq1iJ/RxQlCObAMOEohI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=E5s5hSSFQBrFHdABysfzlIzmRFb4IACPw7IYX1vYcWxxsZDO3jFFtSY9RIReBRJjv rPu1wYvvA3Y4YGVfnPGd7n2BRQYT1znuU+Rgs7UYsRzHp0r+XDxpNcWEZerYxZyKrS 6ohhs2yJaJMn4GBF0pxlxVMXy07nkIHSzAo04mXE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgENOP2 (ORCPT ); Thu, 14 May 2020 10:15:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:60034 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbgENOP2 (ORCPT ); Thu, 14 May 2020 10:15:28 -0400 Received: from localhost (unknown [122.182.193.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D01120671; Thu, 14 May 2020 14:15:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589465728; bh=M7KMNxwSSfTgmt0MkIbH3NUhq1iJ/RxQlCObAMOEohI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cy47zUIYmLwIScfGmX6mF9OXTP9WaSnD6gHHFTDbe73TFgrG6NYkxi7EdlzBvLDtT ksnbsUjUmVOICSr91LcFngJ1hZJ/B8wGgzjyS/PbI2659ixty6zTmFVkVPtM0iZHYc 9slKetQe6APMCEO5Nlt1viRNLBMGf0718rE/yoFM= Date: Thu, 14 May 2020 19:45:23 +0530 From: Vinod Koul To: Bjorn Andersson Cc: Andy Gross , Ohad Ben-Cohen , Baolin Wang , Rob Herring , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] hwspinlock: qcom: Allow mmio usage in addition to syscon Message-ID: <20200514141523.GW14092@vkoul-mobl> References: <20200513005441.1102586-1-bjorn.andersson@linaro.org> <20200513005441.1102586-4-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200513005441.1102586-4-bjorn.andersson@linaro.org> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 12-05-20, 17:54, Bjorn Andersson wrote: > In all modern Qualcomm platforms the mutex region of the TCSR is forked > off into its own block, all with a offset of 0 and stride of 4096. So > add support for directly memory mapping this register space, to avoid > the need to represent this block using a syscon. > > Signed-off-by: Bjorn Andersson > --- > drivers/hwspinlock/qcom_hwspinlock.c | 72 +++++++++++++++++++++------- > 1 file changed, 56 insertions(+), 16 deletions(-) > > diff --git a/drivers/hwspinlock/qcom_hwspinlock.c b/drivers/hwspinlock/qcom_hwspinlock.c > index f0da544b14d2..d8d4d729816c 100644 > --- a/drivers/hwspinlock/qcom_hwspinlock.c > +++ b/drivers/hwspinlock/qcom_hwspinlock.c > @@ -70,41 +70,81 @@ static const struct of_device_id qcom_hwspinlock_of_match[] = { > }; > MODULE_DEVICE_TABLE(of, qcom_hwspinlock_of_match); > > -static int qcom_hwspinlock_probe(struct platform_device *pdev) > +static struct regmap *qcom_hwspinlock_probe_syscon(struct platform_device *pdev, > + u32 *base, u32 *stride) > { > - struct hwspinlock_device *bank; > struct device_node *syscon; > - struct reg_field field; > struct regmap *regmap; > - size_t array_size; > - u32 stride; > - u32 base; > int ret; > - int i; > > syscon = of_parse_phandle(pdev->dev.of_node, "syscon", 0); > - if (!syscon) { > - dev_err(&pdev->dev, "no syscon property\n"); any reason to drop the log? > - return -ENODEV; > - } > + if (!syscon) > + return ERR_PTR(-ENODEV); > > regmap = syscon_node_to_regmap(syscon); > of_node_put(syscon); > if (IS_ERR(regmap)) > - return PTR_ERR(regmap); > + return regmap; > > - ret = of_property_read_u32_index(pdev->dev.of_node, "syscon", 1, &base); > + ret = of_property_read_u32_index(pdev->dev.of_node, "syscon", 1, base); > if (ret < 0) { > dev_err(&pdev->dev, "no offset in syscon\n"); > - return -EINVAL; > + return ERR_PTR(-EINVAL); > } > > - ret = of_property_read_u32_index(pdev->dev.of_node, "syscon", 2, &stride); > + ret = of_property_read_u32_index(pdev->dev.of_node, "syscon", 2, stride); > if (ret < 0) { > dev_err(&pdev->dev, "no stride syscon\n"); > - return -EINVAL; > + return ERR_PTR(-EINVAL); > } > > + return regmap; > +} > + > +static const struct regmap_config tcsr_mutex_config = { > + .reg_bits = 32, > + .reg_stride = 4, > + .val_bits = 32, > + .max_register = 0x40000, > + .fast_io = true, > +}; > + > +static struct regmap *qcom_hwspinlock_probe_mmio(struct platform_device *pdev, > + u32 *offset, u32 *stride) > +{ > + struct device *dev = &pdev->dev; > + struct resource *res; > + void __iomem *base; > + > + /* All modern platform has offset 0 and stride of 4k */ > + *offset = 0; > + *stride = 0x1000; Wouldn't it make sense to read this from DT rather than code in kernel? -- ~Vinod