Linux-remoteproc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] remoteproc: wcss: Fix function call for new API
@ 2020-05-18 21:08 Valdis Klētnieks
       [not found] ` <77864.1589836457@turing-police>
  0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2020-05-18 21:08 UTC (permalink / raw)
  To: Sivaprakash Murugesan, Andy Gross, Bjorn Andersson,
	Ohad Ben-Cohen, Philipp Zabel
  Cc: linux-arm-msm, linux-remoteproc, linux-kernel

commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication

throws a compile error:

   CC [M]  drivers/remoteproc/qcom_q6v5_wcss.o
drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe':
drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev'
  qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
  ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/remoteproc/qcom_q6v5_wcss.c:16:
drivers/remoteproc/qcom_common.h:35:6: note: declared here
 void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink,
      ^~~~~~~~~~~~~~~~~~~~~

Update to API change from commit  cd9fc8f:  remoteproc: qcom: Pass ssr_name to glink subdevice

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
index 48d16d81f94d..99ecc0e6276e 100644
--- a/drivers/remoteproc/qcom_q6v5_wcss.c
+++ b/drivers/remoteproc/qcom_q6v5_wcss.c
@@ -560,7 +560,7 @@ static int q6v5_wcss_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_rproc;
 
-	qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
+	qcom_add_glink_subdev(rproc, &wcss->glink_subdev,"q6wcss");
 	qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss");
 
 	ret = rproc_add(rproc);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] remoteproc: wcss: Fix function call for new API
       [not found] ` <77864.1589836457@turing-police>
@ 2020-05-18 22:26   ` Bjorn Andersson
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-05-18 22:26 UTC (permalink / raw)
  To: Valdis Kl??tnieks
  Cc: Sivaprakash Murugesan, Andy Gross, Ohad Ben-Cohen, Philipp Zabel,
	linux-arm-msm, linux-remoteproc, linux-kernel

On Mon 18 May 14:14 PDT 2020, Valdis Kl??tnieks wrote:

> On Mon, 18 May 2020 17:08:26 -0400, "Valdis Kl??tnieks" said:
> > commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication
> >
> > throws a compile error:
> >
> >    CC [M]  drivers/remoteproc/qcom_q6v5_wcss.o
> > drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe':
> 
>  Ignore this - was fixed between when I noted the problem and when I sent the mail :)

Right, I fixed this a few days back. Thanks for the patch and thanks for
confirming that it's fixed!

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 21:08 [PATCH] remoteproc: wcss: Fix function call for new API Valdis Klētnieks
     [not found] ` <77864.1589836457@turing-police>
2020-05-18 22:26   ` Bjorn Andersson

Linux-remoteproc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \
		linux-remoteproc@vger.kernel.org
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git