Linux-remoteproc Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop
@ 2020-06-02 16:32 Sibi Sankar
  2020-06-02 16:32 ` [PATCH 2/2] remoteproc: qcom_q6v5_mss: Remove redundant running state Sibi Sankar
  2020-06-02 17:44 ` [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop Evan Green
  0 siblings, 2 replies; 9+ messages in thread
From: Sibi Sankar @ 2020-06-02 16:32 UTC (permalink / raw)
  To: bjorn.andersson
  Cc: agross, linux-arm-msm, linux-remoteproc, linux-kernel, evgreen,
	ohad, rohitkr, Sibi Sankar, stable

Sometimes the stop triggers a watchdog rather than a stop-ack. Update
the running state to false on requesting stop to skip the watchdog
instead.

Error Logs:
$ echo stop > /sys/class/remoteproc/remoteproc0/state
ipa 1e40000.ipa: received modem stopping event
remoteproc-modem: watchdog received: sys_m_smsm_mpss.c:291:APPS force stop
qcom-q6v5-mss 4080000.remoteproc-modem: port failed halt
ipa 1e40000.ipa: received modem offline event
remoteproc0: stopped remote processor 4080000.remoteproc-modem

Fixes: 3b415c8fb263 ("remoteproc: q6v5: Extract common resource handling")
Cc: stable@vger.kernel.org
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
---
 drivers/remoteproc/qcom_q6v5.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/remoteproc/qcom_q6v5.c b/drivers/remoteproc/qcom_q6v5.c
index 111a442c993c4..fd6fd36268d93 100644
--- a/drivers/remoteproc/qcom_q6v5.c
+++ b/drivers/remoteproc/qcom_q6v5.c
@@ -153,6 +153,8 @@ int qcom_q6v5_request_stop(struct qcom_q6v5 *q6v5)
 {
 	int ret;
 
+	q6v5->running = false;
+
 	qcom_smem_state_update_bits(q6v5->state,
 				    BIT(q6v5->stop_bit), BIT(q6v5->stop_bit));
 
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 16:32 [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop Sibi Sankar
2020-06-02 16:32 ` [PATCH 2/2] remoteproc: qcom_q6v5_mss: Remove redundant running state Sibi Sankar
2020-06-02 17:39   ` Evan Green
2020-07-28  6:20   ` Bjorn Andersson
2020-06-02 17:44 ` [PATCH 1/2] remoteproc: qcom: q6v5: Update running state before requesting stop Evan Green
2020-06-03  5:29   ` Sibi Sankar
2020-06-03 22:33     ` Evan Green
2020-06-04 18:50       ` Sibi Sankar
2020-07-28  6:19       ` Bjorn Andersson

Linux-remoteproc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \
		linux-remoteproc@vger.kernel.org
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git