From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Suman Anna <s-anna@ti.com>, Ohad Ben-Cohen <ohad@wizery.com>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
od@zcrc.me, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v7 4/5] remoteproc: ingenic: Added remoteproc driver
Date: Sun, 21 Jun 2020 12:30:22 -0700 [thread overview]
Message-ID: <20200621193022.GA149351@builder.lan> (raw)
In-Reply-To: <G3ATBQ.KJYAFROKKWDP1@crapouillou.net>
On Fri 12 Jun 04:47 PDT 2020, Paul Cercueil wrote:
> Le jeu. 11 juin 2020 à 19:21, Suman Anna <s-anna@ti.com> a écrit :
> > On 6/11/20 5:21 PM, Paul Cercueil wrote:
> > > Le jeu. 11 juin 2020 à 16:47, Suman Anna <s-anna@ti.com> a écrit :
> > > > On 5/15/20 5:43 AM, Paul Cercueil wrote:
[..]
> > > > > diff --git a/drivers/remoteproc/ingenic_rproc.c
> > > > > \x7f\x7f\x7fb/drivers/remoteproc/ingenic_rproc.c
[..]
> > > > > + /* The clocks must be enabled for the firmware to be
> > > > > loaded in \x7f\x7f\x7fTCSM */
> > > > > + ret = clk_bulk_prepare_enable(ARRAY_SIZE(vpu->clks),
> > > > > vpu->clks);
> > > > > + if (ret) {
> > > > > + dev_err(dev, "Unable to start clocks\n");
> > > > > + return ret;
> > > > > + }
> > > >
> > > > You are enabling the clocks directly here and also trying to
> > > > manage \x7f\x7fthem through pm_runtime callbacks again.
> > >
> > > Yes. The clocks need to be enabled in the probe.
> >
> > For the preferred non CONFIG_PM case now and lack of
> > prepare/unprepare().
>
> I want to make it clear that I'm not against having .prepare/.unprepare, but
> I want to see what maintainers have to say.
>
I think it's perfectly reasonable to enable all the resources here and
then if CONFIG_PM isn't set you just leave them enabled throughout.
Regards,
Bjorn
next prev parent reply other threads:[~2020-06-21 19:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 10:43 [PATCH v7 1/5] dt-bindings: Document JZ47xx VPU auxiliary processor Paul Cercueil
2020-05-15 10:43 ` [PATCH v7 2/5] remoteproc: Add device-managed variants of rproc_alloc/rproc_add Paul Cercueil
2020-05-15 10:43 ` [PATCH v7 3/5] remoteproc: Add support for runtime PM Paul Cercueil
2020-05-22 16:47 ` Suman Anna
2020-05-22 17:11 ` Paul Cercueil
2020-06-08 22:03 ` Suman Anna
2020-06-08 22:46 ` Paul Cercueil
2020-06-08 23:10 ` Suman Anna
2020-06-10 9:40 ` Paul Cercueil
2020-06-11 4:39 ` Bjorn Andersson
2020-06-11 21:17 ` Suman Anna
2020-06-22 17:51 ` Arnaud POULIQUEN
2020-05-15 10:43 ` [PATCH v7 4/5] remoteproc: ingenic: Added remoteproc driver Paul Cercueil
2020-05-18 23:57 ` Bjorn Andersson
2020-06-11 21:47 ` Suman Anna
2020-06-11 22:21 ` Paul Cercueil
2020-06-12 0:21 ` Suman Anna
2020-06-12 11:47 ` Paul Cercueil
2020-06-12 14:47 ` Suman Anna
2020-06-21 19:30 ` Bjorn Andersson [this message]
2020-06-24 23:14 ` Mathieu Poirier
2020-05-15 10:43 ` [PATCH v7 5/5] MAINTAINERS: Add myself as reviewer for Ingenic rproc driver Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200621193022.GA149351@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=od@zcrc.me \
--cc=ohad@wizery.com \
--cc=paul@crapouillou.net \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).