Linux-remoteproc Archive on lore.kernel.org
 help / color / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: ohad@wizery.com, bjorn.andersson@linaro.org,
	loic.pallardy@st.com, arnaud.pouliquen@st.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com
Subject: [PATCH v6 04/11] remoteproc: stm32: Remove memory translation from DT parsing
Date: Tue, 14 Jul 2020 14:04:38 -0600
Message-ID: <20200714200445.1427257-5-mathieu.poirier@linaro.org> (raw)
In-Reply-To: <20200714200445.1427257-1-mathieu.poirier@linaro.org>

Other than one has to be done after the other, there is no correlation
between memory translation and DT parsing.  As such move function
stm32_rproc_of_memory_translations() to stm32_rproc_probe() so that
stm32_rproc_parse_dt() can be extended to look for attach bindings
in a clean way.

Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
Reviewed-by: Loic Pallardy <loic.pallardy@st.com>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 drivers/remoteproc/stm32_rproc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index cbba995a80a2..986f34a336a7 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -607,7 +607,7 @@ static int stm32_rproc_parse_dt(struct platform_device *pdev,
 
 	*auto_boot = of_property_read_bool(np, "st,auto-boot");
 
-	return stm32_rproc_of_memory_translations(pdev, ddata);
+	return 0;
 }
 
 static int stm32_rproc_probe(struct platform_device *pdev)
@@ -634,6 +634,10 @@ static int stm32_rproc_probe(struct platform_device *pdev)
 	if (ret)
 		goto free_rproc;
 
+	ret = stm32_rproc_of_memory_translations(pdev, ddata);
+	if (ret)
+		goto free_rproc;
+
 	rproc->has_iommu = false;
 	ddata->workqueue = create_workqueue(dev_name(dev));
 	if (!ddata->workqueue) {
-- 
2.25.1


  parent reply index

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-14 20:04 [PATCH v6 00/11] remoteproc: stm32: Add support for attaching to M4 Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 01/11] remoteproc: stm32: Decouple rproc from memory translation Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 02/11] remoteproc: stm32: Request IRQ with platform device Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 03/11] remoteproc: stm32: Decouple rproc from DT parsing Mathieu Poirier
2020-07-14 20:04 ` Mathieu Poirier [this message]
2020-07-14 20:04 ` [PATCH v6 05/11] remoteproc: stm32: Parse syscon that will manage M4 synchronisation Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 06/11] remoteproc: stm32: Properly set co-processor state when attaching Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 07/11] remoteproc: Make function rproc_resource_cleanup() public Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 08/11] remoteproc: stm32: Parse memory regions when attaching to M4 Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 09/11] remoteproc: stm32: Properly handle the resource table when attaching Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 10/11] remoteproc: stm32: Introduce new attach() operation Mathieu Poirier
2020-07-14 20:04 ` [PATCH v6 11/11] remoteproc: stm32: Update M4 state in stm32_rproc_stop() Mathieu Poirier
2020-07-15  6:51 ` [PATCH v6 00/11] remoteproc: stm32: Add support for attaching to M4 Arnaud POULIQUEN
2020-07-15 15:32   ` Mathieu Poirier
2020-07-22  0:00 ` patchwork-bot+linux-remoteproc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714200445.1427257-5-mathieu.poirier@linaro.org \
    --to=mathieu.poirier@linaro.org \
    --cc=alexandre.torgue@st.com \
    --cc=arnaud.pouliquen@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=loic.pallardy@st.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-remoteproc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \
		linux-remoteproc@vger.kernel.org
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git