From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE96C433EC for ; Thu, 23 Jul 2020 08:34:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD0F52084D for ; Thu, 23 Jul 2020 08:34:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ki/5frSu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725846AbgGWIer (ORCPT ); Thu, 23 Jul 2020 04:34:47 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34699 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725858AbgGWIeq (ORCPT ); Thu, 23 Jul 2020 04:34:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595493285; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xGTIbgCx+rDVKvWTlEHAJATfxUUpkuPfnD7JMbYkQY8=; b=Ki/5frSuIz9bZtDOAZpDQcd4zGzzmoEa99Dr6ePx3xvGUC3EaYT6zoJAJ4V5/WceE+hCJL aawQBPwFfkKQ6xuZjjySxsuZJet+LwbK/aIEYVHrJKKo0YlHvSAfdiBYHoqsynyDTJc/fu FOpKZ/6z4FdZj3ug+OhgC7Q2qYDqbxs= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-SgaDFDlzP6a-PRNU-JWZbg-1; Thu, 23 Jul 2020 04:34:43 -0400 X-MC-Unique: SgaDFDlzP6a-PRNU-JWZbg-1 Received: by mail-wr1-f69.google.com with SMTP id j5so1158567wro.6 for ; Thu, 23 Jul 2020 01:34:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xGTIbgCx+rDVKvWTlEHAJATfxUUpkuPfnD7JMbYkQY8=; b=tCj1RKXNDYX2bepA8Ulpbmni5ReKMQRNCJKLSJ/IkAVx/FXOsu+X7dAZpVGjMOjSc0 1uKus15wWnkqAqJG7O9MRDYLzfOjFWkPQzBIhjjUcCssgF+QEJPSKqfPcWVWCc7WwrNd 2CyXPquOxnM8LG3ugJrV/DNHBXUOsZccgPJ0Sw/ZvMrPQlUIJFfRb4fOFUrrxlcsyJzF LOUVTjVTmJBKgQG4cABFE+sgnxqHQoMpTdLoijL42/dy0qI3ySuGVBvmx7qniLOtuL1a JGWwJyKQFGoXpmqEDgf64mMyCrcoNARdYT5+qfPRIlhtxmhSHqWuSVEwATi7VW/5/ine MIPg== X-Gm-Message-State: AOAM532O8u3N+FAHQZ2cmK8+Bt/gjhBJnGa0hDOZRLp1LnRMP8ZfS9vl 3x57RMcI+k4Ct00WsA+moTByK9Ds395Cvt7tmeRQV8al3XXZi2Vnew8QOBDkzSlIAooC7rZJ1MK f6S/16sB8Y/477HL/6TrTI3wttuIjNQ== X-Received: by 2002:a7b:cb8d:: with SMTP id m13mr2650627wmi.120.1595493281556; Thu, 23 Jul 2020 01:34:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXZi0KGyqccwK0YBH6EPSIFaT3xENgDnbzBhFqPmSY7XV5a91YqQHX0IHrfs3AUaL6q2mXag== X-Received: by 2002:a7b:cb8d:: with SMTP id m13mr2650615wmi.120.1595493281258; Thu, 23 Jul 2020 01:34:41 -0700 (PDT) Received: from steredhat.lan ([5.180.207.22]) by smtp.gmail.com with ESMTPSA id o2sm2897806wrj.21.2020.07.23.01.34.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2020 01:34:40 -0700 (PDT) Date: Thu, 23 Jul 2020 10:34:35 +0200 From: Stefano Garzarella To: Guennadi Liakhovetski Cc: kvm@vger.kernel.org, linux-remoteproc@vger.kernel.org, virtualization@lists.linux-foundation.org, sound-open-firmware@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , "Michael S. Tsirkin" , Jason Wang , Ohad Ben-Cohen , Bjorn Andersson , Mathieu Poirier , Vincent Whitchurch Subject: Re: [PATCH v4 1/4] vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl Message-ID: <20200723083435.3rjn5qiqhxcvxxwk@steredhat.lan> References: <20200722150927.15587-1-guennadi.liakhovetski@linux.intel.com> <20200722150927.15587-2-guennadi.liakhovetski@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722150927.15587-2-guennadi.liakhovetski@linux.intel.com> Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Wed, Jul 22, 2020 at 05:09:24PM +0200, Guennadi Liakhovetski wrote: > VHOST_VSOCK_SET_RUNNING is used by the vhost vsock driver to perform > crucial VirtQueue initialisation, like assigning .private fields and > calling vhost_vq_init_access(), and clean up. However, this ioctl is > actually extremely useful for any vhost driver, that doesn't have a > side channel to inform it of a status change, e.g. upon a guest > reboot. This patch makes that ioctl generic, while preserving its > numeric value and also keeping the original alias. > > Signed-off-by: Guennadi Liakhovetski > --- > include/uapi/linux/vhost.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h > index 0c2349612e77..5d9254e2a6b6 100644 > --- a/include/uapi/linux/vhost.h > +++ b/include/uapi/linux/vhost.h > @@ -95,6 +95,8 @@ > #define VHOST_SET_BACKEND_FEATURES _IOW(VHOST_VIRTIO, 0x25, __u64) > #define VHOST_GET_BACKEND_FEATURES _IOR(VHOST_VIRTIO, 0x26, __u64) > > +#define VHOST_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > + > /* VHOST_NET specific defines */ > > /* Attach virtio net ring to a raw socket, or tap device. > @@ -116,7 +118,7 @@ > /* VHOST_VSOCK specific defines */ > > #define VHOST_VSOCK_SET_GUEST_CID _IOW(VHOST_VIRTIO, 0x60, __u64) > -#define VHOST_VSOCK_SET_RUNNING _IOW(VHOST_VIRTIO, 0x61, int) > +#define VHOST_VSOCK_SET_RUNNING VHOST_SET_RUNNING > > /* VHOST_VDPA specific defines */ > > -- > 2.27.0 > Reviewed-by: Stefano Garzarella