From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, tsoni@codeaurora.org,
psodagud@codeaurora.org, sidgup@codeaurora.org
Subject: Re: [PATCH v5 1/2] remoteproc: Move coredump configuration to sysfs
Date: Fri, 25 Sep 2020 20:32:01 -0700 [thread overview]
Message-ID: <20200926033201.GB10036@builder.lan> (raw)
In-Reply-To: <1600449731-3056-2-git-send-email-rishabhb@codeaurora.org>
On Fri 18 Sep 10:22 PDT 2020, Rishabh Bhatnagar wrote:
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
[..]
> +static ssize_t coredump_store(struct device *dev,
> + struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + struct rproc *rproc = to_rproc(dev);
> +
> + if (rproc->state == RPROC_CRASHED) {
> + dev_err(&rproc->dev, "can't change coredump configuration\n");
> + return -EBUSY;
> + }
> +
> + if (sysfs_streq(buf, "disable")) {
As pointed out by Sibi (somewhere) this should be "disabled" to match
what's returned in coredump_show() and what goes into the recovery
file.
> + rproc->dump_conf = RPROC_COREDUMP_DISABLED;
> + } else if (sysfs_streq(buf, "inline")) {
> + rproc->dump_conf = RPROC_COREDUMP_INLINE;
> + } else if (sysfs_streq(buf, "default")) {
As I pointed out in a previous review, I think it makes sense to change
the default for dump_conf to "disabled" (a separate change). But in
doing so using the word "default" in the sysfs interface would be
misleading - and once it's part of sysfs it stays.
So how about changing this to "enabled"?
PS. The change of the default value of dump_conf would, in line with
Mathieu's ask, be a separate/unrelated change.
Regards,
Bjorn
next prev parent reply other threads:[~2020-09-26 3:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 17:22 [PATCH v5 0/2] Move recovery/coredump configuration to sysfs Rishabh Bhatnagar
2020-09-18 17:22 ` [PATCH v5 1/2] remoteproc: Move coredump " Rishabh Bhatnagar
2020-09-26 3:32 ` Bjorn Andersson [this message]
2020-09-18 17:22 ` [PATCH v5 2/2] remoteproc: Move recovery " Rishabh Bhatnagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200926033201.GB10036@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).