From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: bjorn.andersson@linaro.org, o.rempel@pengutronix.de,
robh+dt@kernel.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-arm-kernel@lists.infradead.org,
Richard Zhu <hongxing.zhu@nxp.com>
Subject: Re: [PATCH V2 4/7] remoteproc: imx_rproc: use devm_ioremap
Date: Mon, 19 Oct 2020 11:24:49 -0600 [thread overview]
Message-ID: <20201019172449.GB496175@xps15> (raw)
In-Reply-To: <20200927064131.24101-5-peng.fan@nxp.com>
On Sun, Sep 27, 2020 at 02:41:28PM +0800, Peng Fan wrote:
> We might need to map an region multiple times, becaue the region might
> be shared between remote processors, such i.MX8QM with dual M4 cores.
> So use devm_ioremap, not devm_ioremap_resource.
>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> drivers/remoteproc/imx_rproc.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index aa5fbd0c7768..48ce09e857ee 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -298,9 +298,10 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> if (b >= IMX7D_RPROC_MEM_MAX)
> break;
>
> - priv->mem[b].cpu_addr = devm_ioremap_resource(&pdev->dev, &res);
> + /* Not use resource version, because we might share region*/
s/"region*"/"region *"
> + priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start, resource_size(&res));
> if (IS_ERR(priv->mem[b].cpu_addr)) {
> - dev_err(dev, "devm_ioremap_resource failed\n");
> + dev_err(dev, "devm_ioremap %pR failed\n", &res);
> err = PTR_ERR(priv->mem[b].cpu_addr);
> return err;
> }
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-10-19 17:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 6:41 [PATCH V2 0/7] remoteproc: imx_rproc: support iMX8MQ/M Peng Fan
2020-09-27 6:41 ` [PATCH V2 1/7] remoteproc: elf: support platform specific memory hook Peng Fan
2020-10-19 16:58 ` Mathieu Poirier
2020-09-27 6:41 ` [PATCH V2 2/7] remoteproc: imx_rproc: add elf memory hooks Peng Fan
2020-09-27 6:41 ` [PATCH V2 3/7] remoteproc: imx_rproc: correct err message Peng Fan
2020-09-27 6:41 ` [PATCH V2 4/7] remoteproc: imx_rproc: use devm_ioremap Peng Fan
2020-10-19 17:24 ` Mathieu Poirier [this message]
2020-09-27 6:41 ` [PATCH V2 5/7] remoteproc: imx_rproc: add i.MX specific parse fw hook Peng Fan
2020-10-19 17:48 ` Mathieu Poirier
2020-09-27 6:41 ` [PATCH V2 6/7] remoteproc: imx_rproc: support i.MX8MQ/M Peng Fan
2020-10-19 17:59 ` Mathieu Poirier
2020-09-27 6:41 ` [PATCH V2 7/7] remoteproc: imx_proc: enable virtio/mailbox Peng Fan
2020-10-19 20:12 ` Mathieu Poirier
2020-10-08 0:52 ` [PATCH V2 0/7] remoteproc: imx_rproc: support iMX8MQ/M Peng Fan
2020-10-08 14:40 ` Mathieu Poirier
2020-10-09 2:02 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201019172449.GB496175@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).