From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
o.rempel@pengutronix.de, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
linux-remoteproc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX
Date: Thu, 25 Mar 2021 17:23:28 -0600 [thread overview]
Message-ID: <20210325232328.GC1982573@xps15> (raw)
In-Reply-To: <20210325230042.GB1982573@xps15>
On Thu, Mar 25, 2021 at 05:00:42PM -0600, Mathieu Poirier wrote:
> Hi Peng,
>
> On Fri, Mar 19, 2021 at 06:47:07PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > 8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32,
> > and also rename it to IMX_RPROC_MEM_MAX which make more sense.
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> > drivers/remoteproc/imx_rproc.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> > index 6d3207ccbaef..24275429a7cc 100644
> > --- a/drivers/remoteproc/imx_rproc.c
> > +++ b/drivers/remoteproc/imx_rproc.c
> > @@ -48,7 +48,7 @@
> > | IMX6SX_SW_M4C_NON_SCLR_RST \
> > | IMX6SX_SW_M4C_RST)
> >
> > -#define IMX7D_RPROC_MEM_MAX 8
> > +#define IMX_RPROC_MEM_MAX 32
>
> The size of structure imx_rproc_att_imx7d and imx_rproc_att_imx6sx have
> not changed nor has there been an addition of new imx_rproc_att that would
> justify the change.
>
> It seems to me you are working on something internally and this patch is in
> preparation for that. If that is the case then please resubmit this patch with
> the rest of the code.
Reviewing the other patch in this set [1], I understand why the extension is
needed. Without a cover letter I assume the patches were not related. Next
time please add one so that I know exactly what is going on. Adding a line in
the changelog that explains why it is needed, i.e for the resource table, would
also be helpful.
Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
[1]. remoteproc: imx_rproc: support remote cores booted before Linux Kernel
>
> Thanks,
> Mathieu
>
> >
> > /**
> > * struct imx_rproc_mem - slim internal memory structure
> > @@ -88,7 +88,7 @@ struct imx_rproc {
> > struct regmap *regmap;
> > struct rproc *rproc;
> > const struct imx_rproc_dcfg *dcfg;
> > - struct imx_rproc_mem mem[IMX7D_RPROC_MEM_MAX];
> > + struct imx_rproc_mem mem[IMX_RPROC_MEM_MAX];
> > struct clk *clk;
> > struct mbox_client cl;
> > struct mbox_chan *tx_ch;
> > @@ -272,7 +272,7 @@ static void *imx_rproc_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *i
> > if (imx_rproc_da_to_sys(priv, da, len, &sys))
> > return NULL;
> >
> > - for (i = 0; i < IMX7D_RPROC_MEM_MAX; i++) {
> > + for (i = 0; i < IMX_RPROC_MEM_MAX; i++) {
> > if (sys >= priv->mem[i].sys_addr && sys + len <
> > priv->mem[i].sys_addr + priv->mem[i].size) {
> > unsigned int offset = sys - priv->mem[i].sys_addr;
> > @@ -425,7 +425,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> > if (!(att->flags & ATT_OWN))
> > continue;
> >
> > - if (b >= IMX7D_RPROC_MEM_MAX)
> > + if (b >= IMX_RPROC_MEM_MAX)
> > break;
> >
> > priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev,
> > @@ -459,7 +459,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> > return err;
> > }
> >
> > - if (b >= IMX7D_RPROC_MEM_MAX)
> > + if (b >= IMX_RPROC_MEM_MAX)
> > break;
> >
> > /* Not use resource version, because we might share region */
> > --
> > 2.30.0
> >
prev parent reply other threads:[~2021-03-25 23:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 10:47 [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX Peng Fan (OSS)
2021-03-19 10:47 ` [PATCH 2/2] remoteproc: imx_rproc: support remote cores booted before Linux Kernel Peng Fan (OSS)
2021-03-25 23:58 ` Mathieu Poirier
2021-03-25 23:00 ` [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX Mathieu Poirier
2021-03-25 23:23 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210325232328.GC1982573@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).