From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8657C433ED for ; Wed, 21 Apr 2021 18:06:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 754386142F for ; Wed, 21 Apr 2021 18:06:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242149AbhDUSHJ (ORCPT ); Wed, 21 Apr 2021 14:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241224AbhDUSHI (ORCPT ); Wed, 21 Apr 2021 14:07:08 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD9CEC06174A for ; Wed, 21 Apr 2021 11:06:35 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id s20so6264165plr.13 for ; Wed, 21 Apr 2021 11:06:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rTCdIGeW4Af6klHefq45nF+2qbz5fBGqc92alfd8T8Y=; b=E2FuKRBnSVVwyyWxul22Sg0uJ1sl4/2F2CVbq/RZreNFqbrgmdrZG+IdbD48BaGgf+ RsjvCBWV3RAACDrwOl9XrP6biUgwm1GJTNBvJyPq0G/PynAXny6xdGUC2hY1sB9a9Sqq BwBhOrMzTvL3MOZWTzXZpcVodktfdx6Q6gpp3Fy9FNAK4Dv9YrZ6xBNmgMxWaCvgEt22 iqAne+1MX2ZfcTFarBk+reZzFqDZkIvdPVUlOpvla1GV/oQQhlTgUAIBgeZXEKCsJ7u8 zmrzacfa/rtlYiZRNVELL7GO2uAdsc6bFAKI3xtgjXG6WmGXTDHZeQE9WY19GhQSELFR VPDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rTCdIGeW4Af6klHefq45nF+2qbz5fBGqc92alfd8T8Y=; b=Isnul6bNm33fAD+RxYzt4/SCUVj9fo51VSUlthAiIuyETOZX9HruqXcMwPoWeXDMD1 EcszOTTLro6t3N4JlWhBaKHTikpMzdLIKD/kJsMd5cyEs5XbGVOTDVdlDvizoCxD4Zz6 K6p8JvPEZcQxV+zYodGQsoKKWwABuvB0bXpH6I40MGX8x1lXYBsFI+daEgMsq9QFKfzi N6nUQ8VgQBs+v/YwFJNAYT6PnYNhwZRqf7kbURpyMk1MkxjO5bTW68kQNj6+c/S8Keh6 KGu1kr9U7YkFWNcCW1FkoYFalyc6R0XEAkAlXn9RZbFVzphQtq5rti2AALfG4ZBSV07X F9iA== X-Gm-Message-State: AOAM53283pzNaWBkdlvG05OXzgQveHW0RO9FDRgs0yqYkv+gQLGBtjws fpsPEfNclFKFV4MQlZJr2DjwCg== X-Google-Smtp-Source: ABdhPJw2Vu7bLzAqvhoR2bzc1i74eI9A1rh7ZjYCQyN8htnEleZhXTqc+1ei2B6+5gem/pGpGBMRsw== X-Received: by 2002:a17:902:778f:b029:ec:d04d:4556 with SMTP id o15-20020a170902778fb02900ecd04d4556mr4259318pll.43.1619028395305; Wed, 21 Apr 2021 11:06:35 -0700 (PDT) Received: from xps15 (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id gc15sm2683421pjb.2.2021.04.21.11.06.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Apr 2021 11:06:34 -0700 (PDT) Date: Wed, 21 Apr 2021 12:06:32 -0600 From: Mathieu Poirier To: Arnaud Pouliquen Cc: Bjorn Andersson , Ohad Ben-Cohen , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH v2 3/7] rpmsg: Update rpmsg_chrdev_register_device function Message-ID: <20210421180632.GF1223348@xps15> References: <20210413134458.17912-1-arnaud.pouliquen@foss.st.com> <20210413134458.17912-4-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210413134458.17912-4-arnaud.pouliquen@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Apr 13, 2021 at 03:44:54PM +0200, Arnaud Pouliquen wrote: > The rpmsg_chrdev driver has been replaced by the rpmsg_ctrl driver > for the /dev/rpmsg_ctrlX devices management. The reference for the > driver override is now the rpmsg_ctrl. > > Update the rpmsg_chrdev_register_device function to reflect the update, > and rename the function to use the rpmsg_ctrldev prefix. > > The platform drivers are updated accordingly. > > Signed-off-by: Arnaud Pouliquen > > --- > update from v1 > - move the rename of the rpmsg_ctrl driver from previous patch to > this one. > --- > drivers/rpmsg/qcom_glink_native.c | 2 +- > drivers/rpmsg/qcom_smd.c | 2 +- > drivers/rpmsg/rpmsg_ctrl.c | 2 +- > drivers/rpmsg/rpmsg_internal.h | 8 ++++---- > drivers/rpmsg/virtio_rpmsg_bus.c | 2 +- > 5 files changed, 8 insertions(+), 8 deletions(-) > Reviewed-by: Mathieu Poirier > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 05533c71b10e..7d7e809800ec 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -1642,7 +1642,7 @@ static int qcom_glink_create_chrdev(struct qcom_glink *glink) > rpdev->dev.parent = glink->dev; > rpdev->dev.release = qcom_glink_device_release; > > - return rpmsg_chrdev_register_device(rpdev); > + return rpmsg_ctrldev_register_device(rpdev); > } > > struct qcom_glink *qcom_glink_native_probe(struct device *dev, > diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c > index 8da1b5cb31b3..d223e438d17c 100644 > --- a/drivers/rpmsg/qcom_smd.c > +++ b/drivers/rpmsg/qcom_smd.c > @@ -1113,7 +1113,7 @@ static int qcom_smd_create_chrdev(struct qcom_smd_edge *edge) > qsdev->rpdev.dev.parent = &edge->dev; > qsdev->rpdev.dev.release = qcom_smd_release_device; > > - return rpmsg_chrdev_register_device(&qsdev->rpdev); > + return rpmsg_ctrldev_register_device(&qsdev->rpdev); > } > > /* > diff --git a/drivers/rpmsg/rpmsg_ctrl.c b/drivers/rpmsg/rpmsg_ctrl.c > index a5bb9ed97f32..059c228d0045 100644 > --- a/drivers/rpmsg/rpmsg_ctrl.c > +++ b/drivers/rpmsg/rpmsg_ctrl.c > @@ -180,7 +180,7 @@ static struct rpmsg_driver rpmsg_ctrldev_driver = { > .probe = rpmsg_ctrldev_probe, > .remove = rpmsg_ctrldev_remove, > .drv = { > - .name = "rpmsg_chrdev", > + .name = "rpmsg_ctrl", > }, > }; > > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index a76c344253bf..8c500a8f29aa 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -82,16 +82,16 @@ struct rpmsg_device *rpmsg_create_channel(struct rpmsg_device *rpdev, > int rpmsg_release_channel(struct rpmsg_device *rpdev, > struct rpmsg_channel_info *chinfo); > /** > - * rpmsg_chrdev_register_device() - register chrdev device based on rpdev > + * rpmsg_ctrl_register_device() - register a char device for control based on rpdev > * @rpdev: prepared rpdev to be used for creating endpoints > * > * This function wraps rpmsg_register_device() preparing the rpdev for use as > * basis for the rpmsg chrdev. > */ > -static inline int rpmsg_chrdev_register_device(struct rpmsg_device *rpdev) > +static inline int rpmsg_ctrldev_register_device(struct rpmsg_device *rpdev) > { > - strcpy(rpdev->id.name, "rpmsg_chrdev"); > - rpdev->driver_override = "rpmsg_chrdev"; > + strcpy(rpdev->id.name, "rpmsg_ctrl"); > + rpdev->driver_override = "rpmsg_ctrl"; > > return rpmsg_register_device(rpdev); > } > diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c > index 8e49a3bacfc7..e42234a3e2ab 100644 > --- a/drivers/rpmsg/virtio_rpmsg_bus.c > +++ b/drivers/rpmsg/virtio_rpmsg_bus.c > @@ -840,7 +840,7 @@ static struct rpmsg_device *rpmsg_virtio_add_ctrl_dev(struct virtio_device *vdev > rpdev_ctrl->dev.release = virtio_rpmsg_release_device; > rpdev_ctrl->little_endian = virtio_is_little_endian(vrp->vdev); > > - err = rpmsg_chrdev_register_device(rpdev_ctrl); > + err = rpmsg_ctrldev_register_device(rpdev_ctrl); > if (err) { > kfree(vch); > return ERR_PTR(err); > -- > 2.17.1 >