linux-remoteproc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
	o.rempel@pengutronix.de, shawnguo@kernel.org,
	s.hauer@pengutronix.de, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	linux-remoteproc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, aisheng.dong@nxp.com,
	Peng Fan <peng.fan@nxp.com>, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH V4 1/6] remoteproc: elf_loader: fix loading segment when is_iomem true
Date: Mon, 20 Sep 2021 10:23:53 -0600	[thread overview]
Message-ID: <20210920162353.GA2023964@p14s> (raw)
In-Reply-To: <20210910090621.3073540-2-peng.fan@oss.nxp.com>

On Fri, Sep 10, 2021 at 05:06:16PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> It seems luckliy work on i.MX platform, but it is wrong.
> Need use memcpy_toio, not memcpy_fromio.
> 

Lucky or not I just can't understand how this worked in the first place.

> Fixes: 40df0a91b2a52 ("remoteproc: add is_iomem to da_to_va")

SHA tag should be 12 characters.

> Tested-by: Dong Aisheng <aisheng.dong@nxp.com> (i.MX8MQ)
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dong Aisheng <aisheng.dong@nxp.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

I will add a CC:stable, fix the title, fix the SHA and pick this patch.

> ---
>  drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c
> index 469c52e62faff..44e7f9308f4bc 100644
> --- a/drivers/remoteproc/remoteproc_elf_loader.c
> +++ b/drivers/remoteproc/remoteproc_elf_loader.c
> @@ -220,7 +220,7 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw)
>  		/* put the segment where the remote processor expects it */
>  		if (filesz) {
>  			if (is_iomem)
> -				memcpy_fromio(ptr, (void __iomem *)(elf_data + offset), filesz);
> +				memcpy_toio((void __iomem *)ptr, elf_data + offset, filesz);
>  			else
>  				memcpy(ptr, elf_data + offset, filesz);
>  		}
> -- 
> 2.25.1
> 

  reply	other threads:[~2021-09-20 16:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  9:06 [PATCH V4 0/6] remoteproc: elf_loader and imx fix Peng Fan (OSS)
2021-09-10  9:06 ` [PATCH V4 1/6] remoteproc: elf_loader: fix loading segment when is_iomem true Peng Fan (OSS)
2021-09-20 16:23   ` Mathieu Poirier [this message]
2021-09-10  9:06 ` [PATCH V4 2/6] remoteproc: fix the wrong default value of is_iomem Peng Fan (OSS)
2021-09-20 16:54   ` Mathieu Poirier
2021-09-10  9:06 ` [PATCH V4 3/6] remoteproc: imx_rproc: fix TCM io memory type Peng Fan (OSS)
2021-09-20 16:59   ` Mathieu Poirier
2021-09-21  2:26     ` Peng Fan
2021-09-10  9:06 ` [PATCH V4 4/6] remoteproc: imx_rproc: fix ignoring mapping vdev regions Peng Fan (OSS)
2021-09-10  9:06 ` [PATCH V4 5/6] remoteproc: imx_rproc: fix rsc-table name Peng Fan (OSS)
2021-09-10  9:06 ` [PATCH V4 6/6] remoteproc: imx_rproc: change to ioremap_wc for dram Peng Fan (OSS)
2021-09-20 17:00   ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920162353.GA2023964@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=aisheng.dong@nxp.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=o.rempel@pengutronix.de \
    --cc=ohad@wizery.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).