From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v7 2/2] tty: add rpmsg driver References: <20200324170407.16470-1-arnaud.pouliquen@st.com> <20200324170407.16470-3-arnaud.pouliquen@st.com> <20200324171806.GB2522961@kroah.com> From: Arnaud POULIQUEN Message-ID: <426f24cb-025b-f497-e9dc-9823181c4056@st.com> Date: Wed, 25 Mar 2020 12:34:25 +0100 MIME-Version: 1.0 In-Reply-To: <20200324171806.GB2522961@kroah.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit To: Greg Kroah-Hartman Cc: Ohad Ben-Cohen , Bjorn Andersson , Jiri Slaby , linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org, Mathieu Poirier , Suman Anna , Fabien DESSENNE , linux-stm32@st-md-mailman.stormreply.com, Alan Cox , xiang xiao List-ID: On 3/24/20 6:18 PM, Greg Kroah-Hartman wrote: > On Tue, Mar 24, 2020 at 06:04:07PM +0100, Arnaud Pouliquen wrote: >> This driver exposes a standard TTY interface on top of the rpmsg >> framework through a rpmsg service. >> >> This driver supports multi-instances, offering a /dev/ttyRPMSGx entry >> per rpmsg endpoint. >> >> Signed-off-by: Arnaud Pouliquen >> --- >> Documentation/serial/tty_rpmsg.rst | 45 ++++ >> drivers/tty/Kconfig | 9 + >> drivers/tty/Makefile | 1 + >> drivers/tty/rpmsg_tty.c | 417 +++++++++++++++++++++++++++++ >> 4 files changed, 472 insertions(+) >> create mode 100644 Documentation/serial/tty_rpmsg.rst >> create mode 100644 drivers/tty/rpmsg_tty.c >> >> diff --git a/Documentation/serial/tty_rpmsg.rst b/Documentation/serial/tty_rpmsg.rst >> new file mode 100644 >> index 000000000000..fc1d3fba73c5 >> --- /dev/null >> +++ b/Documentation/serial/tty_rpmsg.rst >> @@ -0,0 +1,45 @@ >> +.. SPDX-License-Identifier: GPL-2.0 >> + >> +============= >> +The rpmsg TTY >> +============= >> + >> +The rpmsg tty driver implements serial communication on the RPMsg bus to makes possible for user-space programs to send and receive rpmsg messages as a standard tty protocol. > > Can you wrap your lines properly for this file? My apologize for this, I've been relying a little too much on the checkpatch tool here. Thanks for the review, Arnaud > > thanks, > > greg k-h >