From: Jiri Slaby <jslaby@suse.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Suman Anna <s-anna@ti.com>,
Fabien DESSENNE <fabien.dessenne@st.com>,
linux-stm32@st-md-mailman.stormreply.com,
Alan Cox <gnomes@lxorguk.ukuu.org.uk>,
xiang xiao <xiaoxiang781216@gmail.com>
Subject: Re: [PATCH v7 2/2] tty: add rpmsg driver
Date: Wed, 25 Mar 2020 09:10:24 +0100 [thread overview]
Message-ID: <4784b95f-0023-5250-ba9e-23b70b66611c@suse.com> (raw)
In-Reply-To: <8821448b-3c6e-6277-06d2-9be7f81de9e9@infradead.org>
Hi,
On 24. 03. 20, 18:44, Randy Dunlap wrote:
>> + could be lost.
>> +- It can pause/resume reception by sending a control message (rely on CTS state).
>> +
>> +Control message structure:
>> +struct rpmsg_tty_ctrl {
>> + u8 cts; /* remote reception status */
>> + u16 d_ept_addr; /* data endpoint address */
>> +};
>
> Is that struct packed or padded?
As it seems, this documentation is in contradiction with code, anyway:
+struct rpmsg_tty_ctrl {
+ u16 d_ept_addr; /* data endpoint address */
+ u8 cts; /* remote reception status */
+} __packed;
thanks,
--
js
suse labs
next prev parent reply other threads:[~2020-03-25 8:10 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:04 [PATCH v7 0/2] Add rpmsg tty driver Arnaud Pouliquen
2020-03-24 17:04 ` [PATCH v7 1/2] rpmsg: core: add API to get MTU Arnaud Pouliquen
2020-03-31 17:36 ` Mathieu Poirier
2020-04-01 6:28 ` Jiri Slaby
2020-04-01 6:29 ` Jiri Slaby
2020-04-01 11:34 ` Arnaud POULIQUEN
2020-03-24 17:04 ` [PATCH v7 2/2] tty: add rpmsg driver Arnaud Pouliquen
2020-03-24 17:18 ` Greg Kroah-Hartman
2020-03-25 11:34 ` Arnaud POULIQUEN
2020-03-24 17:23 ` Joe Perches
2020-03-25 11:36 ` Arnaud POULIQUEN
2020-03-24 17:44 ` Randy Dunlap
2020-03-25 8:10 ` Jiri Slaby [this message]
2020-03-25 11:39 ` Arnaud POULIQUEN
2020-03-24 20:52 ` Bjorn Andersson
2020-03-25 16:57 ` Arnaud POULIQUEN
2020-04-06 14:18 ` Arnaud POULIQUEN
2020-04-06 14:18 ` Arnaud POULIQUEN
2020-05-06 2:54 ` Bjorn Andersson
2020-05-06 10:21 ` Arnaud POULIQUEN
2020-03-25 8:45 ` Jiri Slaby
2020-03-25 13:15 ` Arnaud POULIQUEN
2020-03-25 13:31 ` Jiri Slaby
2020-03-26 0:01 ` Joe Perches
2020-03-26 6:38 ` Jiri Slaby
2020-03-26 10:59 ` Arnaud POULIQUEN
2020-03-26 12:31 ` Jiri Slaby
2020-03-26 11:40 ` Arnaud POULIQUEN
2020-03-26 11:45 ` Jiri Slaby
2020-04-01 18:06 ` Mathieu Poirier
2020-04-02 15:25 ` Arnaud POULIQUEN
2020-04-03 20:18 ` Mathieu Poirier
2020-07-15 16:06 ` [PATCH v7 0/2] Add rpmsg tty driver Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4784b95f-0023-5250-ba9e-23b70b66611c@suse.com \
--to=jslaby@suse.com \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=rdunlap@infradead.org \
--cc=s-anna@ti.com \
--cc=xiaoxiang781216@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).