From: Dan Carpenter <error27@gmail.com>
To: Yu Zhe <yuzhe@nfschina.com>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
agross@kernel.org, konrad.dybcio@linaro.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
kernel-janitors@vger.kernel.org, liqiong@nfschina.com
Subject: Re: [PATCH v3] remoteproc: remove unnecessary (void*) conversions
Date: Tue, 28 Mar 2023 10:40:04 +0300 [thread overview]
Message-ID: <4b64c2ed-b3a3-46fc-b5c7-3c03b30cd8a2@kili.mountain> (raw)
In-Reply-To: <20230328015749.1608-1-yuzhe@nfschina.com>
On Tue, Mar 28, 2023 at 09:57:49AM +0800, Yu Zhe wrote:
> static void devm_rproc_free(struct device *dev, void *res)
> {
> - rproc_free(*(struct rproc **)res);
> + rproc_free(res);
This introduces a bug.
regards,
dan carpenter
prev parent reply other threads:[~2023-03-28 7:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 9:19 [PATCH] remoteproc: qcom_q6v5_mss: remove unnecessary (void*) conversions Yu Zhe
2023-03-16 10:34 ` Mukesh Ojha
2023-03-20 6:11 ` [PATCH v2] remoteproc: " Yu Zhe
2023-03-20 11:51 ` kernel test robot
2023-03-26 11:14 ` kernel test robot
2023-03-27 14:46 ` kernel test robot
2023-03-28 1:57 ` [PATCH v3] " Yu Zhe
2023-03-28 2:49 ` [PATCH v4] " Yu Zhe
2023-03-28 7:42 ` Dan Carpenter
2023-03-29 17:46 ` Mathieu Poirier
2023-03-28 7:40 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b64c2ed-b3a3-46fc-b5c7-3c03b30cd8a2@kili.mountain \
--to=error27@gmail.com \
--cc=agross@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=liqiong@nfschina.com \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=yuzhe@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).