From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dylan Van Assche <me@dylanvanassche.be>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] remoteproc: qcom: pas: add SDM845 SLPI resource
Date: Tue, 28 Mar 2023 10:26:51 +0200 [thread overview]
Message-ID: <5a835e27-cc9e-d04c-a1ec-2756b0476d98@linaro.org> (raw)
In-Reply-To: <20230327183736.496170-3-me@dylanvanassche.be>
On 27.03.2023 20:37, Dylan Van Assche wrote:
> Add SLPI resources for the SDM845 Qualcomm SoC to the Qualcomm
> remoteproc q6v5_pas driver to define the default firmware name
> and GLink edge name.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
> drivers/remoteproc/qcom_q6v5_pas.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index c99a20542685..d82b6f4bced4 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -1028,6 +1028,22 @@ static const struct adsp_data slpi_resource_init = {
> .ssctl_id = 0x16,
> };
>
> +static const struct adsp_data sdm845_slpi_resource = {
> + .crash_reason_smem = 424,
> + .firmware_name = "slpi.mdt",
> + .pas_id = 12,
> + .auto_boot = true,
> + .proxy_pd_names = (char*[]){
> + "lcx",
> + "lmx",
> + NULL
> + },
> + .load_state = "slpi",
> + .ssr_name = "dsps",
> + .sysmon_name = "slpi",
> + .ssctl_id = 0x16,
> +};
Not sure why you're adding this just to remove it in the next
patch. You can just assign a different one here and then clean
it up for all others.
Konrad
> +
> static const struct adsp_data sm8150_slpi_resource = {
> .crash_reason_smem = 424,
> .firmware_name = "slpi.mdt",
> @@ -1201,6 +1217,7 @@ static const struct of_device_id adsp_of_match[] = {
> { .compatible = "qcom,sdm660-adsp-pas", .data = &adsp_resource_init},
> { .compatible = "qcom,sdm845-adsp-pas", .data = &sdm845_adsp_resource_init},
> { .compatible = "qcom,sdm845-cdsp-pas", .data = &sdm845_cdsp_resource_init},
> + { .compatible = "qcom,sdm845-slpi-pas", .data = &sdm845_slpi_resource},
> { .compatible = "qcom,sdx55-mpss-pas", .data = &sdx55_mpss_resource},
> { .compatible = "qcom,sm6115-adsp-pas", .data = &adsp_resource_init},
> { .compatible = "qcom,sm6115-cdsp-pas", .data = &cdsp_resource_init},
next prev parent reply other threads:[~2023-03-28 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 18:37 [PATCH v2 0/3] remoteproc: qcom: pas: Support SDM845 SLPI Dylan Van Assche
2023-03-27 18:37 ` [PATCH v2 1/3] dt-bindings: remoteproc: qcom: adsp: add qcom,sdm845-slpi-pas compatible Dylan Van Assche
2023-03-28 6:40 ` Krzysztof Kozlowski
2023-03-27 18:37 ` [PATCH v2 2/3] remoteproc: qcom: pas: add SDM845 SLPI resource Dylan Van Assche
2023-03-28 8:26 ` Konrad Dybcio [this message]
2023-03-27 18:37 ` [PATCH v2 3/3] remoteproc: qcom: pas: refactor SLPI remoteproc init Dylan Van Assche
2023-03-28 6:41 ` Krzysztof Kozlowski
2023-03-28 8:26 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a835e27-cc9e-d04c-a1ec-2756b0476d98@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=me@dylanvanassche.be \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).