* [PATCH] remoteproc: stm32: fix phys_addr_t format string
@ 2021-04-21 14:00 Arnd Bergmann
2021-04-22 10:22 ` Arnaud POULIQUEN
2021-05-31 14:50 ` patchwork-bot+linux-remoteproc
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2021-04-21 14:00 UTC (permalink / raw)
To: Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier,
Maxime Coquelin, Alexandre Torgue, Arnaud Pouliquen
Cc: Arnd Bergmann, Arnaud Pouliquen, linux-remoteproc, linux-stm32,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A phys_addr_t may be wider than an int or pointer:
drivers/remoteproc/stm32_rproc.c: In function 'stm32_rproc_da_to_pa':
drivers/remoteproc/stm32_rproc.c:583:30: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'phys_addr_t' {aka 'long long unsigned int'} [-Werror=format=]
583 | dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
Print it by reference using the special %pap format string.
Fixes: 8a471396d21c ("remoteproc: stm32: Move resource table setup to rproc_ops")
igned-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/remoteproc/stm32_rproc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
index 7353f9e7e7af..32595c950569 100644
--- a/drivers/remoteproc/stm32_rproc.c
+++ b/drivers/remoteproc/stm32_rproc.c
@@ -580,7 +580,7 @@ static int stm32_rproc_da_to_pa(struct rproc *rproc,
continue;
*pa = da - p_mem->dev_addr + p_mem->bus_addr;
- dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
+ dev_dbg(dev, "da %llx to pa %pap\n", da, pa);
return 0;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: stm32: fix phys_addr_t format string
2021-04-21 14:00 [PATCH] remoteproc: stm32: fix phys_addr_t format string Arnd Bergmann
@ 2021-04-22 10:22 ` Arnaud POULIQUEN
2021-05-31 14:50 ` patchwork-bot+linux-remoteproc
1 sibling, 0 replies; 3+ messages in thread
From: Arnaud POULIQUEN @ 2021-04-22 10:22 UTC (permalink / raw)
To: Arnd Bergmann, Ohad Ben-Cohen, Bjorn Andersson, Mathieu Poirier,
Maxime Coquelin, Alexandre Torgue, Arnaud Pouliquen
Cc: Arnd Bergmann, linux-remoteproc, linux-stm32, linux-arm-kernel,
linux-kernel
Hello Arnd,
On 4/21/21 4:00 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A phys_addr_t may be wider than an int or pointer:
>
> drivers/remoteproc/stm32_rproc.c: In function 'stm32_rproc_da_to_pa':
> drivers/remoteproc/stm32_rproc.c:583:30: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'phys_addr_t' {aka 'long long unsigned int'} [-Werror=format=]
> 583 | dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
>
> Print it by reference using the special %pap format string.
>
> Fixes: 8a471396d21c ("remoteproc: stm32: Move resource table setup to rproc_ops")
> igned-off-by: Arnd Bergmann <arnd@arndb.de>
It seems that the 'S' has disappeared during the copy/past :)
It's strange that no bot has made a report...
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Thanks for the fix!
Arnaud
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 7353f9e7e7af..32595c950569 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -580,7 +580,7 @@ static int stm32_rproc_da_to_pa(struct rproc *rproc,
> continue;
>
> *pa = da - p_mem->dev_addr + p_mem->bus_addr;
> - dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
> + dev_dbg(dev, "da %llx to pa %pap\n", da, pa);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] remoteproc: stm32: fix phys_addr_t format string
2021-04-21 14:00 [PATCH] remoteproc: stm32: fix phys_addr_t format string Arnd Bergmann
2021-04-22 10:22 ` Arnaud POULIQUEN
@ 2021-05-31 14:50 ` patchwork-bot+linux-remoteproc
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-remoteproc @ 2021-05-31 14:50 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: linux-remoteproc
Hello:
This patch was applied to andersson/remoteproc.git (refs/heads/for-next):
On Wed, 21 Apr 2021 16:00:40 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A phys_addr_t may be wider than an int or pointer:
>
> drivers/remoteproc/stm32_rproc.c: In function 'stm32_rproc_da_to_pa':
> drivers/remoteproc/stm32_rproc.c:583:30: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'phys_addr_t' {aka 'long long unsigned int'} [-Werror=format=]
> 583 | dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
>
> [...]
Here is the summary with links:
- remoteproc: stm32: fix phys_addr_t format string
https://git.kernel.org/andersson/remoteproc/c/3e25e407a1c9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-31 15:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 14:00 [PATCH] remoteproc: stm32: fix phys_addr_t format string Arnd Bergmann
2021-04-22 10:22 ` Arnaud POULIQUEN
2021-05-31 14:50 ` patchwork-bot+linux-remoteproc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).