* [PATCH] remoteproc: wcss: Fix function call for new API
@ 2020-05-18 21:08 Valdis Klētnieks
[not found] ` <77864.1589836457@turing-police>
0 siblings, 1 reply; 2+ messages in thread
From: Valdis Klētnieks @ 2020-05-18 21:08 UTC (permalink / raw)
To: Sivaprakash Murugesan, Andy Gross, Bjorn Andersson,
Ohad Ben-Cohen, Philipp Zabel
Cc: linux-arm-msm, linux-remoteproc, linux-kernel
commit 8a226e2c71: remoteproc: wcss: add support for rpmsg communication
throws a compile error:
CC [M] drivers/remoteproc/qcom_q6v5_wcss.o
drivers/remoteproc/qcom_q6v5_wcss.c: In function 'q6v5_wcss_probe':
drivers/remoteproc/qcom_q6v5_wcss.c:563:2: error: too few arguments to function 'qcom_add_glink_subdev'
qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/remoteproc/qcom_q6v5_wcss.c:16:
drivers/remoteproc/qcom_common.h:35:6: note: declared here
void qcom_add_glink_subdev(struct rproc *rproc, struct qcom_rproc_glink *glink,
^~~~~~~~~~~~~~~~~~~~~
Update to API change from commit cd9fc8f: remoteproc: qcom: Pass ssr_name to glink subdevice
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
diff --git a/drivers/remoteproc/qcom_q6v5_wcss.c b/drivers/remoteproc/qcom_q6v5_wcss.c
index 48d16d81f94d..99ecc0e6276e 100644
--- a/drivers/remoteproc/qcom_q6v5_wcss.c
+++ b/drivers/remoteproc/qcom_q6v5_wcss.c
@@ -560,7 +560,7 @@ static int q6v5_wcss_probe(struct platform_device *pdev)
if (ret)
goto free_rproc;
- qcom_add_glink_subdev(rproc, &wcss->glink_subdev);
+ qcom_add_glink_subdev(rproc, &wcss->glink_subdev,"q6wcss");
qcom_add_ssr_subdev(rproc, &wcss->ssr_subdev, "q6wcss");
ret = rproc_add(rproc);
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-18 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 21:08 [PATCH] remoteproc: wcss: Fix function call for new API Valdis Klētnieks
[not found] ` <77864.1589836457@turing-police>
2020-05-18 22:26 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).