From: Sibi Sankar <sibis@codeaurora.org>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
sibis@codearora.org, tsoni@codeaurora.org,
psodagud@codeaurora.org, sidgup@codeaurora.org,
linux-remoteproc-owner@vger.kernel.org
Subject: Re: [PATCH v8 3/5] remoteproc: Pass size and offset as arguments to segment dump function
Date: Fri, 17 Jul 2020 16:35:16 +0530 [thread overview]
Message-ID: <93a9dea3f4ee6dcb815530efec8afe92@codeaurora.org> (raw)
In-Reply-To: <1594938035-7327-4-git-send-email-rishabhb@codeaurora.org>
On 2020-07-17 03:50, Rishabh Bhatnagar wrote:
> Change the segment dump API signature to include size and offset
> arguments. Refactor the qcom_q6v5_mss driver to use these
> arguments while copying the segment. Doing this lays the ground
> work for "inline" coredump functionality being added in the next
> patch.
>
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Tested-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 10 +++++-----
> drivers/remoteproc/remoteproc_coredump.c | 5 +++--
> include/linux/remoteproc.h | 5 +++--
> 3 files changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c
> b/drivers/remoteproc/qcom_q6v5_mss.c
> index 037cd45..6baa3ae 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -1199,7 +1199,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc)
>
> static void qcom_q6v5_dump_segment(struct rproc *rproc,
> struct rproc_dump_segment *segment,
> - void *dest)
> + void *dest, size_t cp_offset, size_t size)
> {
> int ret = 0;
> struct q6v5 *qproc = rproc->priv;
> @@ -1219,16 +1219,16 @@ static void qcom_q6v5_dump_segment(struct rproc
> *rproc,
> }
>
> if (!ret)
> - ptr = ioremap_wc(qproc->mpss_phys + offset, segment->size);
> + ptr = ioremap_wc(qproc->mpss_phys + offset + cp_offset, size);
>
> if (ptr) {
> - memcpy(dest, ptr, segment->size);
> + memcpy(dest, ptr, size);
> iounmap(ptr);
> } else {
> - memset(dest, 0xff, segment->size);
> + memset(dest, 0xff, size);
> }
>
> - qproc->current_dump_size += segment->size;
> + qproc->current_dump_size += size;
>
> /* Reclaim mba after copying segments */
> if (qproc->current_dump_size == qproc->total_dump_size) {
> diff --git a/drivers/remoteproc/remoteproc_coredump.c
> b/drivers/remoteproc/remoteproc_coredump.c
> index ded0244..390f563 100644
> --- a/drivers/remoteproc/remoteproc_coredump.c
> +++ b/drivers/remoteproc/remoteproc_coredump.c
> @@ -72,7 +72,8 @@ int rproc_coredump_add_custom_segment(struct rproc
> *rproc,
> dma_addr_t da, size_t size,
> void (*dumpfn)(struct rproc *rproc,
> struct rproc_dump_segment *segment,
> - void *dest),
> + void *dest, size_t offset,
> + size_t size),
> void *priv)
> {
> struct rproc_dump_segment *segment;
> @@ -183,7 +184,7 @@ void rproc_coredump(struct rproc *rproc)
> elf_phdr_set_p_align(class, phdr, 0);
>
> if (segment->dump) {
> - segment->dump(rproc, segment, data + offset);
> + segment->dump(rproc, segment, data + offset, 0, segment->size);
> } else {
> ptr = rproc_da_to_va(rproc, segment->da, segment->size);
> if (!ptr) {
> diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
> index e7b7bab..eb08139 100644
> --- a/include/linux/remoteproc.h
> +++ b/include/linux/remoteproc.h
> @@ -451,7 +451,7 @@ struct rproc_dump_segment {
>
> void *priv;
> void (*dump)(struct rproc *rproc, struct rproc_dump_segment *segment,
> - void *dest);
> + void *dest, size_t offset, size_t size);
> loff_t offset;
> };
>
> @@ -630,7 +630,8 @@ int rproc_coredump_add_custom_segment(struct rproc
> *rproc,
> dma_addr_t da, size_t size,
> void (*dumpfn)(struct rproc *rproc,
> struct rproc_dump_segment *segment,
> - void *dest),
> + void *dest, size_t offset,
> + size_t size),
> void *priv);
> int rproc_coredump_set_elf_info(struct rproc *rproc, u8 class, u16
> machine);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-07-17 11:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 22:20 [PATCH v8 0/5] Extend coredump functionality Rishabh Bhatnagar
2020-07-16 22:20 ` [PATCH v8 1/5] remoteproc: Move coredump functionality to a new file Rishabh Bhatnagar
2020-07-16 22:20 ` [PATCH v8 2/5] remoteproc: qcom_q6v5_mss: Replace mask based tracking with size Rishabh Bhatnagar
2020-07-17 5:01 ` Bjorn Andersson
2020-07-16 22:20 ` [PATCH v8 3/5] remoteproc: Pass size and offset as arguments to segment dump function Rishabh Bhatnagar
2020-07-17 5:03 ` Bjorn Andersson
2020-07-17 11:05 ` Sibi Sankar [this message]
2020-07-20 16:59 ` Mathieu Poirier
2020-07-16 22:20 ` [PATCH v8 4/5] remoteproc: Add inline coredump functionality Rishabh Bhatnagar
2020-07-17 5:13 ` Bjorn Andersson
2020-07-17 11:03 ` Sibi Sankar
2020-07-20 17:07 ` Mathieu Poirier
2020-07-16 22:20 ` [PATCH v8 5/5] remoteproc: Add coredump debugfs entry Rishabh Bhatnagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a9dea3f4ee6dcb815530efec8afe92@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc-owner@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sibis@codearora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).