From: Baolin Wang <baolin.wang7@gmail.com>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-remoteproc@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
kernel@collabora.com
Subject: Re: [PATCH] hwspinlock: Simplify Kconfig
Date: Wed, 15 Apr 2020 21:32:52 +0800 [thread overview]
Message-ID: <CADBw62oJj_x046piRbPP48A04ALo-w2J6jZXNspyN5eOGj-TEg@mail.gmail.com> (raw)
In-Reply-To: <20200414220943.6203-1-ezequiel@collabora.com>
Hi Ezequiel,
On Wed, Apr 15, 2020 at 6:09 AM Ezequiel Garcia <ezequiel@collabora.com> wrote:
>
> Every hwspinlock driver is expected to depend on the
> hwspinlock core, so it's possible to simplify the
> Kconfig, factoring out the HWSPINLOCK dependency.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
Looks reasonable to me.
Reviewed-by: Baolin Wang <baolin.wang7@gmail.com>
> ---
> drivers/hwspinlock/Kconfig | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwspinlock/Kconfig b/drivers/hwspinlock/Kconfig
> index 826a1054100d..32cd26352f38 100644
> --- a/drivers/hwspinlock/Kconfig
> +++ b/drivers/hwspinlock/Kconfig
> @@ -6,9 +6,10 @@
> menuconfig HWSPINLOCK
> bool "Hardware Spinlock drivers"
>
> +if HWSPINLOCK
> +
> config HWSPINLOCK_OMAP
> tristate "OMAP Hardware Spinlock device"
> - depends on HWSPINLOCK
> depends on ARCH_OMAP4 || SOC_OMAP5 || SOC_DRA7XX || SOC_AM33XX || SOC_AM43XX || ARCH_K3 || COMPILE_TEST
> help
> Say y here to support the OMAP Hardware Spinlock device (firstly
> @@ -18,7 +19,6 @@ config HWSPINLOCK_OMAP
>
> config HWSPINLOCK_QCOM
> tristate "Qualcomm Hardware Spinlock device"
> - depends on HWSPINLOCK
> depends on ARCH_QCOM || COMPILE_TEST
> select MFD_SYSCON
> help
> @@ -30,7 +30,6 @@ config HWSPINLOCK_QCOM
>
> config HWSPINLOCK_SIRF
> tristate "SIRF Hardware Spinlock device"
> - depends on HWSPINLOCK
> depends on ARCH_SIRF || COMPILE_TEST
> help
> Say y here to support the SIRF Hardware Spinlock device, which
> @@ -43,7 +42,6 @@ config HWSPINLOCK_SIRF
> config HWSPINLOCK_SPRD
> tristate "SPRD Hardware Spinlock device"
> depends on ARCH_SPRD || COMPILE_TEST
> - depends on HWSPINLOCK
> help
> Say y here to support the SPRD Hardware Spinlock device.
>
> @@ -52,7 +50,6 @@ config HWSPINLOCK_SPRD
> config HWSPINLOCK_STM32
> tristate "STM32 Hardware Spinlock device"
> depends on MACH_STM32MP157 || COMPILE_TEST
> - depends on HWSPINLOCK
> help
> Say y here to support the STM32 Hardware Spinlock device.
>
> @@ -60,7 +57,6 @@ config HWSPINLOCK_STM32
>
> config HSEM_U8500
> tristate "STE Hardware Semaphore functionality"
> - depends on HWSPINLOCK
> depends on ARCH_U8500 || COMPILE_TEST
> help
> Say y here to support the STE Hardware Semaphore functionality, which
> @@ -68,3 +64,5 @@ config HSEM_U8500
> SoC.
>
> If unsure, say N.
> +
> +endif # HWSPINLOCK
> --
> 2.26.0.rc2
>
--
Baolin Wang
next prev parent reply other threads:[~2020-04-15 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 22:09 [PATCH] hwspinlock: Simplify Kconfig Ezequiel Garcia
2020-04-14 22:09 ` Ezequiel Garcia
2020-04-15 13:32 ` Baolin Wang [this message]
2020-04-15 13:32 ` Baolin Wang
2020-05-07 2:39 ` Ezequiel Garcia
2020-05-12 23:24 ` Bjorn Andersson
2020-05-13 6:20 ` patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADBw62oJj_x046piRbPP48A04ALo-w2J6jZXNspyN5eOGj-TEg@mail.gmail.com \
--to=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=ezequiel@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).