From: Stephen Boyd <swboyd@chromium.org>
To: Deepak Kumar Singh <deesin@codeaurora.org>,
bjorn.andersson@linaro.org, clew@codeaurora.org,
sibis@codeaurora.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, Andy Gross <agross@kernel.org>
Subject: Re: [PATCH V5 1/2] soc: qcom: aoss: Expose send for generic usecase
Date: Mon, 9 Aug 2021 10:56:55 -0700 [thread overview]
Message-ID: <CAE-0n53cxsMMsJg3dpnTi+AwKiZKxG=xy4jBKX=FDKMzHc3y1Q@mail.gmail.com> (raw)
In-Reply-To: <4b3b6b0f-8c21-53ce-4341-1e8686d3b73c@codeaurora.org>
Quoting Deepak Kumar Singh (2021-08-09 02:57:26)
>
> On 8/6/2021 12:04 AM, Stephen Boyd wrote:
> > Quoting Deepak Kumar Singh (2021-08-05 04:12:53)
> >> diff --git a/drivers/soc/qcom/qcom_aoss.c b/drivers/soc/qcom/qcom_aoss.c
> >> index 934fcc4..b84cb31 100644
> >> --- a/drivers/soc/qcom/qcom_aoss.c
> >> +++ b/drivers/soc/qcom/qcom_aoss.c
> >> @@ -515,6 +521,43 @@ static void qmp_cooling_devices_remove(struct qmp *qmp)
> >> thermal_cooling_device_unregister(qmp->cooling_devs[i].cdev);
> >> }
> >>
> >> +/**
> >> + * qmp_get() - get a qmp handle from a device
> >> + * @dev: client device pointer
> >> + *
> >> + * Return: handle to qmp device on success, ERR_PTR() on failure
> >> + */
> >> +struct qmp *qmp_get(struct device *dev)
> >> +{
> >> + struct platform_device *pdev;
> >> + struct device_node *np;
> >> + struct qmp *qmp;
> >> +
> >> + if (!dev || !dev->of_node)
> >> + return ERR_PTR(-EINVAL);
> >> +
> >> + np = of_parse_phandle(dev->of_node, "qcom,qmp", 0);
> >> + if (!np)
> >> + return ERR_PTR(-ENODEV);
> >> +
> >> + pdev = of_find_device_by_node(np);
> >> + of_node_put(np);
> >> + if (!pdev)
> >> + return ERR_PTR(-EINVAL);
> >> +
> >> + qmp = platform_get_drvdata(pdev);
> >> +
> >> + return qmp ? qmp : ERR_PTR(-EPROBE_DEFER);
> >> +}
> >> +EXPORT_SYMBOL(qmp_get);
> >> +
> >> +void qmp_put(struct qmp *qmp)
> >> +{
> >> + if (!IS_ERR_OR_NULL(qmp))
> >> + put_device(qmp->dev);
> > Where is the corresponding get_device() call?
> of_find_device_by_node() internally calls get_device(), so no need to
> call get_device() explicitly.
Got it. Can you add a comment here so we remember?
/*
* Match get_device() inside of_find_device_by_node() in
* qmp_get()
*/
and it would be super useful if we could update the documentation on
that API, and the one it calls, so callers know about this.
next prev parent reply other threads:[~2021-08-09 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 11:12 [PATCH V5 0/2] qcom aoss qmp_get and debugfs support patches Deepak Kumar Singh
2021-08-05 11:12 ` [PATCH V5 1/2] soc: qcom: aoss: Expose send for generic usecase Deepak Kumar Singh
2021-08-05 18:34 ` Stephen Boyd
2021-08-09 9:57 ` Deepak Kumar Singh
2021-08-09 17:56 ` Stephen Boyd [this message]
2021-08-05 11:12 ` [PATCH V5 2/2] soc: qcom: aoss: Add debugfs entry Deepak Kumar Singh
2021-08-05 18:28 ` Stephen Boyd
2021-08-30 11:46 ` Deepak Kumar Singh
2021-08-30 23:01 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n53cxsMMsJg3dpnTi+AwKiZKxG=xy4jBKX=FDKMzHc3y1Q@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=deesin@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).