From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B9FCC433E1 for ; Tue, 4 Aug 2020 19:30:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 866532076E for ; Tue, 4 Aug 2020 19:30:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WpvTZtuB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727077AbgHDTap (ORCPT ); Tue, 4 Aug 2020 15:30:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727064AbgHDTao (ORCPT ); Tue, 4 Aug 2020 15:30:44 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A21C3C061756 for ; Tue, 4 Aug 2020 12:30:44 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id k23so43393019iom.10 for ; Tue, 04 Aug 2020 12:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TH73Zs5fTt6lUTuR4sPJqLcMpqOz88yMBN6BKWQQy/A=; b=WpvTZtuBfEGOJOm3847waxD858IWsSQ2bPwHEf/Td8uLA1TgyFe/fXJZm77duojPZf k3DFhifFTC3YMHZoP1YUmaEqSXXIRUbTZbXFcyrgO7IECDtiqo499RXv9IKtMoPN3RCY XL81rv1i0SExMo4EDObAStEuAgolWUb2R6bzjm3t1kmicA0SFSSGbw/CsTHKg/4skY+F HKMGokFBdtQZ0HIEwv8YdiSQXDliPAJjR+IC/mnsOvZMwlm658fTsyyFBPAObdi5u51n 8DN28Ah/3fauwF5wZ5sBg6trqz75KJWRYJ6Y1ACtUGF9X8xOOpqHJgNP+j0EWKFfSNlM HrWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TH73Zs5fTt6lUTuR4sPJqLcMpqOz88yMBN6BKWQQy/A=; b=dp4obs7HRHLk2Ohg3NgSTw39ev7PvsjIje+wrThVanrMfQjC+P76BIF36+IstnzLzE iexgPib97IFYUwbT14gAjirLRZ4vpK9fFcmeaI6mL5e/QuhGyXPMhM3O/eKpx74mdYB3 5QXLu0XWmDo2w/aDrXRMpuYpKu8UN0VIvJP2xorFUDM85A4ZdUz3TXGq4b9Ff9qwoNED 2GWvBMIgV3alaN98hdrnXnjPTE/49anvJNPN+YPV+YobXt5kjMvkYF6hz3PpmZxouoC5 0mzuDd7D/6CDCyWtkGFpVgJGsKUiD9gAQEQhtytjyl6nW55pU4QkhudRsUms9AmS0jun MFig== X-Gm-Message-State: AOAM531Ff8amnpj8A6VsTzgf1LxcL3+URqRDgQoKtzGRGpO+Q4CMY87c 6fMCBpE+UyXQGKtlRPufaFAqL/dkqxemLushboMKedJI X-Google-Smtp-Source: ABdhPJyj3bm1UhhYOwzX6GHut7QFOJCm/8pB+sq342eCfuEnXKhWHKNFV01sPPsRCp/NdT/XabIi2Y/NroOAT2hbQXU= X-Received: by 2002:a05:6638:d95:: with SMTP id l21mr7395826jaj.98.1596569443567; Tue, 04 Aug 2020 12:30:43 -0700 (PDT) MIME-Version: 1.0 References: <20200722150927.15587-1-guennadi.liakhovetski@linux.intel.com> <20200730120805-mutt-send-email-mst@kernel.org> <20200731054752.GA28005@ubuntu> <20200803164605-mutt-send-email-mst@kernel.org> <20200804100640-mutt-send-email-mst@kernel.org> In-Reply-To: <20200804100640-mutt-send-email-mst@kernel.org> From: Mathieu Poirier Date: Tue, 4 Aug 2020 13:30:32 -0600 Message-ID: Subject: Re: [PATCH v4 0/4] Add a vhost RPMsg API To: "Michael S. Tsirkin" Cc: Guennadi Liakhovetski , kvm@vger.kernel.org, linux-remoteproc , virtualization@lists.linux-foundation.org, sound-open-firmware@alsa-project.org, Pierre-Louis Bossart , Liam Girdwood , Jason Wang , Ohad Ben-Cohen , Bjorn Andersson , Vincent Whitchurch Content-Type: text/plain; charset="UTF-8" Sender: linux-remoteproc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, 4 Aug 2020 at 08:07, Michael S. Tsirkin wrote: > > On Tue, Aug 04, 2020 at 07:37:49AM -0600, Mathieu Poirier wrote: > > On Mon, 3 Aug 2020 at 14:47, Michael S. Tsirkin wrote: > > > > > > On Mon, Aug 03, 2020 at 07:25:24AM -0600, Mathieu Poirier wrote: > > > > On Thu, 30 Jul 2020 at 23:47, Guennadi Liakhovetski > > > > wrote: > > > > > > > > > > Hi Michael, > > > > > > > > > > On Thu, Jul 30, 2020 at 12:08:29PM -0400, Michael S. Tsirkin wrote: > > > > > > On Wed, Jul 22, 2020 at 05:09:23PM +0200, Guennadi Liakhovetski wrote: > > > > > > > Hi, > > > > > > > > > > > > > > Now that virtio-rpmsg endianness fixes have been merged we can > > > > > > > proceed with the next step. > > > > > > > > > > > > Which tree is this for? > > > > > > > > > > The essential part of this series is for drivers/vhost, so, I presume > > > > > that should be the target tree as well. There is however a small part > > > > > for the drivers/rpmsg, should I split this series in two or shall we > > > > > first review is as a whole to make its goals clearer? > > > > > > > > I suggest to keep it whole for now. > > > > > > > > > Ok can I get some acks please? > > > > Yes, as soon as I have the opportunity to review the work. There is a > > lot of volume on the linux-remoteproc mailing list lately and > > patchsets are reviewed in the order they have been received. > > Well the merge window is open, I guess I'll merge this and > any issues can be addressed later then? Please don't do that. I prefer to miss a merge window than impacting upstream consumers. This patch will be reviewed, just not in time for this merge window. > > > > Also, I put this in my linux-next branch on > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git > > > > > > there were some conflicts - could you pls test and report it's ok? > > > > > > > > > > > > > Thanks > > > > > Guennadi > > > > > > > > > > > > v4: > > > > > > > - add endianness conversions to comply with the VirtIO standard > > > > > > > > > > > > > > v3: > > > > > > > - address several checkpatch warnings > > > > > > > - address comments from Mathieu Poirier > > > > > > > > > > > > > > v2: > > > > > > > - update patch #5 with a correct vhost_dev_init() prototype > > > > > > > - drop patch #6 - it depends on a different patch, that is currently > > > > > > > an RFC > > > > > > > - address comments from Pierre-Louis Bossart: > > > > > > > * remove "default n" from Kconfig > > > > > > > > > > > > > > Linux supports RPMsg over VirtIO for "remote processor" / AMP use > > > > > > > cases. It can however also be used for virtualisation scenarios, > > > > > > > e.g. when using KVM to run Linux on both the host and the guests. > > > > > > > This patch set adds a wrapper API to facilitate writing vhost > > > > > > > drivers for such RPMsg-based solutions. The first use case is an > > > > > > > audio DSP virtualisation project, currently under development, ready > > > > > > > for review and submission, available at > > > > > > > https://github.com/thesofproject/linux/pull/1501/commits > > > > > > > > > > > > > > Thanks > > > > > > > Guennadi > > > > > > > > > > > > > > Guennadi Liakhovetski (4): > > > > > > > vhost: convert VHOST_VSOCK_SET_RUNNING to a generic ioctl > > > > > > > rpmsg: move common structures and defines to headers > > > > > > > rpmsg: update documentation > > > > > > > vhost: add an RPMsg API > > > > > > > > > > > > > > Documentation/rpmsg.txt | 6 +- > > > > > > > drivers/rpmsg/virtio_rpmsg_bus.c | 78 +------ > > > > > > > drivers/vhost/Kconfig | 7 + > > > > > > > drivers/vhost/Makefile | 3 + > > > > > > > drivers/vhost/rpmsg.c | 375 +++++++++++++++++++++++++++++++ > > > > > > > drivers/vhost/vhost_rpmsg.h | 74 ++++++ > > > > > > > include/linux/virtio_rpmsg.h | 83 +++++++ > > > > > > > include/uapi/linux/rpmsg.h | 3 + > > > > > > > include/uapi/linux/vhost.h | 4 +- > > > > > > > 9 files changed, 553 insertions(+), 80 deletions(-) > > > > > > > create mode 100644 drivers/vhost/rpmsg.c > > > > > > > create mode 100644 drivers/vhost/vhost_rpmsg.h > > > > > > > create mode 100644 include/linux/virtio_rpmsg.h > > > > > > > > > > > > > > -- > > > > > > > 2.27.0 > > > > > > > > > >