Linux-remoteproc Archive on lore.kernel.org
 help / color / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
	mathieu.poirier@linaro.org, robh+dt@kernel.org,
	ulf.hansson@linaro.org, rjw@rjwysocki.net, agross@kernel.org,
	ohad@wizery.com, linux-arm-msm@vger.kernel.org,
	linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, dianders@chromium.org,
	rishabhb@codeaurora.org, sidgup@codeaurora.org
Subject: Re: [PATCH 02/12] soc: qcom: aoss: Drop power domain support
Date: Thu, 27 May 2021 23:05:28 -0500
Message-ID: <YLBsCLNLBlWwoPQj@builder.lan> (raw)
In-Reply-To: <7adff8e58784bb85ea844ad338bfb19c@codeaurora.org>

On Tue 27 Apr 01:25 CDT 2021, Sibi Sankar wrote:

> On 2021-04-18 07:31, Stephen Boyd wrote:
> > Quoting Sibi Sankar (2021-04-16 05:03:48)
> > > The load state resources are expected to follow the life cycle of the
> > > remote processor it tracks. However, modeling load state resources as
> > > power-domains result in them getting turned off during system suspend
> > > and thereby falling out of sync with the remote processors that are
> > > still
> > > on. Fix this by replacing load state resource control through the
> > > generic
> > > qmp message send interface instead.
> > > 
> > > Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> > > ---
> > 
> > Is it possible to keep this code around for a cycle so that there isn't
> > the chance that someone is using the deprecated DT bindings with a new
> > kernel? I worry that ripping the code out will cause them angst.
> 
> deprecated bindings with a newer kernel
> shouldn't cause any problems since it is
> the driver changes that make AOSS PD
> mandatory or not. So the newer kernel will
> just use qmp_send and leave the PD unused.
> 

Maybe I'm missing something in your argument here, but I see two issues:
* The changes here requires that the new qcom,qmp property is defined,
  or the qcom_qmp_get() will be unable to find the qmp instance.
* Between patch 2 and 5 there's no load_state handling.

Perhaps we can carry the power-domain handling as a fallback i
qcom_qmp_get() fails, for a few releases?


Other than the ordering and backwards compatibility issue I think this
looks good. So can you please respin this based on the later revision of
the qmp patch? (And fix Rob's request on the commit message)

https://lore.kernel.org/linux-arm-msm/1620320818-2206-2-git-send-email-deesin@codeaurora.org/

Regards,
Bjorn

> > Certainly we have to keep the code in place until DT is updated, so this
> > patch should come last?
> 
> sure I don't mind, as long as it simplifies
> the merge process.
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project.

  reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 12:03 [PATCH 00/12] Use qmp_send to update co-processor load state Sibi Sankar
2021-04-16 12:03 ` [PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain bindings Sibi Sankar
2021-04-18  1:54   ` Stephen Boyd
2021-04-30 14:59   ` Rob Herring
2021-04-16 12:03 ` [PATCH 02/12] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-04-18  2:01   ` Stephen Boyd
2021-04-27  6:25     ` Sibi Sankar
2021-05-28  4:05       ` Bjorn Andersson [this message]
2021-06-02  3:56         ` Sibi Sankar
2021-04-16 12:03 ` [PATCH 03/12] dt-bindings: remoteproc: qcom: pas: Add QMP bindings Sibi Sankar
2021-04-18  1:55   ` Stephen Boyd
2021-04-30 15:02   ` Rob Herring
2021-04-16 12:03 ` [PATCH 04/12] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-04-18  1:55   ` Stephen Boyd
2021-04-30 15:02   ` Rob Herring
2021-04-16 12:03 ` [PATCH 05/12] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-04-16 12:03 ` [PATCH 06/12] arm64: dts: qcom: sc7180: Use QMP binding to control " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 07/12] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 08/12] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 09/12] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 10/12] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-04-18  2:03   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 11/12] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-04-18  2:03   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 12/12] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
2021-04-18  2:03   ` Stephen Boyd
2021-04-30 15:02   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLBsCLNLBlWwoPQj@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=agross@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=rishabhb@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=sibis@codeaurora.org \
    --cc=sidgup@codeaurora.org \
    --cc=swboyd@chromium.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-remoteproc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \
		linux-remoteproc@vger.kernel.org
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git