From: Stefano Stabellini <firstname.lastname@example.org> To: Rob Herring <email@example.com> Cc: Ben Levinsky <BLEVINSK@xilinx.com>, "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Michal Simek <firstname.lastname@example.org>, Jolly Shah <JOLLYS@xilinx.com>, Rajan Vaja <RAJANV@xilinx.com>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Stefano Stabellini <email@example.com> Subject: Re: [PATCH v4 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Date: Mon, 29 Jun 2020 17:37:12 -0700 (PDT) Message-ID: <alpine.DEB.2.21.2006291734370.8121@sstabellini-ThinkPad-T480s> (raw) In-Reply-To: <CAL_JsqLGo380SRYska+xGgJhgF8NCRvY56ewafvSCU6c-LmhZw@mail.gmail.com> On Wed, 10 Jun 2020, Rob Herring wrote: > On Tue, May 26, 2020 at 11:40 AM Ben Levinsky <BLEVINSK@xilinx.com> wrote: > > > > Hi Rob, > > > > The Xilinx R5 Remoteproc driver has been around for a long time -- admittedly we should have upstreamed it long ago. The driver in the current form is using an "classic" remoteproc device tree node as described here. > > I would rather not have 2 possible bindings to maintain. If there's > been no rush to upstream this til now, then it can wait longer. > > > > > I am working with Stefano to come up with an appropriate System Device Tree representation but it is not going to be ready right away. Our preference would be to upstream the remoteproc node and driver in their current forms while system device tree is maturing. > > There's obviously going to still need to be some sort of description > of the interface between cores, but this has parts that obviously > conflict with what's getting defined for system DT. The TCMs are the > most obvious. If you can remove (or hardcode in the driver) what > conflicts, then perhaps this can be upstreamed now. Hi Rob, Sorry it took a while to answer back but we wanted to do some research to make sure the reply is correct. The System Device Tree version of the OpenAMP remoteproc bindings aims at being simpler and vendor-neutral. As anything else System Device Tree, Lopper will read it and generate a "traditional" device tree with the existing remoteproc bindings. In that sense, it might not affect Linux directly. However, given the fragmentation of the remoteproc bindings across multiple vendors (they are all different), I think it is a good idea for Linux, for System Device Tree, and in general to come up with simpler remoteproc bindings, more aligned between the vendors. If nothing else, it is going to make Lopper's development easier. So I think it is a good idea to take this opportunity to simplify the Xilinx remoteproc bindings as you suggested. The idea of to removing the TCM nodes is a good one. In addition I asked Ben to have a look at whether the mboxes and mbox-names properties can be removed too. Ben will reply with a simplified bindings proposal.
next prev parent reply index Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-04-24 17:36 [PATCH v4 0/5] remoteproc: Add zynqmp_r5 driver Ben Levinsky 2020-04-24 17:36 ` [PATCH v4 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky 2020-04-24 17:36 ` [PATCH v4 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky 2020-04-24 17:36 ` [PATCH v4 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky 2020-04-24 17:36 ` [PATCH v4 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky 2020-05-11 22:17 ` Rob Herring 2020-05-26 17:40 ` Ben Levinsky 2020-06-10 20:38 ` Rob Herring 2020-06-30 0:37 ` Stefano Stabellini [this message] 2020-06-30 2:20 ` Bjorn Andersson 2020-06-30 15:38 ` Ben Levinsky 2020-06-30 17:11 ` Ben Levinsky 2020-04-24 17:36 ` [PATCH v4 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky 2020-05-05 20:53 ` Mathieu Poirier 2020-05-06 21:36 ` Mathieu Poirier 2020-05-07 22:08 ` Mathieu Poirier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.21.2006291734370.8121@sstabellini-ThinkPad-T480s \ --firstname.lastname@example.org \ --cc=BLEVINSK@xilinx.com \ --cc=JOLLYS@xilinx.com \ --cc=RAJANV@xilinx.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-remoteproc Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \ email@example.com public-inbox-index linux-remoteproc Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc AGPL code for this site: git clone https://public-inbox.org/public-inbox.git