From: Stefano Stabellini <stefano.stabellini@xilinx.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Ben Levinsky <ben.levinsky@xilinx.com>,
ohad@wizery.com, bjorn.andersson@linaro.org, michals@xilinx.com,
JOLLYS@xilinx.com, RAJANV@xilinx.com, robh+dt@kernel.org,
mark.rutland@arm.com, linux-remoteproc@vger.kernel.org,
linux-arm-kernell@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jliang@xilinx.com, stefanos@xilinx.com,
Wendy Liang <wendy.liang@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
Ed Mooring <ed.mooring@xilinx.com>, Jason Wu <j.wu@xilinx.com>
Subject: Re: [PATCH v6 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver
Date: Fri, 31 Jul 2020 16:03:37 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2007311104400.1767@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20200728210002.GA2413713@xps15>
On Tue, 28 Jul 2020, Mathieu Poirier wrote:
> On Wed, Jul 15, 2020 at 08:33:17AM -0700, Ben Levinsky wrote:
> > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this
> > remotproc driver, we can boot the R5 sub-system in different
> > configurations.
> >
> > Acked-by: Stefano Stabellini <stefano.stabellini@xilinx.com>
> > Acked-by: Ben Levinsky <ben.levinsky@xilinx.com>
> > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
> > Signed-off-by: Ben Levinsky <ben.levinsky@xilinx.com>
> > Signed-off-by: Wendy Liang <wendy.liang@xilinx.com>
> > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > Signed-off-by: Ed Mooring <ed.mooring@xilinx.com>
> > Signed-off-by: Jason Wu <j.wu@xilinx.com>
> > Tested-by: Ben Levinsky <ben.levinsky@xilinx.com>
[...]
> > +static int zynqmp_r5_remoteproc_probe(struct platform_device *pdev)
> > +{
> > + int ret, i = 0;
> > + u32 *lockstep_mode;
> > + struct device *dev = &pdev->dev;
> > + struct device_node *nc;
> > + struct zynqmp_r5_pdata *pdata;
> > +
> > + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> > + lockstep_mode = devm_kzalloc(dev, sizeof(u32 *), GFP_KERNEL);
> > + if (!pdata || !lockstep_mode)
> > + return -ENOMEM;
> > +
> > + platform_set_drvdata(pdev, pdata);
>
> As far as I can tell the above, along with allocating memory for @pdata, is not
> needed since zynqmp_r5_remoteproc_remove() uses rpus[].
>
> I have only reviewed the _probe() function and already encountered a fair amount
> of fundemantal errors. As such I will stop my review here. I will need to see a
> reviewed-by tag (on the mailing list) by Stephano or Michal before reviewing the
> next set.
Let me take this opportunity to say that my Acked-by on this version of
the series was an unintentional miscommunication: I didn't give my
Acked-by as I haven't even read the patches yet.
I'll circle back with Michal and we'll make sure for either of us to do
a round of public reviews on the next version.
prev parent reply other threads:[~2020-07-31 23:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 15:33 [PATCH v6 0/5] Provide basic driver to control Arm R5 co-processor found on Ben Levinsky
2020-07-15 15:33 ` [PATCH v6 1/5] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Ben Levinsky
2020-07-15 15:33 ` [PATCH v6 2/5] firmware: xilinx: Add shutdown/wakeup APIs Ben Levinsky
2020-07-15 15:33 ` [PATCH v6 3/5] firmware: xilinx: Add RPU configuration APIs Ben Levinsky
2020-07-15 15:33 ` [PATCH v6 4/5] dt-bindings: remoteproc: Add documentation for ZynqMP R5 rproc bindings Ben Levinsky
2020-07-15 15:33 ` [PATCH v6 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver Ben Levinsky
2020-07-27 22:59 ` Mathieu Poirier
2020-07-28 5:09 ` Michal Simek
2020-07-28 21:00 ` Mathieu Poirier
2020-07-31 23:03 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2007311104400.1767@sstabellini-ThinkPad-T480s \
--to=stefano.stabellini@xilinx.com \
--cc=JOLLYS@xilinx.com \
--cc=RAJANV@xilinx.com \
--cc=ben.levinsky@xilinx.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ed.mooring@xilinx.com \
--cc=j.wu@xilinx.com \
--cc=jliang@xilinx.com \
--cc=linux-arm-kernell@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@xilinx.com \
--cc=michals@xilinx.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=stefanos@xilinx.com \
--cc=wendy.liang@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).