From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBD2C433B4 for ; Thu, 22 Apr 2021 07:55:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B2806145E for ; Thu, 22 Apr 2021 07:55:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235245AbhDVH40 (ORCPT ); Thu, 22 Apr 2021 03:56:26 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:58946 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235216AbhDVH4Z (ORCPT ); Thu, 22 Apr 2021 03:56:25 -0400 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13M7pi6m028057; Thu, 22 Apr 2021 09:55:49 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=N4MWjyc0bM4LAtkX7Rna0gAk3kCIImrI9vNDz5vtYVg=; b=eaaclqUMCEachXBKXXgUbKyMx0jbR4LQahwEw9ROMpu943SEfCDsdrwP+UcjP1sHWccr LR2aF8FGuGIhOCBPn8oMT/8BecPWs2s5hTO7D6wxwnJCawxh7l/3lYZFHhdUzpHixGuU tSAGuFvY1pHi5I3xEyU1zuGJ3+hHp1RSxMdfM8dueimizG98+IKBY5O/P6ZVhp9PrSYN qrx4FLh0FAYF12g6rbXS/prXdXwRvbeIZ560b240kY3Pjs0UF0n+F4yfwZ4RpFGGdgA0 jsktdJ7qv+dUcUbbDLGSN5so24lT2hHhZNr3HCWTl/qoyiiImNVZpUUdDZGe72gIfW0v CQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 382bumqtkt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 22 Apr 2021 09:55:49 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id E2149100034; Thu, 22 Apr 2021 09:55:48 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id D069F21E67B; Thu, 22 Apr 2021 09:55:48 +0200 (CEST) Received: from lmecxl0889.lme.st.com (10.75.127.51) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Apr 2021 09:55:48 +0200 Subject: Re: [PATCH v2 1/7] rpmsg: char: Export eptdev create an destroy functions To: Mathieu Poirier CC: Bjorn Andersson , Ohad Ben-Cohen , , , References: <20210413134458.17912-1-arnaud.pouliquen@foss.st.com> <20210413134458.17912-2-arnaud.pouliquen@foss.st.com> <20210421175219.GD1223348@xps15> From: Arnaud POULIQUEN Message-ID: Date: Thu, 22 Apr 2021 09:55:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210421175219.GD1223348@xps15> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.51] X-ClientProxiedBy: SFHDAG2NODE3.st.com (10.75.127.6) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-04-22_01:2021-04-21,2021-04-21 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org hello Mathieu On 4/21/21 7:52 PM, Mathieu Poirier wrote: > On Tue, Apr 13, 2021 at 03:44:52PM +0200, Arnaud Pouliquen wrote: >> To prepare the split of the code related to the control (ctrldev) >> and the endpoint (eptdev) devices in 2 separate files: >> >> - Rename and export the functions in rpmsg_char.h. >> >> - Suppress the dependency with the rpmsg_ctrldev struct in the >> rpmsg_chrdev_create_eptdev function. >> >> - The rpmsg class is provided as parameter in rpmsg_chrdev_create_eptdev, >> because the class is associated to the control part. >> >> Suggested-by: Mathieu Poirier >> Signed-off-by: Arnaud Pouliquen >> --- >> drivers/rpmsg/rpmsg_char.c | 19 +++++++++------ >> drivers/rpmsg/rpmsg_char.h | 50 ++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 61 insertions(+), 8 deletions(-) >> create mode 100644 drivers/rpmsg/rpmsg_char.h >> >> diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c >> index 2bebc9b2d163..b9df8dc4365f 100644 >> --- a/drivers/rpmsg/rpmsg_char.c >> +++ b/drivers/rpmsg/rpmsg_char.c >> @@ -1,5 +1,6 @@ >> // SPDX-License-Identifier: GPL-2.0 >> /* >> + * Copyright (C) 2021, STMicroelectronics >> * Copyright (c) 2016, Linaro Ltd. >> * Copyright (c) 2012, Michal Simek >> * Copyright (c) 2012, PetaLogix >> @@ -22,6 +23,7 @@ >> #include >> #include >> >> +#include "rpmsg_char.h" >> #include "rpmsg_internal.h" >> >> #define RPMSG_DEV_MAX (MINORMASK + 1) >> @@ -78,7 +80,7 @@ struct rpmsg_eptdev { >> wait_queue_head_t readq; >> }; >> >> -static int rpmsg_eptdev_destroy(struct device *dev, void *data) >> +int rpmsg_chrdev_destroy_eptdev(struct device *dev, void *data) > > Shouldn't this be rpmsg_chrdev_eptdev_destroy()? I've been wondering about the > flipping of destroy and eptdev... The same for rpmsg_chrdev_create_eptdev(). As the function is exported i prefered to follow name srtructure that is commonly used: __ But it is not a rule, so please just tell me if you prefer that i rename the functions rpmsg_chrdev_eptdev_xxxx? Thanks, Arnaud > > With that: > > Reviewed-by: Mathieu Poirier > >> { >> struct rpmsg_eptdev *eptdev = dev_to_eptdev(dev); >> >> @@ -97,6 +99,7 @@ static int rpmsg_eptdev_destroy(struct device *dev, void *data) >> >> return 0; >> } >> +EXPORT_SYMBOL(rpmsg_chrdev_destroy_eptdev); >> >> static int rpmsg_ept_cb(struct rpmsg_device *rpdev, void *buf, int len, >> void *priv, u32 addr) >> @@ -280,7 +283,7 @@ static long rpmsg_eptdev_ioctl(struct file *fp, unsigned int cmd, >> if (cmd != RPMSG_DESTROY_EPT_IOCTL) >> return -EINVAL; >> >> - return rpmsg_eptdev_destroy(&eptdev->dev, NULL); >> + return rpmsg_chrdev_destroy_eptdev(&eptdev->dev, NULL); >> } >> >> static const struct file_operations rpmsg_eptdev_fops = { >> @@ -339,10 +342,9 @@ static void rpmsg_eptdev_release_device(struct device *dev) >> kfree(eptdev); >> } >> >> -static int rpmsg_eptdev_create(struct rpmsg_ctrldev *ctrldev, >> - struct rpmsg_channel_info chinfo) >> +int rpmsg_chrdev_create_eptdev(struct rpmsg_device *rpdev, struct device *parent, >> + struct rpmsg_channel_info chinfo, struct class *rpmsg_class) >> { >> - struct rpmsg_device *rpdev = ctrldev->rpdev; >> struct rpmsg_eptdev *eptdev; >> struct device *dev; >> int ret; >> @@ -362,7 +364,7 @@ static int rpmsg_eptdev_create(struct rpmsg_ctrldev *ctrldev, >> >> device_initialize(dev); >> dev->class = rpmsg_class; >> - dev->parent = &ctrldev->dev; >> + dev->parent = parent; >> dev->groups = rpmsg_eptdev_groups; >> dev_set_drvdata(dev, eptdev); >> >> @@ -405,6 +407,7 @@ static int rpmsg_eptdev_create(struct rpmsg_ctrldev *ctrldev, >> >> return ret; >> } >> +EXPORT_SYMBOL(rpmsg_chrdev_create_eptdev); >> >> static int rpmsg_ctrldev_open(struct inode *inode, struct file *filp) >> { >> @@ -444,7 +447,7 @@ static long rpmsg_ctrldev_ioctl(struct file *fp, unsigned int cmd, >> chinfo.src = eptinfo.src; >> chinfo.dst = eptinfo.dst; >> >> - return rpmsg_eptdev_create(ctrldev, chinfo); >> + return rpmsg_chrdev_create_eptdev(ctrldev->rpdev, &ctrldev->dev, chinfo, rpmsg_class); >> }; >> >> static const struct file_operations rpmsg_ctrldev_fops = { >> @@ -530,7 +533,7 @@ static void rpmsg_chrdev_remove(struct rpmsg_device *rpdev) >> int ret; >> >> /* Destroy all endpoints */ >> - ret = device_for_each_child(&ctrldev->dev, NULL, rpmsg_eptdev_destroy); >> + ret = device_for_each_child(&ctrldev->dev, NULL, rpmsg_chrdev_destroy_eptdev); >> if (ret) >> dev_warn(&rpdev->dev, "failed to nuke endpoints: %d\n", ret); >> >> diff --git a/drivers/rpmsg/rpmsg_char.h b/drivers/rpmsg/rpmsg_char.h >> new file mode 100644 >> index 000000000000..379d2ae2bee8 >> --- /dev/null >> +++ b/drivers/rpmsg/rpmsg_char.h >> @@ -0,0 +1,50 @@ >> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ >> +/* >> + * Copyright (C) STMicroelectronics 2021. >> + */ >> + >> +#ifndef __RPMSG_CHRDEV_H__ >> +#define __RPMSG_CHRDEV_H__ >> + >> +#if IS_REACHABLE(CONFIG_RPMSG_CHAR) >> +/** >> + * rpmsg_chrdev_create_eptdev() - register char device based on an endpoint >> + * @rpdev: prepared rpdev to be used for creating endpoints >> + * @parent: parent device >> + * @chinfo: assiated endpoint channel information. >> + * >> + * This function create a new rpmsg char endpoint device to instantiate a new >> + * endpoint based on chinfo information. >> + */ >> +int rpmsg_chrdev_create_eptdev(struct rpmsg_device *rpdev, struct device *parent, >> + struct rpmsg_channel_info chinfo, struct class *rpmsg_class); >> + >> +/** >> + * rpmsg_chrdev_destroy_eptdev() - destroy created char device endpoint. >> + * @data: private data associated to the endpoint device >> + * >> + * This function destroys a rpmsg char endpoint device created by the RPMSG_DESTROY_EPT_IOCTL >> + * control. >> + */ >> +int rpmsg_chrdev_destroy_eptdev(struct device *dev, void *data); >> + >> +#else /*IS_REACHABLE(CONFIG_RPMSG_CHAR) */ >> + >> +static inline int rpmsg_chrdev_create_eptdev(struct rpmsg_device *rpdev, struct device *parent, >> + struct rpmsg_channel_info chinfo, >> + struct class *rpmsg_class) >> +{ >> + return -EINVAL; >> +} >> + >> +static inline int rpmsg_chrdev_destroy_eptdev(struct device *dev, void *data) >> +{ >> + /* This shouldn't be possible */ >> + WARN_ON(1); >> + >> + return 0; >> +} >> + >> +#endif /*IS_REACHABLE(CONFIG_RPMSG_CHAR) */ >> + >> +#endif /*__RPMSG_CHRDEV_H__ */ >> -- >> 2.17.1 >>