From: Suman Anna <s-anna@ti.com>
To: Rob Herring <robh+dt@kernel.org>, Lokesh Vutla <lokeshvutla@ti.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>, <devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/6] dt-bindings: remoteproc: Add common TI SCI rproc bindings
Date: Tue, 21 Jul 2020 17:44:04 -0500 [thread overview]
Message-ID: <deead680-9699-9de5-84af-059c31a4bbd4@ti.com> (raw)
In-Reply-To: <647642d5-5021-363f-c9c9-3714a826436c@ti.com>
Hi Rob,
On 7/21/20 11:40 AM, Suman Anna wrote:
> Hi Rob,
>
> On 7/21/20 10:53 AM, Rob Herring wrote:
>> On Fri, Jul 17, 2020 at 5:48 PM Suman Anna <s-anna@ti.com> wrote:
>>>
>>> Add a bindings document that lists the common TI SCI properties
>>> used by the K3 R5F and DSP remoteproc devices.
>>>
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>> ---
>>> v4: Addressed both of Rob's review comments on ti,sci-proc-ids property
>>> v3: https://patchwork.kernel.org/patch/11602317/
>>>
>>> .../bindings/remoteproc/ti,k3-sci-proc.yaml | 48 +++++++++++++++++++
>>> 1 file changed, 48 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> new file mode 100644
>>> index 000000000000..0dca2ffdbc48
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-sci-proc.yaml
>>> @@ -0,0 +1,48 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/remoteproc/ti,k3-sci-proc.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Common TI K3 remote processor device bindings
>>> +
>>> +maintainers:
>>> + - Suman Anna <s-anna@ti.com>
>>> +
>>> +description: |
>>> + The TI K3 family of SoCs usually have one or more remote processor
>>> sub-systems
>>> + like the dual-core R5F sub-system or a C66x or C71x DSP processor
>>> subsystem.
>>> + The device management of these remote processors is managed by a
>>> dedicated
>>> + System Processor, and the communication with that processor is
>>> managed through
>>> + the TI-SCI protocol.
>>> +
>>> + Each remote processor device node should define a common set of
>>> properties
>>> + that allows the System Processor firmware to perform the device
>>> management
>>> + such as powering the IPs, asserting/deasserting the resets for
>>> each of these
>>> + processors.
>>> +
>>> +properties:
>>> + ti,sci:
>>> + $ref: /schemas/types.yaml#/definitions/phandle
>>> + description:
>>> + Should be a phandle to the TI-SCI System Controller node
>>> +
>>> + ti,sci-dev-id:
>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>> + description: |
>>> + Should contain the TI-SCI device id corresponding to the
>>> remote processor
>>> + core. Please refer to the corresponding System Controller
>>> documentation
>>> + for valid values.
>>
>> These also apply on Lokesh's series converting ti,sci-int[ra]
>> bindings. Please rework to use for both.
>
> OK.
OK, I have reworked for this and posted it [1] as part of v5 of this series.
regards
Suman
[1] https://patchwork.kernel.org/patch/11676821/
>
>>
>>> +
>>> + ti,sci-proc-ids:
>>> + description: Should contain a single tuple of <proc_id host_id>.
>>> + $ref: /schemas/types.yaml#/definitions/uint32-array
>>> + items:
>>> + - description: TI-SCI processor id for the remote processor
>>> device
>>> + - description: TI-SCI host id to which processor control
>>> ownership
>>> + should be transferred to
>
> This property is not required for the ti,sci-int[ra].
>
> I can plan to move this to a common location like
> Documentation/devicetree/bindings/arm/keystone/ and let the individual
> bindings define the required properties. Does that sound ok to you?
>
> regards
> Suman
>
>>> +
>>> +required:
>>> + - ti,sci
>>> + - ti,sci-dev-id
>>> + - ti,sci-proc-ids
>>> --
>>> 2.26.0
>>>
>
next prev parent reply other threads:[~2020-07-21 22:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 23:47 [PATCH v4 0/6] TI K3 DSP remoteproc driver for C66x DSPs Suman Anna
2020-07-17 23:47 ` [PATCH v4 1/6] remoteproc: Introduce rproc_of_parse_firmware() helper Suman Anna
2020-07-17 23:47 ` [PATCH v4 2/6] remoteproc: k3: Add TI-SCI processor control helper functions Suman Anna
2020-07-17 23:47 ` [PATCH v4 3/6] dt-bindings: remoteproc: Add common TI SCI rproc bindings Suman Anna
2020-07-20 22:17 ` Rob Herring
2020-07-20 23:26 ` Suman Anna
2020-07-21 2:32 ` Rob Herring
2020-07-21 15:53 ` Rob Herring
2020-07-21 16:40 ` Suman Anna
2020-07-21 22:44 ` Suman Anna [this message]
2020-07-17 23:47 ` [PATCH v4 4/6] dt-bindings: remoteproc: Add bindings for C66x DSPs on TI K3 SoCs Suman Anna
2020-07-17 23:47 ` [PATCH v4 5/6] remoteproc: k3-dsp: Add a remoteproc driver of K3 C66x DSPs Suman Anna
2020-07-17 23:48 ` [PATCH v4 6/6] remoteproc: k3-dsp: Add support for L2RAM loading on " Suman Anna
2020-07-21 14:43 ` [PATCH v4 0/6] TI K3 DSP remoteproc driver for " Suman Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deead680-9699-9de5-84af-059c31a4bbd4@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).