From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Suman Anna <s-anna@ti.com>, Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Loic Pallardy <loic.pallardy@st.com>,
Tero Kristo <t-kristo@ti.com>, <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] remoteproc: Fall back to using parent memory pool if no dedicated available
Date: Thu, 7 May 2020 17:52:08 +0200 [thread overview]
Message-ID: <ee210c43-eeda-6980-2c74-6a8e4f4de7f6@st.com> (raw)
In-Reply-To: <20200420160600.10467-2-s-anna@ti.com>
Hi Suman
On 4/20/20 6:05 PM, Suman Anna wrote:
> From: Tero Kristo <t-kristo@ti.com>
>
> In some cases, like with OMAP remoteproc, we are not creating dedicated
> memory pool for the virtio device. Instead, we use the same memory pool
> for all shared memories. The current virtio memory pool handling forces
> a split between these two, as a separate device is created for it,
> causing memory to be allocated from bad location if the dedicated pool
> is not available. Fix this by falling back to using the parent device
> memory pool if dedicated is not available.
As it fixes the implementation of the legacy, that seems reasonable to me.
Acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
>
> Fixes: 086d08725d34 ("remoteproc: create vdev subdevice with specific dma memory pool")
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v3:
> - Go back to v1 logic (removed the vdevbuf_mem_id variable added in v2)
> - Revised the comment to remove references to vdevbuf_mem_id
> - Capitalize the patch header
> v2: https://patchwork.kernel.org/patch/11447651/
>
> drivers/remoteproc/remoteproc_virtio.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c
> index e61d738d9b47..44187fe43677 100644
> --- a/drivers/remoteproc/remoteproc_virtio.c
> +++ b/drivers/remoteproc/remoteproc_virtio.c
> @@ -376,6 +376,18 @@ int rproc_add_virtio_dev(struct rproc_vdev *rvdev, int id)
> goto out;
> }
> }
> + } else {
> + struct device_node *np = rproc->dev.parent->of_node;
> +
> + /*
> + * If we don't have dedicated buffer, just attempt to re-assign
> + * the reserved memory from our parent. A default memory-region
> + * at index 0 from the parent's memory-regions is assigned for
> + * the rvdev dev to allocate from. Failure is non-critical and
> + * the allocations will fall back to global pools, so don't
> + * check return value either.
> + */
> + of_reserved_mem_device_init_by_idx(dev, np, 0);
> }
>
> /* Allocate virtio device */
>
next prev parent reply other threads:[~2020-05-07 15:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 16:05 [PATCH v3 0/2] Misc. rproc fixes around fixed memory region support Suman Anna
2020-04-20 16:05 ` Suman Anna
2020-04-20 16:05 ` [PATCH v3 1/2] remoteproc: Fall back to using parent memory pool if no dedicated available Suman Anna
2020-04-20 16:05 ` Suman Anna
2020-05-07 15:52 ` Arnaud POULIQUEN [this message]
2020-05-08 22:27 ` Mathieu Poirier
2020-04-20 16:06 ` [PATCH v3 2/2] remoteproc: Fix and restore the parenting hierarchy for vdev Suman Anna
2020-04-20 16:06 ` Suman Anna
2020-05-02 18:29 ` [PATCH v3 0/2] Misc. rproc fixes around fixed memory region support Suman Anna
2020-05-08 15:14 ` Suman Anna
2020-05-12 23:10 ` Bjorn Andersson
2020-05-13 9:50 ` Tero Kristo
2020-05-13 6:20 ` patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee210c43-eeda-6980-2c74-6a8e4f4de7f6@st.com \
--to=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mathieu.poirier@linaro.org \
--cc=s-anna@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).