From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D641C64EC7 for ; Tue, 28 Feb 2023 13:35:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229515AbjB1Nfs (ORCPT ); Tue, 28 Feb 2023 08:35:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjB1Nfs (ORCPT ); Tue, 28 Feb 2023 08:35:48 -0500 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D34F0196AB; Tue, 28 Feb 2023 05:35:46 -0800 (PST) Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31S7QTQ9017835; Tue, 28 Feb 2023 13:35:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=tsUfXmQDNYr6ASvuTFr+KKzEQmpBqjlfN2tgGFpkf7A=; b=Yy2YXisuU5VdUXX84FoQImYNuxWfRHM+7BtitcryRBHv4QtjOSBOeGjLCsCsMVvqgMf3 MyPdNGipjLLJyDP0VzHSVf9PLYLKEBmxX907ER99t4SsIU3OS9jdKJrGlC2wfLV5vqVc bPJmdV/Tq1Agz4q3DVi83uXjW3f27V6SYK0ckN9JtsdGheVc7WP3ToOvZrbTMiychB+o zpoh1+dyX5hZ1lmSbi+LvKd+XRDAciXhNeVFAis1PYEsx1UWKxPzTYVQCeQq0ebdx07A IaTwV9hsAG9r9b72vrBSgvjScw3trkI/HFPH3OzwDNlqs0WzQJM5WwVWLL/B83oMSfom Uw== Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3p0u3jusue-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Feb 2023 13:35:40 +0000 Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31SDZdUG004218 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Feb 2023 13:35:39 GMT Received: from [10.216.42.110] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 28 Feb 2023 05:35:35 -0800 Message-ID: Date: Tue, 28 Feb 2023 19:05:31 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 08/20] remoteproc: remove MODULE_LICENSE in non-modules Content-Language: en-US To: Nick Alcock , CC: , , Hitomi Hasegawa , Bjorn Andersson , Mathieu Poirier , References: <20230228130215.289081-1-nick.alcock@oracle.com> <20230228130215.289081-9-nick.alcock@oracle.com> From: Mukesh Ojha In-Reply-To: <20230228130215.289081-9-nick.alcock@oracle.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: QN2qm9qIKtWCADb_Eb-GsxJqUTed7YYL X-Proofpoint-GUID: QN2qm9qIKtWCADb_Eb-GsxJqUTed7YYL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-02-28_09,2023-02-28_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 bulkscore=0 impostorscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302280109 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 2/28/2023 6:32 PM, Nick Alcock wrote: > Since commit 8b41fc4454e ("kbuild: create modules.builtin without > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations > are used to identify modules. As a consequence, uses of the macro > in non-modules will cause modprobe to misidentify their containing > object file as a module when it is not (false positives), and modprobe > might succeed rather than failing with a suitable error message. > > So remove it in the files in this commit, none of which can be built as > modules. > > Signed-off-by: Nick Alcock > Suggested-by: Luis Chamberlain > Cc: Luis Chamberlain > Cc: linux-modules@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: Hitomi Hasegawa > Cc: Bjorn Andersson > Cc: Mathieu Poirier > Cc: linux-remoteproc@vger.kernel.org Acked-by: Mukesh Ojha -Mukesh > --- > drivers/remoteproc/remoteproc_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 1cd4815a6dd19..de1ace44cb57b 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -2765,5 +2765,4 @@ static void __exit remoteproc_exit(void) > } > module_exit(remoteproc_exit); > > -MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("Generic Remote Processor Framework");