From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 077E5C433ED for ; Thu, 13 May 2021 02:47:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C394B61413 for ; Thu, 13 May 2021 02:47:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230149AbhEMCtC (ORCPT ); Wed, 12 May 2021 22:49:02 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:50050 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbhEMCtC (ORCPT ); Wed, 12 May 2021 22:49:02 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14D2ljqr012163; Wed, 12 May 2021 21:47:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1620874065; bh=CVL24IXjC7hS/rORC2nMLVaPFRAth7V3AD9AbT6OxgY=; h=Subject:From:To:CC:References:Date:In-Reply-To; b=ohtqtg3h70b1QcdUPjyCMG0N9JyIV82M+uk+TEsSdLZDUq8Uhq8G61Gj9M7mD2aWO h7EnD5cTwYy8nLP1fSpTWp4+Z+QG60mmeiMwOH5BKYJzYcIFtNP2jEYEUBvWuLaBW5 0jJZGF7JYZrHPLS3r2U3D37oH/50BjDGilvaKYU8= Received: from DFLE106.ent.ti.com (dfle106.ent.ti.com [10.64.6.27]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14D2lid3070216 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 12 May 2021 21:47:44 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 12 May 2021 21:47:44 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 12 May 2021 21:47:44 -0500 Received: from [10.250.33.185] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14D2li1V024269; Wed, 12 May 2021 21:47:44 -0500 Subject: Re: [PATCH v2 1/2] dt-bindings: remoteproc: k3-r5f: Update bindings for AM64x SoCs From: Suman Anna To: Bjorn Andersson , Mathieu Poirier , Rob Herring CC: Lokesh Vutla , , , , References: <20210327143117.1840-1-s-anna@ti.com> <20210327143117.1840-2-s-anna@ti.com> <8948a30c-1a2f-1fb0-05bb-37be9c02c5d5@ti.com> Message-ID: Date: Wed, 12 May 2021 21:47:44 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8948a30c-1a2f-1fb0-05bb-37be9c02c5d5@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org Hi Rob, On 4/19/21 8:55 AM, Suman Anna wrote: > Hi Rob, > > On 3/27/21 9:31 AM, Suman Anna wrote: >> The K3 AM64x SoCs have two dual-core Arm R5F clusters/subsystems, with >> 2 R5F cores each, both in the MAIN voltage domain. >> >> These clusters are a revised IP version compared to those present on >> J721E and J7200 SoCs, and supports a new "Single-CPU" mode instead of >> LockStep mode. Update the K3 R5F remoteproc bindings with the compatible >> info relevant to these R5F clusters/subsystems on K3 AM64x SoCs. >> >> Signed-off-by: Suman Anna >> --- >> v2: No changes >> >> .../bindings/remoteproc/ti,k3-r5f-rproc.yaml | 31 ++++++++++++++++--- > > Looks like this patch has fallen through the cracks, can you please review and > give your ack for this patch so that Bjorn can pick up the series for 5.13? Gentle reminder, do you have any comments on this patch. Appreciate your ack so that we can get this in for 5.14? regards Suman > > regards > Suman > >> 1 file changed, 26 insertions(+), 5 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml >> index d905d614502b..130fbaacc4b1 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-r5f-rproc.yaml >> @@ -14,8 +14,12 @@ description: | >> processor subsystems/clusters (R5FSS). The dual core cluster can be used >> either in a LockStep mode providing safety/fault tolerance features or in a >> Split mode providing two individual compute cores for doubling the compute >> - capacity. These are used together with other processors present on the SoC >> - to achieve various system level goals. >> + capacity on most SoCs. These are used together with other processors present >> + on the SoC to achieve various system level goals. >> + >> + AM64x SoCs do not support LockStep mode, but rather a new non-safety mode >> + called "Single-CPU" mode, where only Core0 is used, but with ability to use >> + Core1's TCMs as well. >> >> Each Dual-Core R5F sub-system is represented as a single DTS node >> representing the cluster, with a pair of child DT nodes representing >> @@ -33,6 +37,7 @@ properties: >> - ti,am654-r5fss >> - ti,j721e-r5fss >> - ti,j7200-r5fss >> + - ti,am64-r5fss >> >> power-domains: >> description: | >> @@ -56,11 +61,12 @@ properties: >> >> ti,cluster-mode: >> $ref: /schemas/types.yaml#/definitions/uint32 >> - enum: [0, 1] >> description: | >> Configuration Mode for the Dual R5F cores within the R5F cluster. >> - Should be either a value of 1 (LockStep mode) or 0 (Split mode), >> - default is LockStep mode if omitted. >> + Should be either a value of 1 (LockStep mode) or 0 (Split mode) on >> + most SoCs (AM65x, J721E, J7200), default is LockStep mode if omitted; >> + and should be either a value of 0 (Split mode) or 2 (Single-CPU mode) >> + on AM64x SoCs, default is Split mode if omitted. >> >> # R5F Processor Child Nodes: >> # ========================== >> @@ -97,6 +103,7 @@ patternProperties: >> - ti,am654-r5f >> - ti,j721e-r5f >> - ti,j7200-r5f >> + - ti,am64-r5f >> >> reg: >> items: >> @@ -198,6 +205,20 @@ patternProperties: >> >> unevaluatedProperties: false >> >> +if: >> + properties: >> + compatible: >> + enum: >> + - ti,am64-r5fss >> +then: >> + properties: >> + ti,cluster-mode: >> + enum: [0, 2] >> +else: >> + properties: >> + ti,cluster-mode: >> + enum: [0, 1] >> + >> required: >> - compatible >> - power-domains >> >