From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Mason Yang <masonccyang@mxic.com.tw>,
broonie@kernel.org, marek.vasut@gmail.com,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
bbrezillon@kernel.org, linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, juliensu@mxic.com.tw,
Simon Horman <horms@verge.net.au>,
miquel.raynal@bootlin.com
Subject: Re: [PATCH v13 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings
Date: Mon, 3 Jun 2019 17:55:25 +0300 [thread overview]
Message-ID: <02addf64-9f6e-ccc1-2f94-8983456e3ebc@cogentembedded.com> (raw)
In-Reply-To: <20190603130428.GX4797@dell>
Hello!
On 06/03/2019 04:04 PM, Lee Jones wrote:
>>> Document the bindings used by the Renesas R-Car Gen3 RPC-IF controller.
>>>
>>> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
>>> ---
>>> .../devicetree/bindings/mfd/renesas-rpc-if.txt | 65 ++++++++++++++++++++++
>>> 1 file changed, 65 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/mfd/renesas-rpc-if.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/mfd/renesas-rpc-if.txt b/Documentation/devicetree/bindings/mfd/renesas-rpc-if.txt
>>> new file mode 100644
>>> index 0000000..20ec85b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/mfd/renesas-rpc-if.txt
>>> @@ -0,0 +1,65 @@
>>> +Renesas R-Car Gen3 RPC-IF controller Device Tree Bindings
>>> +---------------------------------------------------------
>>> +
>>> +RPC-IF supports both SPI NOR and HyperFlash (CFI-compliant flash)
>>> +
>>> +Required properties:
>>> +- compatible: should be an SoC-specific compatible value, followed by
>>> + "renesas,rcar-gen3-rpc" as a fallback.
>>> + supported SoC-specific values are:
>>> + "renesas,r8a77995-rpc" (R-Car D3)
>>> +- reg: should contain three register areas:
>>> + first for RPC-IF registers,
>>> + second for the direct mapping read mode and
>>> + third for the write buffer area.
>>> +- reg-names: should contain "regs", "dirmap" and "wbuf"
>>> +- clocks: should contain 1 entries for the module's clock
>>> +- clock-names: should contain "rpc"
>>> +- power-domains: should contain system-controller(sysc) for power-domain-cell
>>> +- resets: should contain clock pulse generator(cpg) for reset-cell,
>>> + power-domain-cell and clock-cell
>>
>> That's just some nonsense, sorry...
>> I suggest that you stop reposting your patches as I'm going to post
>> my version of this patchset RSN (based on your patches, of course) and I'm
>> going to take care of fixing this file as well.
>
> Why is this necessary?
Because Mason doesn't want to develop the HyperFlash driver (or even move his code
in preparation to this driver being developed). I must develop this driver, and I'd
like to avoid the extra churn of mving the code between the MFD and SPI drivers.
> Why not just provide some constructive feedback instead?
I was providing the feedback during these 13 revisions... unfortunately, it wasn't
fully considered.
>>> +- #address-cells: should be 1
>>> +- #size-cells: should be 0
>> [...]
MBR, Sergei
next prev parent reply other threads:[~2019-06-03 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 7:19 [PATCH v13 0/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD & SPI driver Mason Yang
2019-05-21 7:19 ` [PATCH v13 1/3] mfd: Add Renesas R-Car Gen3 RPC-IF MFD driver Mason Yang
2019-06-03 13:02 ` Lee Jones
2019-06-04 0:52 ` masonccyang
2019-05-21 7:19 ` [PATCH v13 2/3] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver Mason Yang
2019-05-21 7:19 ` [PATCH v13 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3 RPC-IF controller bindings Mason Yang
2019-05-22 16:50 ` Sergei Shtylyov
2019-05-23 9:16 ` masonccyang
2019-06-03 13:04 ` Lee Jones
2019-06-03 14:55 ` Sergei Shtylyov [this message]
2019-06-06 7:40 ` masonccyang
2019-06-18 12:01 ` Marek Vasut
2019-06-19 7:36 ` masonccyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02addf64-9f6e-ccc1-2f94-8983456e3ebc@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=juliensu@mxic.com.tw \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).