From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4951C432BE for ; Fri, 30 Jul 2021 12:32:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B4F860F0F for ; Fri, 30 Jul 2021 12:32:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbhG3McE convert rfc822-to-8bit (ORCPT ); Fri, 30 Jul 2021 08:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbhG3McD (ORCPT ); Fri, 30 Jul 2021 08:32:03 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2817C061765 for ; Fri, 30 Jul 2021 05:31:57 -0700 (PDT) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m9RgA-0001JJ-Uj; Fri, 30 Jul 2021 14:31:54 +0200 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1m9Rg9-0007mm-Hz; Fri, 30 Jul 2021 14:31:53 +0200 Message-ID: <048851b26d012069ecaf52286ec48d2b4e38571d.camel@pengutronix.de> Subject: Re: [PATCH 3/7] drm/imx/dcss: Enable COMPILE_TEST on all ARM64 platforms From: Philipp Zabel To: Geert Uytterhoeven , Laurent Pinchart Cc: DRI Development , Linux-Renesas , linux-tegra , Laurentiu Palcu , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Tomi Valkeinen , Thierry Reding , Jonathan Hunter , Jyri Sarha Date: Fri, 30 Jul 2021 14:31:53 +0200 In-Reply-To: References: <20210728153736.15240-1-laurent.pinchart+renesas@ideasonboard.com> <20210728153736.15240-4-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-renesas-soc@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org On Fri, 2021-07-30 at 14:10 +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Wed, Jul 28, 2021 at 5:37 PM Laurent Pinchart > wrote: > > To extend test coverage, relax the dependency on ARCH_MXC to also enable > > compilation when COMPILE_TEST is selected. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch! > > > --- a/drivers/gpu/drm/imx/dcss/Kconfig > > +++ b/drivers/gpu/drm/imx/dcss/Kconfig > > @@ -3,7 +3,8 @@ config DRM_IMX_DCSS > > select IMX_IRQSTEER > > select DRM_KMS_CMA_HELPER > > select VIDEOMODE_HELPERS > > - depends on DRM && ARCH_MXC && ARM64 > > + depends on DRM > > + depends on ARM64 && (ARCH_MXC || COMPILE_TEST) > > As you now have two depends statements, I think this would be easier > to read by maintaining a strict separation between "hard" and "soft" > dependencies: > > depends on DRM && ARM64 > depends on ARCH_MXC || COMPILE_TEST I would let (ARCH_MXC && ARM64) stay together, and as Tomi suggested, lift the ARM64 limitation if COMPILE_TEST is enabled: depends on DRM depends on (ARCH_MXC && ARM64) || COMPILE_TEST regards Philipp