From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28502C07E96 for ; Thu, 15 Jul 2021 10:34:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0AC6060BD3 for ; Thu, 15 Jul 2021 10:34:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237171AbhGOKg4 (ORCPT ); Thu, 15 Jul 2021 06:36:56 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:38940 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbhGOKgz (ORCPT ); Thu, 15 Jul 2021 06:36:55 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0C8B5227C4; Thu, 15 Jul 2021 10:34:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626345242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C3r+MoQUZftGFnoLGddjeoKLQ4Jj5UP2WoHBg7J4MxQ=; b=dBrJ9y99WLWDqycColkJmBYqNv/okAiBYmaifn3GyvmTS5Y70MlK75NgUsFTdpZghUt9xc gUtnFCCVez4U4PAGI24qiOMenU9a9o/PVUG4BwtQks0dePBrMMmsPbQImyNwyDqFAKf0aq ERb8jtiZuy0rM3f0+wjM8yTRkwgM2Xg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626345242; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C3r+MoQUZftGFnoLGddjeoKLQ4Jj5UP2WoHBg7J4MxQ=; b=EEiHlCuyPF/SdBoCvwuZ2kMt+zt2eqp+Q04zCUNfWMDi0yr7tI54oTC852fFjDReNCnu2T +SQe8gCXy+muKXBA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id CF27713D7E; Thu, 15 Jul 2021 10:34:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id tayqMBkP8GD9GgAAGKfGzw (envelope-from ); Thu, 15 Jul 2021 10:34:01 +0000 Subject: Re: [PATCH v2] drm/shmobile: Convert to Linux IRQ interfaces To: Geert Uytterhoeven Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Sam Ravnborg , Sergei Shtylyov , Linux-Renesas , DRI Development References: <20210715095729.6510-1-tzimmermann@suse.de> From: Thomas Zimmermann Message-ID: <09c12fee-4698-18bc-0bb1-db8ae31caed5@suse.de> Date: Thu, 15 Jul 2021 12:34:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QlEDNAiSROcThjuLbZwhf8SHcE7IAZqwl" Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QlEDNAiSROcThjuLbZwhf8SHcE7IAZqwl Content-Type: multipart/mixed; boundary="cggzFFcQel5JbHQ8e5Pz6I6E79ipARwNv"; protected-headers="v1" From: Thomas Zimmermann To: Geert Uytterhoeven Cc: Laurent Pinchart , Kieran Bingham , David Airlie , Daniel Vetter , Sam Ravnborg , Sergei Shtylyov , Linux-Renesas , DRI Development Message-ID: <09c12fee-4698-18bc-0bb1-db8ae31caed5@suse.de> Subject: Re: [PATCH v2] drm/shmobile: Convert to Linux IRQ interfaces References: <20210715095729.6510-1-tzimmermann@suse.de> In-Reply-To: --cggzFFcQel5JbHQ8e5Pz6I6E79ipARwNv Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 15.07.21 um 12:16 schrieb Geert Uytterhoeven: > Hi Thomas, >=20 > On Thu, Jul 15, 2021 at 11:57 AM Thomas Zimmermann wrote: >> Drop the DRM IRQ midlayer in favor of Linux IRQ interfaces. DRM's >> IRQ helpers are mostly useful for UMS drivers. Modern KMS drivers >> don't benefit from using it. >> >> v2: >> * handle errors in platform_get_irq() (Geert, Sergei) >> * store IRQ number in struct shmob_drm_device (Laurent) >> >> Signed-off-by: Thomas Zimmermann >=20 > Thanks for the update! >=20 >> --- a/drivers/gpu/drm/shmobile/shmob_drm_drv.c >> +++ b/drivers/gpu/drm/shmobile/shmob_drm_drv.c >> @@ -258,7 +256,15 @@ static int shmob_drm_probe(struct platform_device= *pdev) >> goto err_modeset_cleanup; >> } >> >> - ret =3D drm_irq_install(ddev, platform_get_irq(pdev, 0)); >> + ret =3D platform_get_irq(pdev, 0); >> + if (ret) { >=20 > if (ret < 0) { Indeed :/ >=20 >> + dev_err(&pdev->dev, "failed to get IRQ number\n"); >=20 > platform_get_irq() already prints an error message, so no need to > repeat it. >=20 >> + goto err_modeset_cleanup; >> + } >> + sdev->irq =3D ret; >> + >> + ret =3D request_irq(sdev->irq, shmob_drm_irq, 0, ddev->driver-= >name, >> + ddev); >> if (ret < 0) { >> dev_err(&pdev->dev, "failed to install IRQ handler\n"= ); >> goto err_modeset_cleanup; >=20 > Gr{oetje,eeting}s, >=20 > Geert >=20 --=20 Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany (HRB 36809, AG N=C3=BCrnberg) Gesch=C3=A4ftsf=C3=BChrer: Felix Imend=C3=B6rffer --cggzFFcQel5JbHQ8e5Pz6I6E79ipARwNv-- --QlEDNAiSROcThjuLbZwhf8SHcE7IAZqwl Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsF5BAABCAAjFiEExndm/fpuMUdwYFFolh/E3EQov+AFAmDwDxkFAwAAAAAACgkQlh/E3EQov+Bk EBAAgIhEvBHfKwf19G0lkreQfqww5H74xCJvVgA2iotGEW3Xq5ywzmsSdFjE0aEusqT7dJAgqz+v 6daRrqwn+sw8S2+3DdEvz1vt7JgWVyz5hbLcFhagOpDiTe2ylyGoaLAKV8ozrL/gjy6rRZvrAtnh clEAus2qiP9MoWZjMy/2Kxynoa/bkTetfqbKv+K6NnYVy8I7ZZOjh2RNv/+eL4vgspotoT/LFbSs W1tqnMZ2re8aKn3zDMozdYgWLcDr0Q+Hgy2zhF1fKhSVzAc/Pe2icPNYXWJUPtaVhNE3HPXMvIWt arqbR4bVsYg3rPdcTtSVJOU9jmXwBaqUj1v1gae/mukswvW7MRaYpPnMo8hloc1SoTqN8ZRXrN+A xJD2sdvXqQEYvjJ1v9WwR33B0ypmDK+3omMDWIvsy5971a5d6r8XESXBUsK84y85NsNGQdCvdVHk Qmu5N2saR8JUWRwHXOxyLCvhcLE9b4z+gcuZ2YlVSASbZ7xMwCcP/e+9gbybTqOteOn8iKe1ZjPN d6GQr0YR7b1znqTuSOWhaWYXcVIZa3b49oyNqJeBb/btrnlRmLhZTVphWTK+8569ApWFr6PWIUux 05Vf5eBQCj0ife8bQ1EjlqEJsdaRKrs77n+Sn5hxuyoT4Bz9uWNlcoF7bkr4Ef5Ni9AW58UKj6BT XWo= =l3ly -----END PGP SIGNATURE----- --QlEDNAiSROcThjuLbZwhf8SHcE7IAZqwl--