From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83637C282CB for ; Mon, 4 Feb 2019 16:26:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 558052083B for ; Mon, 4 Feb 2019 16:26:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linaro.org header.i=@linaro.org header.b="aVSLiJos" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbfBDQ0D (ORCPT ); Mon, 4 Feb 2019 11:26:03 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:38637 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729514AbfBDQ0C (ORCPT ); Mon, 4 Feb 2019 11:26:02 -0500 Received: by mail-wm1-f65.google.com with SMTP id m22so541049wml.3 for ; Mon, 04 Feb 2019 08:26:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9lKepzvlFqSdyTmpHqFOS3txG3e1Qlnve7EeoiMfLO0=; b=aVSLiJosF7nsn2YlMbkWjfe/sQt+HQvDzUEKw4RhgQWgOVm70k9HPSiS5kbBVP/nE1 uxICapIcLqWzWM7keOzeU4tTM3C0LF+hWtIqKxl8GXPDB84dVtX59Ewhs+KjNoSXstgm a7axZ2Vk2Aky3bhhwgyM5lpXXxhrlCVDzQPX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9lKepzvlFqSdyTmpHqFOS3txG3e1Qlnve7EeoiMfLO0=; b=fP5R1qJiKVPL6+B7TdykPOH6egkwzDgq51Yt/ErSSBfQaHAwrl+aG1QKsrBDGQXbKN ny+aQ/csUKseVkLFaw6HzdhkVALQq7lnYFy0mgb64N+iED3JIo3RXs1/K38TfDVj3X3b 0nRSqJ9sWoSLFz6u1duQLAUGGzxE5jpWCumhRn4cNA75ATcKE7B/FSc2R6f2zIKqvTVq ocP+JQFVNqspIB8d2j/Eg1nDQXRKUMdshhHZDqnhJoVO0wSGPU6yVeWMejZ0c+GFm6Db tH3jAYuTDq1tIfG2ZEEcKuHyJMxyKsYTQ2R68qnspPBzvxyyn093nQKTgHxjXREWDHg4 8OzA== X-Gm-Message-State: AHQUAubsiQypsWnt1gnGJkLlw0d+of5G85f5pvYks3C7i7rlgTcF413S vmlktpSkb+sR35ru/p4Hr52N2A== X-Google-Smtp-Source: AHgI3IZ7M0ze84wTX8DLxUv882QQUfhGHmbTLyFg1PCjFq7A45aNiEqTtsmhl2YBtsRd3HsDJdr2vw== X-Received: by 2002:a1c:b456:: with SMTP id d83mr127459wmf.115.1549297559980; Mon, 04 Feb 2019 08:25:59 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:70b6:b9c6:89e2:36a]) by smtp.gmail.com with ESMTPSA id a4sm1251992wrt.37.2019.02.04.08.25.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 04 Feb 2019 08:25:59 -0800 (PST) From: Vincent Guittot To: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, ulf.hansson@linaro.org, biju.das@bp.renesas.com Cc: linux-arm-kernel@lists.infradead.org, geert@linux-m68k.org, thara.gopinath@linaro.org, linux-renesas-soc@vger.kernel.org, Vincent Guittot Subject: [PATCH 2/2] PM-runtime: update time accounting only when enabled Date: Mon, 4 Feb 2019 17:25:53 +0100 Message-Id: <1549297553-17647-3-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1549297553-17647-1-git-send-email-vincent.guittot@linaro.org> References: <1549297553-17647-1-git-send-email-vincent.guittot@linaro.org> Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Update accounting_timestamp field only when PM runtime is enable and don't forget to account the last state before disabling it. Suggested-by: Ulf Hansson Signed-off-by: Vincent Guittot --- drivers/base/power/runtime.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index 50740da..ed62cca 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -66,11 +66,14 @@ static int rpm_suspend(struct device *dev, int rpmflags); */ void update_pm_runtime_accounting(struct device *dev) { - u64 now = ktime_get_mono_fast_ns(); - u64 last = dev->power.accounting_timestamp; - u64 delta; + u64 now, last, delta; - dev->power.accounting_timestamp = now; + if (dev->power.disable_depth > 0) + return; + + last = dev->power.accounting_timestamp; + + dev->power.accounting_timestamp = now = ktime_get_mono_fast_ns(); /* * Because ktime_get_mono_fast_ns() is not monotonic during @@ -82,9 +85,6 @@ void update_pm_runtime_accounting(struct device *dev) delta = now - last; - if (dev->power.disable_depth > 0) - return; - if (dev->power.runtime_status == RPM_SUSPENDED) dev->power.suspended_time += delta; else @@ -1298,6 +1298,9 @@ void __pm_runtime_disable(struct device *dev, bool check_resume) pm_runtime_put_noidle(dev); } + /* Update time accounting before disabling pm runtime */ + update_pm_runtime_accounting(dev); + if (!dev->power.disable_depth++) __pm_runtime_barrier(dev); @@ -1521,7 +1524,6 @@ void pm_runtime_init(struct device *dev) dev->power.request_pending = false; dev->power.request = RPM_REQ_NONE; dev->power.deferred_resume = false; - dev->power.accounting_timestamp = 0; INIT_WORK(&dev->power.work, pm_runtime_work); dev->power.timer_expires = 0; -- 2.7.4