From: Biju Das <biju.das@bp.renesas.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Biju Das <biju.das@bp.renesas.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Simon Horman <horms+renesas@verge.net.au>,
Fabrizio Castro <fabrizio.castro@bp.renesas.com>,
Kees Cook <keescook@chromium.org>,
linux-usb@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Chris Paterson <Chris.Paterson2@renesas.com>,
linux-renesas-soc@vger.kernel.org
Subject: [PATCH 4/9] usb: gadget: udc: renesas_usb3: use extcon framework to receive connect/disconnect
Date: Wed, 6 Mar 2019 09:07:21 +0000 [thread overview]
Message-ID: <1551863246-11656-5-git-send-email-biju.das@bp.renesas.com> (raw)
In-Reply-To: <1551863246-11656-1-git-send-email-biju.das@bp.renesas.com>
RZ/G2E cat874 board is capable of detecting cable connect and disconnect
events. Add support for renesas_usb3 to receive connect and disconnect
notification using extcon framework.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
drivers/usb/gadget/udc/renesas_usb3.c | 115 +++++++++++++++++++++++++++++-----
1 file changed, 99 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/gadget/udc/renesas_usb3.c b/drivers/usb/gadget/udc/renesas_usb3.c
index 7dc2485..2c69d5d 100644
--- a/drivers/usb/gadget/udc/renesas_usb3.c
+++ b/drivers/usb/gadget/udc/renesas_usb3.c
@@ -351,6 +351,11 @@ struct renesas_usb3 {
int disabled_count;
struct usb_request *ep0_req;
+
+ struct extcon_dev *edev;
+ struct notifier_block ufp_nb;
+ struct notifier_block dfp_nb;
+
u16 test_mode;
u8 ep0_buf[USB3_EP0_BUF_SIZE];
bool softconnect;
@@ -644,22 +649,6 @@ static void usb3_disconnect(struct renesas_usb3 *usb3)
usb3->driver->disconnect(&usb3->gadget);
}
-static void usb3_check_vbus(struct renesas_usb3 *usb3)
-{
- if (usb3->workaround_for_vbus) {
- usb3_connect(usb3);
- } else {
- usb3->extcon_usb = !!(usb3_read(usb3, USB3_USB_STA) &
- USB_STA_VBUS_STA);
- if (usb3->extcon_usb)
- usb3_connect(usb3);
- else
- usb3_disconnect(usb3);
-
- schedule_work(&usb3->extcon_work);
- }
-}
-
static void renesas_usb3_role_work(struct work_struct *work)
{
struct renesas_usb3 *usb3 =
@@ -724,6 +713,32 @@ static void usb3_check_id(struct renesas_usb3 *usb3)
schedule_work(&usb3->extcon_work);
}
+static void usb3_check_vbus(struct renesas_usb3 *usb3)
+{
+ if (usb3->workaround_for_vbus) {
+ if (usb3->edev) {
+ if (extcon_get_state(usb3->edev, EXTCON_USB) == true) {
+ usb3->forced_b_device = true;
+ usb3->start_to_connect = true;
+ usb3_disconnect(usb3);
+ usb3_check_id(usb3);
+ } else if (extcon_get_state(usb3->edev,
+ EXTCON_USB_HOST) == false)
+ usb3_vbus_out(usb3, false);
+ } else
+ usb3_connect(usb3);
+ } else {
+ usb3->extcon_usb = !!(usb3_read(usb3, USB3_USB_STA) &
+ USB_STA_VBUS_STA);
+ if (usb3->extcon_usb)
+ usb3_connect(usb3);
+ else
+ usb3_disconnect(usb3);
+
+ schedule_work(&usb3->extcon_work);
+ }
+}
+
static void renesas_usb3_init_controller(struct renesas_usb3 *usb3)
{
usb3_init_axi_bridge(usb3);
@@ -2656,6 +2671,47 @@ static const struct usb_role_switch_desc renesas_usb3_role_switch_desc = {
.allow_userspace_control = true,
};
+static int renesas_usb3_ufp_notifier(struct notifier_block *nb,
+ unsigned long event, void *ptr)
+{
+ struct renesas_usb3 *usb3 = container_of(nb,
+ struct renesas_usb3, ufp_nb);
+
+ usb3->start_to_connect = false;
+ if (event && usb3->driver) {
+ usb3->forced_b_device = true;
+ usb3->start_to_connect = true;
+ }
+
+ if (usb3->driver) {
+ usb3_disconnect(usb3);
+ usb3_check_id(usb3);
+ }
+
+ usb3_vbus_out(usb3, false);
+ dev_dbg(usb3_to_dev(usb3), "ufp_notifier event=%ld", event);
+
+ return NOTIFY_DONE;
+}
+
+static int renesas_usb3_dfp_notifier(struct notifier_block *nb,
+ unsigned long event, void *ptr)
+{
+ struct renesas_usb3 *usb3 = container_of(nb,
+ struct renesas_usb3, dfp_nb);
+
+ if (event) {
+ usb3->forced_b_device = false;
+ usb3_disconnect(usb3);
+ usb3_check_id(usb3);
+ } else
+ usb3_vbus_out(usb3, false);
+
+ dev_dbg(usb3_to_dev(usb3), "dfp_notifier event=%ld", event);
+
+ return NOTIFY_DONE;
+}
+
static int renesas_usb3_probe(struct platform_device *pdev)
{
struct renesas_usb3 *usb3;
@@ -2703,6 +2759,33 @@ static int renesas_usb3_probe(struct platform_device *pdev)
return ret;
INIT_WORK(&usb3->extcon_work, renesas_usb3_extcon_work);
+
+ if (priv->workaround_for_vbus &&
+ of_property_read_bool(pdev->dev.of_node, "extcon")) {
+ usb3->edev = extcon_get_edev_by_phandle(&pdev->dev, 0);
+ if (IS_ERR(usb3->edev))
+ return PTR_ERR(usb3->edev);
+
+ usb3->ufp_nb.notifier_call = renesas_usb3_ufp_notifier;
+ ret = devm_extcon_register_notifier(&pdev->dev, usb3->edev,
+ EXTCON_USB, &usb3->ufp_nb);
+ if (ret < 0)
+ dev_dbg(&pdev->dev, "USB register notifier failed\n");
+
+ usb3->dfp_nb.notifier_call = renesas_usb3_dfp_notifier;
+ ret = devm_extcon_register_notifier(&pdev->dev, usb3->edev,
+ EXTCON_USB_HOST, &usb3->dfp_nb);
+ if (ret < 0)
+ dev_dbg(&pdev->dev,
+ "USB-HOST register notifier failed\n");
+ if (extcon_get_state(usb3->edev, EXTCON_USB) == true) {
+ usb3->forced_b_device = true;
+ usb3->start_to_connect = true;
+ } else if (extcon_get_state(usb3->edev,
+ EXTCON_USB_HOST) == false)
+ usb3_vbus_out(usb3, false);
+ }
+
usb3->extcon = devm_extcon_dev_allocate(&pdev->dev, renesas_usb3_cable);
if (IS_ERR(usb3->extcon))
return PTR_ERR(usb3->extcon);
--
2.7.4
next prev parent reply other threads:[~2019-03-06 9:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 9:07 [PATCH 0/9] Add USB3.0 and TI HD3SS3220 driver support Biju Das
2019-03-06 9:07 ` [PATCH 1/9] dt-bindings: usb: hd3ss3220 device tree binding document Biju Das
2019-03-06 9:07 ` [PATCH 2/9] dt-bindings: usb: renesas_usb3: add extcon support Biju Das
2019-03-27 23:28 ` Rob Herring
2019-03-28 13:04 ` Biju Das
2019-03-06 9:07 ` [PATCH 3/9] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller Biju Das
2019-03-06 11:34 ` Heikki Krogerus
2019-03-07 15:57 ` Biju Das
2019-03-06 9:07 ` Biju Das [this message]
2019-03-06 12:43 ` [PATCH 4/9] usb: gadget: udc: renesas_usb3: use extcon framework to receive connect/disconnect Heikki Krogerus
2019-03-07 16:02 ` Biju Das
2019-03-06 9:07 ` [PATCH 5/9] arm64: defconfig: enable TYPEC_HD3SS3220 config option Biju Das
2019-03-06 9:07 ` [PATCH 6/9] arm64: renesas_defconfig: Enable " Biju Das
2019-03-06 9:07 ` [PATCH 7/9] arm64: dts: renesas: r8a774c0-cat874: enable USB3.0 host/peripheral device node Biju Das
2019-03-06 9:07 ` [PATCH 8/9] arm64: dts: renesas: r8a774c0-cat874: Enable TI HD3SS3220 support Biju Das
2019-03-06 9:07 ` [PATCH 9/9] arm64: dts: renesas: r8a774c0-cat874: Enable extcon support Biju Das
2019-03-06 13:09 ` [PATCH 0/9] Add USB3.0 and TI HD3SS3220 driver support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551863246-11656-5-git-send-email-biju.das@bp.renesas.com \
--to=biju.das@bp.renesas.com \
--cc=Chris.Paterson2@renesas.com \
--cc=balbi@kernel.org \
--cc=fabrizio.castro@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=horms+renesas@verge.net.au \
--cc=horms@verge.net.au \
--cc=keescook@chromium.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).