* [PATCH v2 0/2] Fix SDR50 on iwg20d and iwg23s
@ 2019-06-03 9:53 Fabrizio Castro
2019-06-03 9:53 ` [PATCH v2 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
2019-06-03 9:53 ` [PATCH v2 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
0 siblings, 2 replies; 5+ messages in thread
From: Fabrizio Castro @ 2019-06-03 9:53 UTC (permalink / raw)
To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
Chris Paterson, Biju Das
Dear All,
SDR50 has been broken on both the iwg20d and the iwg23s since
commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors").
This patch series fixes the problem with the iWave platforms.
v1->v2:
* Removed enable-active-high property
Thanks,
Fab
Fabrizio Castro (2):
ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator
arch/arm/boot/dts/iwg20d-q7-common.dtsi | 2 +-
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
2019-06-03 9:53 [PATCH v2 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
@ 2019-06-03 9:53 ` Fabrizio Castro
2019-06-06 8:54 ` Simon Horman
2019-06-03 9:53 ` [PATCH v2 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
1 sibling, 1 reply; 5+ messages in thread
From: Fabrizio Castro @ 2019-06-03 9:53 UTC (permalink / raw)
To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
Chris Paterson, Biju Das
SDR50 isn't working anymore because the GPIO regulator
driver is using descriptors since
commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
which in turn causes the system to use the polarity of the
GPIOs (as specified in the DT) for selecting the states,
but the polarity specified in the DT is wrong.
This patch fixes the regulator DT definition, and that fixes
SDR50.
Fixes: 029efb3a03c5 ("ARM: dts: iwg20d-q7: Add SDHI1 support")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
v1->v2:
* Removed enable-active-high property
---
arch/arm/boot/dts/iwg20d-q7-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/iwg20d-q7-common.dtsi b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
index e2b1ab9..ae75a1db 100644
--- a/arch/arm/boot/dts/iwg20d-q7-common.dtsi
+++ b/arch/arm/boot/dts/iwg20d-q7-common.dtsi
@@ -87,7 +87,7 @@
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
- gpios = <&gpio2 30 GPIO_ACTIVE_LOW>;
+ gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
gpios-states = <1>;
states = <3300000 1
1800000 0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator
2019-06-03 9:53 [PATCH v2 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
2019-06-03 9:53 ` [PATCH v2 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
@ 2019-06-03 9:53 ` Fabrizio Castro
2019-06-06 8:55 ` Simon Horman
1 sibling, 1 reply; 5+ messages in thread
From: Fabrizio Castro @ 2019-06-03 9:53 UTC (permalink / raw)
To: Simon Horman, Geert Uytterhoeven, Rob Herring, Mark Rutland
Cc: Fabrizio Castro, Magnus Damm, linux-renesas-soc, devicetree,
Chris Paterson, Biju Das
SDR50 isn't working anymore because the GPIO regulator
driver is using descriptors since
commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
which in turn causes the system to use the polarity of the
GPIOs (as specified in the DT) for selecting the states,
but the polarity specified in the DT is wrong.
This patch fixes the regulator DT definition, and that fixes
SDR50.
Fixes: 9eb36b945b5c ("ARM: dts: iwg23s-sbc: Add uSD and eMMC support")
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
v1->v2:
* Removed enable-active-high property
---
arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
index af78e77..450efe9 100644
--- a/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
+++ b/arch/arm/boot/dts/r8a77470-iwg23s-sbc.dts
@@ -63,7 +63,7 @@
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
- gpios = <&gpio2 24 GPIO_ACTIVE_LOW>;
+ gpios = <&gpio2 24 GPIO_ACTIVE_HIGH>;
gpios-states = <1>;
states = <3300000 1
1800000 0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor
2019-06-03 9:53 ` [PATCH v2 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
@ 2019-06-06 8:54 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2019-06-06 8:54 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland, Magnus Damm,
linux-renesas-soc, devicetree, Chris Paterson, Biju Das
On Mon, Jun 03, 2019 at 10:53:51AM +0100, Fabrizio Castro wrote:
> SDR50 isn't working anymore because the GPIO regulator
> driver is using descriptors since
> commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
> which in turn causes the system to use the polarity of the
> GPIOs (as specified in the DT) for selecting the states,
> but the polarity specified in the DT is wrong.
> This patch fixes the regulator DT definition, and that fixes
> SDR50.
>
> Fixes: 029efb3a03c5 ("ARM: dts: iwg20d-q7: Add SDHI1 support")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Thanks, I have applied this for inclusion in v5.3.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator
2019-06-03 9:53 ` [PATCH v2 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
@ 2019-06-06 8:55 ` Simon Horman
0 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2019-06-06 8:55 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Geert Uytterhoeven, Rob Herring, Mark Rutland, Magnus Damm,
linux-renesas-soc, devicetree, Chris Paterson, Biju Das
On Mon, Jun 03, 2019 at 10:53:52AM +0100, Fabrizio Castro wrote:
> SDR50 isn't working anymore because the GPIO regulator
> driver is using descriptors since
> commit d6cd33ad7102 ("regulator: gpio: Convert to use descriptors")
> which in turn causes the system to use the polarity of the
> GPIOs (as specified in the DT) for selecting the states,
> but the polarity specified in the DT is wrong.
> This patch fixes the regulator DT definition, and that fixes
> SDR50.
>
> Fixes: 9eb36b945b5c ("ARM: dts: iwg23s-sbc: Add uSD and eMMC support")
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Thanks, I have applied this for inclusion in v5.3.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-06 8:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 9:53 [PATCH v2 0/2] Fix SDR50 on iwg20d and iwg23s Fabrizio Castro
2019-06-03 9:53 ` [PATCH v2 1/2] ARM: dts: iwg20d-q7-common: Fix SDHI1 VccQ regularor Fabrizio Castro
2019-06-06 8:54 ` Simon Horman
2019-06-03 9:53 ` [PATCH v2 2/2] ARM: dts: iwg23s-sbc: Fix SDHI2 VccQ regulator Fabrizio Castro
2019-06-06 8:55 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).