* [PATCH v2 0/2] usb: renesas_usbhs: remove unused features
@ 2019-06-05 6:16 Yoshihiro Shimoda
2019-06-05 6:16 ` [PATCH v2 1/2] usb: renesas_usbhs: remove sudmac support Yoshihiro Shimoda
2019-06-05 6:16 ` [PATCH v2 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support Yoshihiro Shimoda
0 siblings, 2 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2019-06-05 6:16 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-renesas-soc, Yoshihiro Shimoda
This patch series removes unused features of sudmac and controlling
PWEN/EXTLP.
Changes from v1 [1]:
- Revise the commit log on both patch 1 and 2.
- Remove an unused macro on patch 1.
- Add Geert-san and Simon-san's Reviewed-by on both patch 1 and 2.
[1]
https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=126687
Yoshihiro Shimoda (2):
usb: renesas_usbhs: remove sudmac support
usb: renesas_usbhs: remove controlling PWEN/EXTLP support
drivers/usb/renesas_usbhs/common.c | 4 ----
drivers/usb/renesas_usbhs/fifo.c | 6 +-----
include/linux/usb/renesas_usbhs.h | 2 --
3 files changed, 1 insertion(+), 11 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/2] usb: renesas_usbhs: remove sudmac support
2019-06-05 6:16 [PATCH v2 0/2] usb: renesas_usbhs: remove unused features Yoshihiro Shimoda
@ 2019-06-05 6:16 ` Yoshihiro Shimoda
2019-06-05 6:16 ` [PATCH v2 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support Yoshihiro Shimoda
1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2019-06-05 6:16 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-renesas-soc, Yoshihiro Shimoda
SUDMAC feature was supported in v3.10, but was never used by
any platform. So, this patch removes it.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/usb/renesas_usbhs/fifo.c | 6 +-----
include/linux/usb/renesas_usbhs.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index 452b456..e84d2ac2 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -12,7 +12,6 @@
#include "pipe.h"
#define usbhsf_get_cfifo(p) (&((p)->fifo_info.cfifo))
-#define usbhsf_is_cfifo(p, f) (usbhsf_get_cfifo(p) == f)
#define usbhsf_fifo_is_busy(f) ((f)->pipe) /* see usbhs_pipe_select_fifo */
@@ -325,10 +324,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe,
}
/* "base" will be used below */
- if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo))
- usbhs_write(priv, fifo->sel, base);
- else
- usbhs_write(priv, fifo->sel, base | MBW_32);
+ usbhs_write(priv, fifo->sel, base | MBW_32);
/* check ISEL and CURPIPE value */
while (timeout--) {
diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h
index 3f53043..a2481f4d 100644
--- a/include/linux/usb/renesas_usbhs.h
+++ b/include/linux/usb/renesas_usbhs.h
@@ -187,7 +187,6 @@ struct renesas_usbhs_driver_param {
* option:
*/
u32 has_otg:1; /* for controlling PWEN/EXTLP */
- u32 has_sudmac:1; /* for SUDMAC */
u32 has_usb_dmac:1; /* for USB-DMAC */
u32 runtime_pwctrl:1;
u32 has_cnen:1;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support
2019-06-05 6:16 [PATCH v2 0/2] usb: renesas_usbhs: remove unused features Yoshihiro Shimoda
2019-06-05 6:16 ` [PATCH v2 1/2] usb: renesas_usbhs: remove sudmac support Yoshihiro Shimoda
@ 2019-06-05 6:16 ` Yoshihiro Shimoda
1 sibling, 0 replies; 3+ messages in thread
From: Yoshihiro Shimoda @ 2019-06-05 6:16 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-renesas-soc, Yoshihiro Shimoda
Controlling PWMEN/EXTLP (named as "has_otg") was supported in v3.2,
but the last user (kzm9g) was removed by the commit 30f8925a57d8ad49
("ARM: shmobile: Remove legacy board code for KZM-A9-GT"). So, this
patch remove it.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/usb/renesas_usbhs/common.c | 4 ----
include/linux/usb/renesas_usbhs.h | 1 -
2 files changed, 5 deletions(-)
diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index c7c9c5d..a501ea6 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -95,10 +95,6 @@ void usbhs_sys_host_ctrl(struct usbhs_priv *priv, int enable)
{
u16 mask = DCFM | DRPD | DPRPU | HSE | USBE;
u16 val = DCFM | DRPD | HSE | USBE;
- int has_otg = usbhs_get_dparam(priv, has_otg);
-
- if (has_otg)
- usbhs_bset(priv, DVSTCTR, (EXTLP | PWEN), (EXTLP | PWEN));
/*
* if enable
diff --git a/include/linux/usb/renesas_usbhs.h b/include/linux/usb/renesas_usbhs.h
index a2481f4d..b2cba7c 100644
--- a/include/linux/usb/renesas_usbhs.h
+++ b/include/linux/usb/renesas_usbhs.h
@@ -186,7 +186,6 @@ struct renesas_usbhs_driver_param {
/*
* option:
*/
- u32 has_otg:1; /* for controlling PWEN/EXTLP */
u32 has_usb_dmac:1; /* for USB-DMAC */
u32 runtime_pwctrl:1;
u32 has_cnen:1;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-05 6:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-05 6:16 [PATCH v2 0/2] usb: renesas_usbhs: remove unused features Yoshihiro Shimoda
2019-06-05 6:16 ` [PATCH v2 1/2] usb: renesas_usbhs: remove sudmac support Yoshihiro Shimoda
2019-06-05 6:16 ` [PATCH v2 2/2] usb: renesas_usbhs: remove controlling PWEN/EXTLP support Yoshihiro Shimoda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).