From: Ulrich Hecht <uli+renesas@fpond.eu>
To: linux-renesas-soc@vger.kernel.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
sergei.shtylyov@cogentembedded.com,
niklas.soderlund@ragnatech.se, wsa@the-dreams.de,
horms@verge.net.au, magnus.damm@gmail.com,
Ulrich Hecht <uli+renesas@fpond.eu>
Subject: [PATCH v2] ravb: implement MTU change while device is up
Date: Wed, 5 Jun 2019 17:14:20 +0200 [thread overview]
Message-ID: <1559747660-17875-1-git-send-email-uli+renesas@fpond.eu> (raw)
Uses the same method as various other drivers: shut the device down,
change the MTU, then bring it back up again.
Tested on Renesas D3 Draak board.
Signed-off-by: Ulrich Hecht <uli+renesas@fpond.eu>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
Hi!
This revision incorporates Simon's and Sergei's suggestions, namely calling
netdev_update_features() whether the device is up or not. Thanks to
reviewers!
CU
Uli
drivers/net/ethernet/renesas/ravb_main.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index ef8f089..00427e7 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1811,11 +1811,14 @@ static int ravb_do_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
static int ravb_change_mtu(struct net_device *ndev, int new_mtu)
{
if (netif_running(ndev))
- return -EBUSY;
+ ravb_close(ndev);
ndev->mtu = new_mtu;
netdev_update_features(ndev);
+ if (netif_running(ndev))
+ return ravb_open(ndev);
+
return 0;
}
--
2.7.4
next reply other threads:[~2019-06-05 15:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 15:14 Ulrich Hecht [this message]
2019-06-05 15:16 ` [PATCH v2] ravb: implement MTU change while device is up Geert Uytterhoeven
2019-06-05 17:27 ` Sergei Shtylyov
2019-06-06 2:08 ` David Miller
2019-06-14 15:28 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559747660-17875-1-git-send-email-uli+renesas@fpond.eu \
--to=uli+renesas@fpond.eu \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).